fix(approvals,delegation,restart,scheduler): check ExecContext errors sweep #2 #2041

Closed
core-be wants to merge 2 commits from fix/execcontext-err-check-sweep2 into staging
Member
No description provided.
core-be added 1 commit 2026-06-01 03:36:27 +00:00
fix(approvals,delegation,restart,scheduler): check ExecContext errors sweep #2
E2E API Smoke Test / E2E API Smoke Test (pull_request) Blocked by required conditions
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Blocked by required conditions
Harness Replays / Harness Replays (pull_request) Blocked by required conditions
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Blocked by required conditions
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 14s
branch-protection drift check / Branch protection drift (pull_request) Successful in 3s
cascade-list-drift-gate / check (pull_request) Successful in 3s
Check merge_group trigger on required workflows / Required workflows have merge_group trigger (pull_request) Successful in 6s
Check migration collisions / Migration version collision check (pull_request) Successful in 7s
CI / Detect changes (pull_request) Successful in 8s
CodeQL / Analyze (${{ matrix.language }}) (go) (pull_request) Failing after 1s
CodeQL / Analyze (${{ matrix.language }}) (javascript-typescript) (pull_request) Failing after 2s
CodeQL / Analyze (${{ matrix.language }}) (python) (pull_request) Failing after 1s
E2E API Smoke Test / detect-changes (pull_request) Successful in 6s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 6s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 4s
Harness Replays / detect-changes (pull_request) Successful in 5s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 9s
Secret scan / Scan diff for credential-shaped strings (pull_request) Failing after 26s
qa-review / approved (pull_request) Successful in 4s
security-review / approved (pull_request) Successful in 4s
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 34s
sop-checklist / review-refire (pull_request) Has been skipped
sop-checklist / na-declarations (pull_request) N/A: (none)
Runtime Pin Compatibility / PyPI-latest install + import smoke (pull_request) Successful in 1m31s
gate-check-v3 / gate-check (pull_request) Successful in 5s
sop-checklist / all-items-acked (pull_request) Successful in 4s
sop-tier-check / tier-check (pull_request) Successful in 7s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 9s
CI / Platform (Go) (pull_request) Successful in 3m6s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 5s
CI / Canvas (Next.js) (pull_request) Failing after 2m23s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / Python Lint & Test (pull_request) Failing after 7m10s
0265fcd96d
Adds error handling for unchecked/discarded db.DB.ExecContext calls:
- approvals.go: auto-expire stale approvals
- delegation.go: clean up failed activity logs on retry
- workspace_restart.go: auto-restart provisioning status update
- scheduler.go: reset empty-run counter, record skipped run, log skipped activity

Prevents silent failures during approval lifecycle, delegation retry,
auto-restart, and cron schedule bookkeeping.
core-be changed target branch from main to staging 2026-06-01 03:40:06 +00:00
core-be force-pushed fix/execcontext-err-check-sweep2 from 0265fcd96d to 21fd206ed3 2026-06-01 04:27:52 +00:00 Compare
core-be added 1 commit 2026-06-01 12:40:34 +00:00
ci: remove unused canvasUserMessage type to fix lint on staging
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
CI / Detect changes (pull_request) Successful in 12s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 22s
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
E2E Chat / detect-changes (pull_request) Successful in 9s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 7s
CI / Platform (Go) (pull_request) Successful in 5m44s
CI / Canvas (Next.js) (pull_request) Successful in 7m38s
CI / Python Lint & Test (pull_request) Successful in 7m20s
Harness Replays / detect-changes (pull_request) Successful in 5s
CI / all-required (pull_request) Successful in 6m11s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 20s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 9s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m39s
gate-check-v3 / gate-check (pull_request_target) Successful in 7s
qa-review / approved (pull_request_target) Successful in 4s
security-review / approved (pull_request_target) Successful in 6s
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-checklist / all-items-acked (pull_request_target) Successful in 6s
sop-tier-check / tier-check (pull_request_target) Successful in 6s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m54s
Harness Replays / Harness Replays (pull_request) Successful in 8s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 12s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m13s
E2E Chat / E2E Chat (pull_request) Failing after 7m43s
audit-force-merge / audit (pull_request_target) Has been skipped
a47aecf952
internal/handlers/a2a_proxy_helpers.go:412 had an unused struct that
causes golangci-lint `unused` failure on every PR targeting staging.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Member

Closing — based on the dead staging fork; this fix is already on main. main already checks these ExecContext errors: approvals auto-expire (approvals.go:90), runRestartCycle provisioning set (workspace_restart.go:847), and scheduler reset/recordSkipped (scheduler.go:495-502, 677-686, 703-709). Per the staging-deprecation cleanup; target main for future PRs.

Closing — based on the dead `staging` fork; this fix is already on `main`. main already checks these ExecContext errors: approvals auto-expire (approvals.go:90), runRestartCycle provisioning set (workspace_restart.go:847), and scheduler reset/recordSkipped (scheduler.go:495-502, 677-686, 703-709). Per the staging-deprecation cleanup; target `main` for future PRs.
devops-engineer closed this pull request 2026-06-01 18:28:17 +00:00
Some required checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
CI / Detect changes (pull_request) Successful in 12s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 22s
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
E2E Chat / detect-changes (pull_request) Successful in 9s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 7s
CI / Platform (Go) (pull_request) Successful in 5m44s
CI / Canvas (Next.js) (pull_request) Successful in 7m38s
CI / Python Lint & Test (pull_request) Successful in 7m20s
Harness Replays / detect-changes (pull_request) Successful in 5s
CI / all-required (pull_request) Successful in 6m11s
Required
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 20s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 9s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m39s
gate-check-v3 / gate-check (pull_request_target) Successful in 7s
qa-review / approved (pull_request_target) Successful in 4s
security-review / approved (pull_request_target) Successful in 6s
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Required
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-checklist / all-items-acked (pull_request_target) Successful in 6s
sop-tier-check / tier-check (pull_request_target) Successful in 6s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m54s
Harness Replays / Harness Replays (pull_request) Successful in 8s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 12s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m13s
E2E Chat / E2E Chat (pull_request) Failing after 7m43s
audit-force-merge / audit (pull_request_target) Has been skipped

Pull request closed

Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2041