fix(canvas): SSOT-drive runtime picker so google-adk shows correctly #2016

Merged

core-be merged 2 commits from feat/google-adk-runtime-ssot into main 2026-05-31 09:46:31 +00:00

Conversation 6 Commits 2 Files Changed 4

+193 -2

core-be commented 2026-05-31 08:27:12 +00:00

Member

Copy Link

Copy Source

Problem

The ConfigTab runtime dropdown filtered GET /templates through a hardcoded SUPPORTED_RUNTIME_VALUES allowlist (claude-code/codex/openclaw/hermes). google-adk ships in manifest.json and the workspace-server knownRuntimes registry, but this frontend Set silently dropped it — so a google-adk workspace's Config tab rendered the wrong runtime option, and Save & Restart would clobber the runtime (same class as the hermes "Claude Code (default)" bug, #1894).

Fix (SSOT-driven)

GET /templates is already gated to the manifest maintained set by loadRuntimesFromManifest, so the picker should trust the backend, not re-filter it.

• canvas ConfigTab.tsx: remove SUPPORTED_RUNTIME_VALUES; show every runtime /templates serves, hiding one only when its template declares displayable: false. Add google-adk to the offline fallback.
• workspace-server templates.go: add optional Displayable *bool (yaml+json, omitempty) plumbed config.yaml → /templates, so a runtime opts out of the picker declaratively (replaces the hardcoded frontend gate).

Tests

• ConfigTab.googleAdk.test.tsx — google-adk selected; displayable:false hidden.
• TestTemplatesList_DisplayableFlag — nil/true/false + omitempty JSON contract.

Local: vitest changed-area 76 passed; go test ./internal/handlers ok; eslint+gofmt+vet clean.

🤖 Generated with Claude Code

## Problem The ConfigTab runtime dropdown filtered `GET /templates` through a hardcoded `SUPPORTED_RUNTIME_VALUES` allowlist (`claude-code/codex/openclaw/hermes`). `google-adk` ships in `manifest.json` and the workspace-server `knownRuntimes` registry, but this frontend Set silently dropped it — so a google-adk workspace's Config tab rendered the wrong runtime option, and **Save & Restart would clobber the runtime** (same class as the hermes "Claude Code (default)" bug, #1894). ## Fix (SSOT-driven) `GET /templates` is already gated to the manifest maintained set by `loadRuntimesFromManifest`, so the picker should trust the backend, not re-filter it. - **canvas `ConfigTab.tsx`**: remove `SUPPORTED_RUNTIME_VALUES`; show every runtime `/templates` serves, hiding one only when its template declares `displayable: false`. Add `google-adk` to the offline fallback. - **workspace-server `templates.go`**: add optional `Displayable *bool` (yaml+json, omitempty) plumbed config.yaml → `/templates`, so a runtime opts out of the picker declaratively (replaces the hardcoded frontend gate). ## Tests - `ConfigTab.googleAdk.test.tsx` — google-adk selected; `displayable:false` hidden. - `TestTemplatesList_DisplayableFlag` — nil/true/false + omitempty JSON contract. Local: vitest changed-area 76 passed; `go test ./internal/handlers` ok; eslint+gofmt+vet clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

core-be added 1 commit 2026-05-31 08:27:12 +00:00

fix(canvas): SSOT-drive runtime picker so google-adk shows correctly ... b611b1a9bf

The ConfigTab runtime dropdown filtered GET /templates through a hardcoded
SUPPORTED_RUNTIME_VALUES allowlist (claude-code/codex/openclaw/hermes).
google-adk shipped in manifest.json + the workspace-server knownRuntimes
registry but was dropped by this frontend Set, so a google-adk workspace's
Config tab rendered the wrong runtime option and a Save would clobber the
runtime to the wrong value.

Make the picker trust the backend SSOT: /templates is already gated to the
manifest maintained set by loadRuntimesFromManifest. Remove the allowlist;
hide a runtime only when its template declares displayable:false (new
optional flag plumbed manifest config.yaml -> templateSummary -> /templates).

- canvas/ConfigTab.tsx: drop SUPPORTED_RUNTIME_VALUES; filter on
  r.displayable===false; add google-adk to offline FALLBACK list.
- workspace-server templates.go: add Displayable *bool (yaml+json,
  omitempty) so a template can opt out of the picker declaratively.
- tests: ConfigTab.googleAdk.test.tsx (google-adk selected + displayable
  hidden) + TestTemplatesList_DisplayableFlag (nil/true/false + JSON contract).

Refs project_canvas_runtime_dropdown_ssot_fix.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

core-qa approved these changes 2026-05-31 08:35:03 +00:00

Dismissed

core-qa left a comment

Member

Copy Link

Copy Source

QA review: SSOT-driven runtime picker — verified the dropdown now derives from /templates (manifest-gated) instead of the hardcoded allowlist; new ConfigTab.googleAdk test covers google-adk selected + displayable:false hidden; TestTemplatesList_DisplayableFlag covers nil/true/false + JSON omitempty. LGTM.

QA review: SSOT-driven runtime picker — verified the dropdown now derives from /templates (manifest-gated) instead of the hardcoded allowlist; new ConfigTab.googleAdk test covers google-adk selected + displayable:false hidden; TestTemplatesList_DisplayableFlag covers nil/true/false + JSON omitempty. LGTM.

core-security approved these changes 2026-05-31 08:35:03 +00:00

Dismissed

core-security left a comment

Member

Copy Link

Copy Source

Security review: change is display/filtering only; no auth/secret surface touched. Displayable is an additive opt-out flag (pointer, omitempty), no privilege implications. LGTM.

Security review: change is display/filtering only; no auth/secret surface touched. Displayable is an additive opt-out flag (pointer, omitempty), no privilege implications. LGTM.

core-qa commented 2026-05-31 08:35:17 +00:00

Member

Copy Link

Copy Source

/qa-recheck

/qa-recheck

core-security commented 2026-05-31 08:35:17 +00:00

Member

Copy Link

Copy Source

/security-recheck

/security-recheck

core-be added 1 commit 2026-05-31 09:17:32 +00:00

ci: re-trigger after gitea restart task desync (no-op) ... 418db083ff

Empty commit on the PR branch to get a clean CI run; the prior run's
tasks were orphaned by the 2026-05-31 08:30 gitea restart (task-not-found).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

core-qa approved these changes 2026-05-31 09:17:33 +00:00

core-qa left a comment

Member

Copy Link

Copy Source

Re-approve after CI re-trigger empty commit (4cb9f0e2); code unchanged.

Re-approve after CI re-trigger empty commit (4cb9f0e2); code unchanged.

core-security approved these changes 2026-05-31 09:17:35 +00:00

core-security left a comment

Member

Copy Link

Copy Source

Re-approve after CI re-trigger empty commit (4cb9f0e2); code unchanged.

Re-approve after CI re-trigger empty commit (4cb9f0e2); code unchanged.

core-be merged commit e45033e15c into main 2026-05-31 09:46:31 +00:00

core-be referenced this issue from a commit 2026-05-31 09:46:32 +00:00

Merge pull request 'fix(canvas): SSOT-drive runtime picker so google-adk shows correctly' (#2016) from feat/google-adk-runtime-ssot into main

Sign in to join this conversation.

Reviewers

No Reviewers

core-qa

core-security

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2016