molecule-ai/molecule-core
51
0
Fork 2
Code Issues 160 Pull Requests 174 Actions 5 Packages Projects Releases Wiki Activity

fix(secrets): drop retired org-level guard from SetGlobal (global vendor keys are tenant-owned) #2002

Merged
hongming merged 1 commits from fix/setglobal-drop-retired-org-billing-guard into main 2026-05-29 04:38:15 +00:00
Conversation 2 Commits 1 Files Changed 2
+49 -55
hongming commented 2026-05-29 04:26:29 +00:00
Owner
Copy Link
Copy Source

internal#718 retired the org-level billing rung; SetGlobal still gated global vendor-key writes on the legacy MOLECULE_LLM_BILLING_MODE env, blocking a byok tenant from storing its own MINIMAX_API_KEY at global scope. Removes the org-level guard (the provision-time provider-matched strip already enforces per-workspace usage); deletes dead org-env helpers; converts the obsolete rejection test to a positive allowed-path test. Build + full handlers tests green.

internal#718 retired the org-level billing rung; SetGlobal still gated global vendor-key writes on the legacy MOLECULE_LLM_BILLING_MODE env, blocking a byok tenant from storing its own MINIMAX_API_KEY at global scope. Removes the org-level guard (the provision-time provider-matched strip already enforces per-workspace usage); deletes dead org-env helpers; converts the obsolete rejection test to a positive allowed-path test. Build + full handlers tests green.
hongming added 1 commit 2026-05-29 04:26:29 +00:00
fix(secrets): drop retired org-level guard from SetGlobal — global vendor keys are tenant-owned
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 11s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 5s
Details
CI / Python Lint & Test (pull_request) Successful in 7s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
Details
E2E Chat / detect-changes (pull_request) Successful in 8s
Details
Harness Replays / detect-changes (pull_request) Successful in 7s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 8s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 7s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 11s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 5s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
qa-review / approved (pull_request) Failing after 15s
Details
gate-check-v3 / gate-check (pull_request) Successful in 15s
Details
security-review / approved (pull_request) Failing after 7s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
verify-providers-gen / Regenerate providers artifact and fail on drift (pull_request) Successful in 31s
Details
sop-checklist / all-items-acked (pull_request) Successful in 6s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 4s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m3s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 4s
Details
E2E Chat / E2E Chat (pull_request) Successful in 12s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m4s
Details
Harness Replays / Harness Replays (pull_request) Successful in 15s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 6s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m29s
Details
CI / Platform (Go) (pull_request) Successful in 7m12s
Details
CI / all-required (pull_request) Successful in 11m6s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
audit-force-merge / audit (pull_request) Successful in 4s
Details
2cf7d006a9 
internal#718 retired the org-level LLM billing rung (billing is resolved
per-workspace now). SetGlobal still called the legacy org-env guard
rejectPlatformManagedDirectLLMBypass, which reads MOLECULE_LLM_BILLING_MODE and
400s any vendor/oauth key write when the (legacy) org default is
platform_managed. That blocked setting a tenant's own MINIMAX_API_KEY (or any
custom-provider key) at global scope on a byok tenant — agents-team hit "direct
Hermes custom provider secrets are blocked for platform-managed LLM workspaces".

A global secret is the tenant's OWN shared credential. The provision-time
provider-matched strip (workspace_provision, core#2000) already removes any
global cred a given workspace's resolved provider does not accept, and the
platform-managed path strips bypass keys at provision too — so a platform-managed
workspace can never USE a non-matching global vendor/oauth key. The SetGlobal
org-env gate was redundant belt-and-suspenders keyed off the retired rung.

- SetGlobal: remove the org-level guard call.
- Delete the now-dead legacy helpers platformManagedLLMMode +
  rejectPlatformManagedDirectLLMBypass (org-env shims; the per-workspace
  successors rejectPlatformManagedDirectLLMBypassForWorkspace /
  platformManagedLLMModeForWorkspace remain and still gate per-workspace writes).
- Tests: convert the obsolete platform-managed rejection test into
  TestSetGlobal_AllowsTenantOwnedVendorKeyDespiteLegacyOrgEnv (asserts the global
  write SUCCEEDS even with the legacy env still set to platform_managed).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
core-lead approved these changes 2026-05-29 04:26:56 +00:00
core-lead left a comment
Member
Copy Link
Copy Source

APPROVED — drops retired org-level SetGlobal guard; provision-time strip enforces per-workspace usage. Build + handler tests green.

APPROVED — drops retired org-level SetGlobal guard; provision-time strip enforces per-workspace usage. Build + handler tests green.
core-be approved these changes 2026-05-29 04:26:56 +00:00
core-be left a comment
Member
Copy Link
Copy Source

APPROVED — secrets-write boundary review: global = tenant-owned cred; per-workspace guard + strip remain. internal#718 aligned.

APPROVED — secrets-write boundary review: global = tenant-owned cred; per-workspace guard + strip remain. internal#718 aligned.
hongming merged commit 3f15c1448d into main 2026-05-29 04:38:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
core-lead
core-be
Labels
Clear labels
area/ci
CI/CD pipeline issues
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2002
Delete Branch "fix/setglobal-drop-retired-org-billing-guard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?