molecule-ai/molecule-core
51
0
Fork 2
Code Issues 160 Pull Requests 163 Actions 10 Packages Projects Releases Wiki Activity

defensive: nil-map init, marshal-error returns, NullTime guards, a2a timeout comment #1979

Closed
agent-pm wants to merge 1 commits from fix/mcp-tools-slim-residue into main
pull from: fix/mcp-tools-slim-residue
merge into: molecule-ai:main
Conversation 0 Commits 1 Files Changed 5
+20 -2
agent-pm commented 2026-05-28 02:36:57 +00:00
Member
Copy Link
Copy Source

Slim-down rebase of mol#1933 — only the residue not already in main via #1938/#1939/#1940.

Changes:

  • channels/manager.go, handlers/channels.go: initialise nil maps/slices after json.Unmarshal errors so downstream code doesn't panic on nil dereference.
  • handlers/channels.go: guard sql.NullTime .Time access with .Valid check (matches existing lastMsg.Valid pattern).
  • handlers/delegation.go, handlers/restart_signals.go: add missing return after json.Marshal error logs so we don't continue with zero/invalid payload.
  • handlers/a2a_proxy.go: document why a2aClient has no Client.Timeout (per-request ctx deadlines govern lifetime; fixed timeout would break legitimate slow cold-start flows).

No behavior change for happy path; only tightens error-path safety.

Slim-down rebase of mol#1933 — only the residue not already in main via #1938/#1939/#1940. **Changes:** - `channels/manager.go`, `handlers/channels.go`: initialise nil maps/slices after `json.Unmarshal` errors so downstream code doesn't panic on nil dereference. - `handlers/channels.go`: guard `sql.NullTime` `.Time` access with `.Valid` check (matches existing `lastMsg.Valid` pattern). - `handlers/delegation.go`, `handlers/restart_signals.go`: add missing `return` after `json.Marshal` error logs so we don't continue with zero/invalid payload. - `handlers/a2a_proxy.go`: document why `a2aClient` has no `Client.Timeout` (per-request ctx deadlines govern lifetime; fixed timeout would break legitimate slow cold-start flows). No behavior change for happy path; only tightens error-path safety.
agent-pm added 1 commit 2026-05-28 02:36:58 +00:00
defensive: nil-map init, marshal-error returns, NullTime guards, a2a timeout comment
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 11s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 13s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
CI / Python Lint & Test (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 9s
Details
E2E Chat / detect-changes (pull_request) Successful in 9s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 11s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 40s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Details
Harness Replays / detect-changes (pull_request) Successful in 8s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 9s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 9s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m18s
Details
verify-providers-gen / Regenerate providers artifact and fail on drift (pull_request) Successful in 46s
Details
gate-check-v3 / gate-check (pull_request) Successful in 12s
Details
qa-review / approved (pull_request) Failing after 10s
Details
security-review / approved (pull_request) Failing after 8s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 6s
Details
sop-tier-check / tier-check (pull_request) Successful in 5s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Successful in 4m25s
Details
audit-force-merge / audit (pull_request) Waiting to run
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 18s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m45s
Details
Harness Replays / Harness Replays (pull_request) Successful in 9s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m8s
Details
CI / Platform (Go) (pull_request) Successful in 6m6s
Details
CI / Canvas Deploy Reminder (pull_request) Has been cancelled
Details
CI / all-required (pull_request) Successful in 13m21s
Details
18ad66051c 
Residue from mol#1933 slim-down — only changes not already in main:

- channels/manager.go, handlers/channels.go: initialise nil maps/slices
  after json.Unmarshal errors so downstream code doesn't panic on nil
  dereference.
- handlers/channels.go: guard sql.NullTime .Time access with .Valid check
  (matches existing lastMsg.Valid pattern).
- handlers/delegation.go, handlers/restart_signals.go: add missing return
  after json.Marshal error logs so we don't continue with zero/invalid
  payload.
- handlers/a2a_proxy.go: document why a2aClient has no Client.Timeout
  (per-request ctx deadlines govern lifetime; fixed timeout would break
  legitimate slow cold-start flows).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
agent-pm closed this pull request 2026-05-28 02:51:06 +00:00
Some optional checks failed
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 11s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 13s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
CI / Python Lint & Test (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 9s
Details
E2E Chat / detect-changes (pull_request) Successful in 9s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 11s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 40s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Details
Harness Replays / detect-changes (pull_request) Successful in 8s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 9s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 9s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m18s
Details
verify-providers-gen / Regenerate providers artifact and fail on drift (pull_request) Successful in 46s
Details
gate-check-v3 / gate-check (pull_request) Successful in 12s
Details
qa-review / approved (pull_request) Failing after 10s
Details
security-review / approved (pull_request) Failing after 8s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 6s
Details
sop-tier-check / tier-check (pull_request) Successful in 5s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Successful in 4m25s
Details
audit-force-merge / audit (pull_request) Waiting to run
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 18s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m45s
Required
Details
Harness Replays / Harness Replays (pull_request) Successful in 9s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m8s
Required
Details
CI / Platform (Go) (pull_request) Successful in 6m6s
Details
CI / Canvas Deploy Reminder (pull_request) Has been cancelled
Details
CI / all-required (pull_request) Successful in 13m21s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1979
Delete Branch "fix/mcp-tools-slim-residue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?