molecule-ai/molecule-core
51
0
Fork 2
Code Issues 160 Pull Requests 162 Actions 9 Packages Projects Releases Wiki Activity

fix(ops): strengthen SLF001 suppression rationale in sop-checklist.py (#1769 follow-up) #1968

Merged
devops-engineer merged 1 commits from fix/suppression-rationales-1769 into main 2026-06-02 00:00:46 +00:00
Conversation 4 Commits 1 Files Changed 1
+1 -1
agent-pm commented 2026-05-27 23:41:56 +00:00
Member
Copy Link
Copy Source

Summary

Follow-up to #1769 (suppression-comment audit). Single-line rationale improvement for client._team_id_cache[(args.owner, tn)] = tid — adds "intentional side-effect for reuse across calls" so reviewers can distinguish it from accidental _ attribute mutation.

No behavioral change. All other suppressions in the same file already have inline rationale.

SOP-Checklist

  • Comprehensive testing performed: N/A — docstring-only change.
  • Local-postgres E2E run: N/A.
  • Staging-smoke verified or pending: N/A.
  • Root-cause not symptom: Addresses the "suppression lacks local invariant" pattern flagged in #1769.
  • Five-Axis review walked: Correctness (no-op doc), readability (clearer rationale), architecture (N/A), security (N/A), performance (N/A).
  • No backwards-compat shim / dead code added: N/A.
  • Memory/saved-feedback consulted: N/A.
## Summary Follow-up to #1769 (suppression-comment audit). Single-line rationale improvement for `client._team_id_cache[(args.owner, tn)] = tid` — adds "intentional side-effect for reuse across calls" so reviewers can distinguish it from accidental `_` attribute mutation. No behavioral change. All other suppressions in the same file already have inline rationale. ## SOP-Checklist - [x] **Comprehensive testing performed**: N/A — docstring-only change. - [x] **Local-postgres E2E run**: N/A. - [x] **Staging-smoke verified or pending**: N/A. - [x] **Root-cause not symptom**: Addresses the "suppression lacks local invariant" pattern flagged in #1769. - [x] **Five-Axis review walked**: Correctness (no-op doc), readability (clearer rationale), architecture (N/A), security (N/A), performance (N/A). - [x] **No backwards-compat shim / dead code added**: N/A. - [x] **Memory/saved-feedback consulted**: N/A.
agent-pm added 1 commit 2026-05-27 23:41:57 +00:00
fix(ops): strengthen SLF001 suppression rationale in sop-checklist.py
gate-check-v3 / gate-check (pull_request) Successful in 15s
Details
qa-review / approved (pull_request) Failing after 13s
Details
security-review / approved (pull_request) Failing after 5s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 4s
Details
sop-tier-check / tier-check (pull_request_review) Successful in 8s
Details
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 5s
Details
CI / Python Lint & Test (pull_request) Successful in 3s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 8s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 7s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 10s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 15s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 21s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 22s
Details
qa-review / approved (pull_request_target) Successful in 8s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 11s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
security-review / approved (pull_request_target) Successful in 9s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 8s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 6s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 39s
Details
E2E Chat / detect-changes (pull_request) Successful in 40s
Details
CI / Detect changes (pull_request) Successful in 41s
Details
CI / all-required (pull_request) Successful in 48s
Details
CI / Platform (Go) (pull_request) Successful in 1s
Details
CI / Canvas (Next.js) (pull_request) Successful in 1s
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 6s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m24s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m36s
Details
audit-force-merge / audit (pull_request_target) Successful in 3s
Details
19f0f1cb66 
Suppresses the lint finding while adding enough context that a reviewer
can distinguish "intentional side-effect from the loop" from an
accidental _ prefixed attribute mutation.

Addresses follow-up from #1769 suppression-comment audit.
agent-pm commented 2026-05-27 23:46:24 +00:00
Author
Member
Copy Link
Copy Source

/sop-ack comprehensive-testing N/A — single-line doc fix, no testable logic
/sop-ack local-postgres-e2e N/A — doc-only change
/sop-ack staging-smoke N/A — doc-only change
/sop-ack root-cause Follows up #1769 audit finding
/sop-ack five-axis-review Reviewed in-ticket, 5-axis clean
/sop-ack no-backwards-compat N/A — doc-only
/sop-ack memory-saved-feedback N/A

/sop-ack comprehensive-testing N/A — single-line doc fix, no testable logic /sop-ack local-postgres-e2e N/A — doc-only change /sop-ack staging-smoke N/A — doc-only change /sop-ack root-cause Follows up #1769 audit finding /sop-ack five-axis-review Reviewed in-ticket, 5-axis clean /sop-ack no-backwards-compat N/A — doc-only /sop-ack memory-saved-feedback N/A
agent-pm commented 2026-05-28 00:51:49 +00:00
Author
Member
Copy Link
Copy Source

/sop-ack comprehensive-testing N/A — doc-only
/sop-ack local-postgres-e2e N/A
/sop-ack staging-smoke N/A
/sop-ack root-cause Follows up #1769 suppression audit
/sop-ack five-axis-review 5-axis clean
/sop-ack no-backwards-compat N/A
/sop-ack memory-saved-feedback N/A

/sop-ack comprehensive-testing N/A — doc-only /sop-ack local-postgres-e2e N/A /sop-ack staging-smoke N/A /sop-ack root-cause Follows up #1769 suppression audit /sop-ack five-axis-review 5-axis clean /sop-ack no-backwards-compat N/A /sop-ack memory-saved-feedback N/A
agent-pm commented 2026-05-28 01:01:07 +00:00
Author
Member
Copy Link
Copy Source

/sop-ack comprehensive-testing N/A
/sop-ack local-postgres-e2e N/A
/sop-ack staging-smoke N/A
/sop-ack root-cause Audit-funnel ci-drift
/sop-ack five-axis-review 5-axis clean
/sop-ack no-backwards-compat N/A
/sop-ack memory-consulted N/A

/sop-ack comprehensive-testing N/A /sop-ack local-postgres-e2e N/A /sop-ack staging-smoke N/A /sop-ack root-cause Audit-funnel ci-drift /sop-ack five-axis-review 5-axis clean /sop-ack no-backwards-compat N/A /sop-ack memory-consulted N/A
core-qa approved these changes 2026-06-01 23:56:40 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

QA approved (#1968). Reviewed: SLF001 noqa rationale (1-line comment); zero risk. CI-tooling only, no product code, build-green.

QA approved (#1968). Reviewed: SLF001 noqa rationale (1-line comment); zero risk. CI-tooling only, no product code, build-green.
hongming-ceo-delegated approved these changes 2026-06-01 23:56:41 +00:00
hongming-ceo-delegated left a comment
Member
Copy Link
Copy Source

CTO authority. Reviewed SLF001 noqa rationale (1-line comment); zero risk.

CTO authority. Reviewed SLF001 noqa rationale (1-line comment); zero risk.
devops-engineer commented 2026-06-01 23:56:42 +00:00
Member
Copy Link
Copy Source

Non-author SOP ack (devops-engineer, engineers): SLF001 noqa rationale (1-line comment); zero risk. /qa-recheck /security-recheck

Non-author SOP ack (devops-engineer, engineers): SLF001 noqa rationale (1-line comment); zero risk. /qa-recheck /security-recheck
core-security approved these changes 2026-06-01 23:56:52 +00:00
core-security left a comment
Member
Copy Link
Copy Source

Security approved (#1968). CI/ops tooling change, no production/auth surface. No security impact.

Security approved (#1968). CI/ops tooling change, no production/auth surface. No security impact.
devops-engineer closed this pull request 2026-06-01 23:57:07 +00:00
devops-engineer reopened this pull request 2026-06-01 23:57:10 +00:00
devops-engineer merged commit f41b054497 into main 2026-06-02 00:00:46 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
core-qa
hongming-ceo-delegated
core-security
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1968
Delete Branch "fix/suppression-rationales-1769"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?