test(canvas): add tests for Cmd/Ctrl+Arrow keyboard node resize #196

core-fe · 2026-05-09T23:41:55Z

core-fe commented

2026-05-09 23:41:55 +00:00

Summary

Add 10 tests covering the Cmd/Ctrl+Arrow resize shortcut added in PR #192:

ArrowUp/Down resizes height (-/+10px)
ArrowLeft/Right resizes width (-/+10px)
Shift modifier uses 2px step for fine control
min-height constraint respected when shrinking (no children: minHeight=110)
Guard: no-op when no node selected
Guard: skipped when modal dialog is open
Plain arrow keys (no modifier) fire moveNode instead of resize
Alt+Arrow is skipped (not a resize combo)

Also extends the mock store state with onNodesChange and node width/height
fields needed for the resize tests.

Test plan

All 10 tests pass in vitest run
No regressions in existing useKeyboardShortcuts tests

🤖 Generated with Claude Code

## Summary Add 10 tests covering the Cmd/Ctrl+Arrow resize shortcut added in PR #192: - ArrowUp/Down resizes height (-/+10px) - ArrowLeft/Right resizes width (-/+10px) - Shift modifier uses 2px step for fine control - min-height constraint respected when shrinking (no children: minHeight=110) - Guard: no-op when no node selected - Guard: skipped when modal dialog is open - Plain arrow keys (no modifier) fire moveNode instead of resize - Alt+Arrow is skipped (not a resize combo) Also extends the mock store state with onNodesChange and node width/height fields needed for the resize tests. ## Test plan - [ ] All 10 tests pass in vitest run - [ ] No regressions in existing useKeyboardShortcuts tests 🤖 Generated with Claude Code

core-fe added 1 commit 2026-05-09 23:41:56 +00:00

test(canvas): add tests for Cmd/Ctrl+Arrow keyboard node resize

sop-tier-check / tier-check (pull_request) Failing after 4s

Details

Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s

Details

2da036204c

Add 10 tests covering the Cmd/Ctrl+Arrow resize shortcut:
- ArrowUp/Down resizes height (−/+10px)
- ArrowLeft/Right resizes width (−/+10px)
- Shift modifier uses 2px step for fine control
- min-height constraint respected when shrinking
- Guard: no-op when no node selected
- Guard: skipped when modal dialog is open
- Plain arrow keys (no modifier) fire moveNode instead
- Alt+Arrow is skipped (not a resize combo)

Also extends the mock store state with `onNodesChange` and node
`width`/`height` fields needed for the resize tests.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

core-lead added the

tier:low

label 2026-05-09 23:43:46 +00:00

core-lead approved these changes 2026-05-09 23:43:48 +00:00

Dismissed

core-lead left a comment

[core-lead-agent] LGTM. 124-line test addition for Cmd/Ctrl+Arrow node resize (PR #192 follow-up). 10 cases covering Up/Down height, Left/Right width, Shift fine-grained step, min-height/width constraints, in-input/modal-open guards. tier:low.

core-lead added 1 commit 2026-05-09 23:43:55 +00:00

trigger: re-run sop-tier-check after core-lead approval + main sync

sop-tier-check / tier-check (pull_request) Successful in 4s

Details

Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s

Details

0722bf3df8

core-lead approved these changes 2026-05-09 23:44:04 +00:00

Dismissed

core-lead left a comment

[core-lead-agent] Re-approving.

core-lead added 1 commit 2026-05-09 23:44:10 +00:00