molecule-ai/molecule-core
52
0
Fork 2
Code Issues 181 Pull Requests 51 Actions Packages Projects Releases Wiki Activity

Fix workspace auth forged same-origin bypass #1924

Merged
hongming merged 1 commits from fix/workspace-auth-referer-bypass into main 2026-05-26 18:20:21 +00:00
Conversation 4 Commits 1 Files Changed 3
+94 -7
hongming commented 2026-05-26 18:12:53 +00:00
Owner
Copy Link
Copy Source

Summary

  • remove forgeable Referer/Origin same-origin bypass from WorkspaceAuth
  • allow tenant Canvas through CP-verified member session cookie instead
  • add regression coverage for forged same-origin secrets list/delete and verified session access

Tests

  • cd workspace-server && go test ./internal/middleware -run 'TestWorkspaceAuth_ForgedSameOriginHeaders_Returns401|TestWorkspaceAuth_VerifiedTenantSessionCookie_AllowsCanvas|TestWorkspaceAuth_351_NoBearer_Returns401_NoDBCalls|TestVerifiedCPSession' -count=1
  • cd workspace-server && go test ./internal/middleware -count=1
## Summary - remove forgeable Referer/Origin same-origin bypass from WorkspaceAuth - allow tenant Canvas through CP-verified member session cookie instead - add regression coverage for forged same-origin secrets list/delete and verified session access ## Tests - cd workspace-server && go test ./internal/middleware -run 'TestWorkspaceAuth_ForgedSameOriginHeaders_Returns401|TestWorkspaceAuth_VerifiedTenantSessionCookie_AllowsCanvas|TestWorkspaceAuth_351_NoBearer_Returns401_NoDBCalls|TestVerifiedCPSession' -count=1 - cd workspace-server && go test ./internal/middleware -count=1
hongming added 1 commit 2026-05-26 18:12:53 +00:00
Fix workspace auth referer bypass
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 12s
Details
CI / Python Lint & Test (pull_request) Successful in 10s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 13s
Details
CI / Detect changes (pull_request) Successful in 14s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 12s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 8s
Details
E2E Chat / detect-changes (pull_request) Successful in 16s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 13s
Details
Harness Replays / detect-changes (pull_request) Successful in 10s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 10s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 9s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 7s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 37s
Details
gate-check-v3 / gate-check (pull_request) Successful in 11s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 6s
Details
sop-tier-check / tier-check (pull_request) Successful in 6s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Successful in 1m4s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 12s
Details
CI / Canvas (Next.js) (pull_request) Successful in 13s
Details
E2E Chat / E2E Chat (pull_request) Successful in 13s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 14s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Harness Replays / Harness Replays (pull_request) Successful in 4s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m14s
Details
qa-review / approved (pull_request) Refired via /qa-recheck by claude-ceo-assistant
Details
security-review / approved (pull_request) Refired via /security-recheck by claude-ceo-assistant
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m43s
Details
CI / Platform (Go) (pull_request) Successful in 4m43s
Details
CI / all-required (pull_request) Successful in 5m55s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Successful in 8m2s
Details
audit-force-merge / audit (pull_request) Successful in 4s
Details
51ca06447b
core-qa approved these changes 2026-05-26 18:14:15 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

Approved for PR #1924 auth bypass fix. Verified narrow diff and focused middleware coverage.

Approved for PR #1924 auth bypass fix. Verified narrow diff and focused middleware coverage.
core-security approved these changes 2026-05-26 18:14:15 +00:00
core-security left a comment
Member
Copy Link
Copy Source

Approved for PR #1924 auth bypass fix. Verified narrow diff and focused middleware coverage.

Approved for PR #1924 auth bypass fix. Verified narrow diff and focused middleware coverage.
core-qa approved these changes 2026-05-26 18:14:39 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

Approved for PR #1924 auth bypass fix. Verified narrow diff and focused middleware coverage.

Approved for PR #1924 auth bypass fix. Verified narrow diff and focused middleware coverage.
core-security approved these changes 2026-05-26 18:14:40 +00:00
core-security left a comment
Member
Copy Link
Copy Source

Approved for PR #1924 auth bypass fix. Verified narrow diff and focused middleware coverage.

Approved for PR #1924 auth bypass fix. Verified narrow diff and focused middleware coverage.
hongming merged commit 12319f1ffd into main 2026-05-26 18:20:21 +00:00
hongming deleted branch fix/workspace-auth-referer-bypass 2026-05-26 18:20:24 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
core-qa
core-security
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1924
Delete Branch "fix/workspace-auth-referer-bypass"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?