molecule-ai/molecule-core
51
0
Fork 2
Code Issues 163 Pull Requests 161 Actions 6 Packages Projects Releases Wiki Activity

fix(handlers): use local db import in mcp tools test #1923

Closed
hongming wants to merge 1 commits from fix/mcp-tools-test-db-import-20260526 into main
pull from: fix/mcp-tools-test-db-import-20260526
merge into: molecule-ai:main
Conversation 2 Commits 1 Files Changed 1
+1 -1
hongming commented 2026-05-26 17:32:59 +00:00
Owner
Copy Link
Copy Source

Summary

  • Replace stale GitHub monorepo db import in workspace-server/internal/handlers/mcp_tools_test.go with the current Gitea module path.
  • This unblocks the current go vet ./... failure on molecule-core@a176900e.

Evidence

Fresh heartbeat log evidence from failed push CI:

internal/handlers/mcp_tools_test.go:9:2: no required module provides package github.com/Molecule-AI/molecule-monorepo/platform/internal/db

Verification

  • go vet ./... from workspace-server: passed
  • go test ./internal/handlers -run TestExtractA2AText: passed

A broader go test ./internal/handlers -run 'TestExtractA2AText|Test.*MCP' still fails on existing MCP delegation sqlmock expectations (expected 5, got 6 arguments), separate from this import-path fix.

Safety

No branch protection, deploy, runner, secret, or infrastructure mutation.

## Summary - Replace stale GitHub monorepo db import in `workspace-server/internal/handlers/mcp_tools_test.go` with the current Gitea module path. - This unblocks the current `go vet ./...` failure on `molecule-core@a176900e`. ## Evidence Fresh heartbeat log evidence from failed push CI: ```text internal/handlers/mcp_tools_test.go:9:2: no required module provides package github.com/Molecule-AI/molecule-monorepo/platform/internal/db ``` ## Verification - `go vet ./...` from `workspace-server`: passed - `go test ./internal/handlers -run TestExtractA2AText`: passed A broader `go test ./internal/handlers -run 'TestExtractA2AText|Test.*MCP'` still fails on existing MCP delegation sqlmock expectations (`expected 5, got 6 arguments`), separate from this import-path fix. ## Safety No branch protection, deploy, runner, secret, or infrastructure mutation.
hongming added 1 commit 2026-05-26 17:33:00 +00:00
fix(handlers): use local db import in mcp tools test
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 11s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 9s
Details
CI / Detect changes (pull_request) Successful in 9s
Details
CI / Python Lint & Test (pull_request) Successful in 12s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 9s
Details
E2E Chat / detect-changes (pull_request) Successful in 9s
Details
Harness Replays / detect-changes (pull_request) Successful in 6s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 6s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 10s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 7s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 7s
Details
gate-check-v3 / gate-check (pull_request) Successful in 7s
Details
qa-review / approved (pull_request) Failing after 7s
Details
security-review / approved (pull_request) Failing after 6s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 4s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 4s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m7s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 11s
Details
Harness Replays / Harness Replays (pull_request) Successful in 15s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m7s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m30s
Details
CI / Platform (Go) (pull_request) Failing after 5m21s
Details
CI / all-required (pull_request) Failing after 10m18s
Details
audit-force-merge / audit (pull_request) Waiting to run
Details
4b153dbc74
agent-reviewer approved these changes 2026-05-26 17:41:04 +00:00
agent-reviewer left a comment
Member
Copy Link
Copy Source

Approved — local module import fix in mcp_tools_test.go, test-only and correct for the current repo path.

Approved — local module import fix in mcp_tools_test.go, test-only and correct for the current repo path.
hongming commented 2026-05-26 18:30:08 +00:00
Author
Owner
Copy Link
Copy Source

Heartbeat follow-up, 2026-05-26 11:28 PDT / 18:28 UTC:

Fresh status on this PR head (4b153dbc748e559ed3c0350df4a8894956b32147):

  • go vet ./... import failure from mcp_tools_test.go is addressed by this PR's one-line module-path fix.
  • CI is still red for CI / Platform (Go) and CI / all-required, but the current failure is now in broader internal/handlers tests, not the stale import:
    • RecordAndBroadcast: insert event error: ExecQuery: could not match actual sql: "INSERT INTO structure_events..." with expected regexp "UPDATE workspaces SET status"
    • workspace_config persist failed ... all expectations were already fulfilled
    • package failure: git.moleculesai.app/molecule-ai/molecule-core/workspace-server/internal/handlers
  • Review/SOP gates are also red: sop-checklist, security-review, qa-review.

Keeping this PR scoped to the stale import that caused the main-head go vet failure. The remaining handlers sqlmock drift looks broader than this fix and should be handled separately.

Heartbeat follow-up, 2026-05-26 11:28 PDT / 18:28 UTC: Fresh status on this PR head (`4b153dbc748e559ed3c0350df4a8894956b32147`): - `go vet ./...` import failure from `mcp_tools_test.go` is addressed by this PR's one-line module-path fix. - CI is still red for `CI / Platform (Go)` and `CI / all-required`, but the current failure is now in broader `internal/handlers` tests, not the stale import: - `RecordAndBroadcast: insert event error: ExecQuery: could not match actual sql: "INSERT INTO structure_events..." with expected regexp "UPDATE workspaces SET status"` - `workspace_config persist failed ... all expectations were already fulfilled` - package failure: `git.moleculesai.app/molecule-ai/molecule-core/workspace-server/internal/handlers` - Review/SOP gates are also red: `sop-checklist`, `security-review`, `qa-review`. Keeping this PR scoped to the stale import that caused the main-head `go vet` failure. The remaining handlers sqlmock drift looks broader than this fix and should be handled separately.
agent-pm closed this pull request 2026-05-27 03:55:45 +00:00
Some required checks failed
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 11s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 9s
Details
CI / Detect changes (pull_request) Successful in 9s
Details
CI / Python Lint & Test (pull_request) Successful in 12s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 9s
Details
E2E Chat / detect-changes (pull_request) Successful in 9s
Details
Harness Replays / detect-changes (pull_request) Successful in 6s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 6s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 10s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 7s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 7s
Details
gate-check-v3 / gate-check (pull_request) Successful in 7s
Details
qa-review / approved (pull_request) Failing after 7s
Details
security-review / approved (pull_request) Failing after 6s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 4s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 4s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m7s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 11s
Details
Harness Replays / Harness Replays (pull_request) Successful in 15s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m7s
Required
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m30s
Required
Details
CI / Platform (Go) (pull_request) Failing after 5m21s
Details
CI / all-required (pull_request) Failing after 10m18s
Required
Details
audit-force-merge / audit (pull_request) Waiting to run
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1923
Delete Branch "fix/mcp-tools-test-db-import-20260526"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?