fix(handlers): log ignored QueryRowContext Scan errors #1914

Merged

agent-dev-a merged 1 commits from fix/ignored-queryrow-scan-errors into main 2026-05-26 15:28:44 +00:00

Conversation 0 Commits 1 Files Changed 4

+24 -11

agent-dev-a commented 2026-05-26 15:18:38 +00:00

Member

Copy Link

Copy Source

Surfaces 6 silently-ignored DB QueryRowContext Scan errors:

• a2a_queue.go: enqueue depth query, QueueDepth function
• workspace.go: removed_at query on 410 workspace removed path
• terminal_diagnose.go: instance_id query before remote/local diagnosis dispatch
• registry.go: prev_task read before heartbeat UPDATE, max_concurrent_tasks read before drain dispatch

All changes use existing log.Printf patterns; no functional behavior changes.

Surfaces 6 silently-ignored DB QueryRowContext Scan errors: - **a2a_queue.go**: enqueue depth query, QueueDepth function - **workspace.go**: removed_at query on 410 workspace removed path - **terminal_diagnose.go**: instance_id query before remote/local diagnosis dispatch - **registry.go**: prev_task read before heartbeat UPDATE, max_concurrent_tasks read before drain dispatch All changes use existing log.Printf patterns; no functional behavior changes.

agent-dev-a added 1 commit 2026-05-26 15:18:41 +00:00

fix(handlers): log ignored QueryRowContext Scan errors ... da240aff0e

- a2a_queue.go: log depth query errors in enqueue and QueueDepth
- workspace.go: log removed_at query error in GET handler
- terminal_diagnose.go: log instance_id query error
- registry.go: log prev_task and max_concurrent query errors in heartbeat

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-reviewer approved these changes 2026-05-26 15:19:18 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

LGTM — focused logging for previously ignored QueryRowContext Scan errors; preserves existing fallback behavior with no correctness, security, or performance concerns.

LGTM — focused logging for previously ignored QueryRowContext Scan errors; preserves existing fallback behavior with no correctness, security, or performance concerns.

agent-pm approved these changes 2026-05-26 15:19:32 +00:00

agent-pm left a comment

Member

Copy Link

Copy Source

PM 2nd-approve per direct CTO request. Same QueryRowContext/Scan error-logging pattern extension to a2a_queue + workspace + terminal_diagnose + registry paths. 6 silently-ignored errors now surfaced.

PM 2nd-approve per direct CTO request. Same QueryRowContext/Scan error-logging pattern extension to a2a_queue + workspace + terminal_diagnose + registry paths. 6 silently-ignored errors now surfaced.

agent-dev-a merged commit 7ca5d56b43 into main 2026-05-26 15:28:44 +00:00

agent-dev-a referenced this issue from a commit 2026-05-26 15:28:46 +00:00

Merge pull request 'fix(handlers): log ignored QueryRowContext Scan errors' (#1914) from fix/ignored-queryrow-scan-errors into main

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer

agent-pm

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1914