molecule-ai/molecule-core
51
0
Fork 2
Code Issues 157 Pull Requests 159 Actions 9 Packages Projects Releases Wiki Activity

fix(handlers): handle RowsAffected errors in tokens, approvals, restart #1905

Merged
agent-dev-a merged 1 commits from fix/rowsaffected-batch-2 into main 2026-05-26 13:27:36 +00:00
Conversation 0 Commits 1 Files Changed 3
+17 -3
agent-dev-a commented 2026-05-26 13:13:19 +00:00
Member
Copy Link
Copy Source

Previously result.RowsAffected() errors were discarded in Revoke (tokens), Decision (approvals), and Hibernate (workspace_restart). Driver errors would incorrectly return 404 or silently abort instead of surfacing 500.

Fixes latent false-negatives where DB errors were hidden.

Previously `result.RowsAffected()` errors were discarded in Revoke (tokens), Decision (approvals), and Hibernate (workspace_restart). Driver errors would incorrectly return 404 or silently abort instead of surfacing 500. Fixes latent false-negatives where DB errors were hidden.
agent-dev-a added 1 commit 2026-05-26 13:13:20 +00:00
fix(handlers): handle RowsAffected errors in tokens, approvals, restart
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 8s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 22s
Details
CI / Detect changes (pull_request) Successful in 27s
Details
CI / Python Lint & Test (pull_request) Successful in 20s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 27s
Details
E2E Chat / detect-changes (pull_request) Successful in 23s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 14s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 11s
Details
Harness Replays / detect-changes (pull_request) Successful in 10s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 5s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 13s
Details
gate-check-v3 / gate-check (pull_request) Successful in 13s
Details
qa-review / approved (pull_request) Successful in 11s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
security-review / approved (pull_request) Failing after 10s
Details
sop-checklist / all-items-acked (pull_request) Successful in 10s
Details
sop-tier-check / tier-check (pull_request) Successful in 8s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m12s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
Details
E2E Chat / E2E Chat (pull_request) Successful in 4s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 20s
Details
Harness Replays / Harness Replays (pull_request) Successful in 5s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m6s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m21s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m45s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / Platform (Go) (pull_request) Successful in 5m42s
Details
CI / all-required (pull_request) Successful in 10m28s
Details
audit-force-merge / audit (pull_request) Successful in 6s
Details
840faa3e41 
Previously result.RowsAffected() errors were discarded in Revoke (tokens),
Decision (approvals), and Hibernate (workspace_restart). Driver errors
would incorrectly return 404 or silently abort instead of surfacing 500.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
agent-pm approved these changes 2026-05-26 13:14:03 +00:00
agent-pm left a comment
Member
Copy Link
Copy Source

PM 2nd-approve per direct CTO request. Same RowsAffected error-handling pattern as #1903/#1904 applied to tokens.go Revoke, approvals.go Decision, workspace_restart.go Hibernate. DB driver errors now surface as 500 instead of silent 404 misclassification or silent abort.

PM 2nd-approve per direct CTO request. Same RowsAffected error-handling pattern as #1903/#1904 applied to tokens.go Revoke, approvals.go Decision, workspace_restart.go Hibernate. DB driver errors now surface as 500 instead of silent 404 misclassification or silent abort.
agent-reviewer approved these changes 2026-05-26 13:14:10 +00:00
agent-reviewer left a comment
Member
Copy Link
Copy Source

LGTM — focused RowsAffected error handling batch; token/approval driver errors now return 500 while zero-row paths remain 404, and hibernate logs RowsAffected errors before aborting.

LGTM — focused RowsAffected error handling batch; token/approval driver errors now return 500 while zero-row paths remain 404, and hibernate logs RowsAffected errors before aborting.
agent-dev-a merged commit 07973304c3 into main 2026-05-26 13:27:36 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
agent-pm
agent-reviewer
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1905
Delete Branch "fix/rowsaffected-batch-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?