molecule-ai/molecule-core
51
0
Fork 2
Code Issues 165 Pull Requests 155 Actions 7 Packages Projects Releases Wiki Activity

fix: clear main CI deploy blockers #1856

Merged
hongming merged 1 commits from fix/main-ci-display-deploy-blockers into main 2026-05-25 20:09:54 +00:00
Conversation 5 Commits 1 Files Changed 3
+28 -20
hongming commented 2026-05-25 19:51:43 +00:00
Owner
Copy Link
Copy Source

Follow-up to unblock production deploy of #1854.\n\nChanges:\n- Update CreateWorkspaceDialog a11y expectations for the current select-based Workspace Template control.\n- Align pending uploads integration test with retained acked-row behavior used for refreshed canvas attachment previews.\n\nLocal verification:\n- npm test -- --run src/components/tests/CreateWorkspaceDialog.a11y.test.tsx src/components/tabs/tests/DisplayTab.test.tsx src/components/canvas/tests/useKeyboardShortcuts.test.tsx\n- npm run build\n- go test ./internal/pendinguploads ./internal/handlers -run 'TestGet_AckedRowWithinRetentionStillReturnsFullRow|TestAck|TestPendingUploads' -count=1\n\nNote: exact Postgres integration job requires Docker; local Docker daemon is unavailable on this Mac, so Gitea CI is the real integration proof.

Follow-up to unblock production deploy of #1854.\n\nChanges:\n- Update CreateWorkspaceDialog a11y expectations for the current select-based Workspace Template control.\n- Align pending uploads integration test with retained acked-row behavior used for refreshed canvas attachment previews.\n\nLocal verification:\n- npm test -- --run src/components/__tests__/CreateWorkspaceDialog.a11y.test.tsx src/components/tabs/__tests__/DisplayTab.test.tsx src/components/canvas/__tests__/useKeyboardShortcuts.test.tsx\n- npm run build\n- go test ./internal/pendinguploads ./internal/handlers -run 'TestGet_AckedRowWithinRetentionStillReturnsFullRow|TestAck|TestPendingUploads' -count=1\n\nNote: exact Postgres integration job requires Docker; local Docker daemon is unavailable on this Mac, so Gitea CI is the real integration proof.
hongming added 1 commit 2026-05-25 19:51:44 +00:00
fix: clear main CI deploy blockers
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 8s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 8s
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 12s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 14s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 22s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 19s
Details
E2E Chat / detect-changes (pull_request) Successful in 19s
Details
Harness Replays / detect-changes (pull_request) Successful in 14s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 8s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 9s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 13s
Details
security-review / approved (pull_request) Failing after 10s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
qa-review / approved (pull_request) Successful in 10s
Details
gate-check-v3 / gate-check (pull_request) Successful in 11s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 11s
Details
sop-tier-check / tier-check (pull_request) Successful in 14s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 21s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 13s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m14s
Details
Harness Replays / Harness Replays (pull_request) Successful in 6s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 1m55s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 3m2s
Details
CI / Platform (Go) (pull_request) Successful in 6m15s
Details
CI / Canvas (Next.js) (pull_request) Successful in 7m7s
Details
CI / all-required (pull_request) Successful in 4m13s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
6b43a5eb62
core-qa approved these changes 2026-05-25 19:52:28 +00:00
Dismissed
core-qa left a comment
Member
Copy Link
Copy Source

Approved. Local targeted tests cover the Canvas regression; Gitea will provide the real Postgres integration proof on the operator runner.

Approved. Local targeted tests cover the Canvas regression; Gitea will provide the real Postgres integration proof on the operator runner.
core-devops approved these changes 2026-05-25 19:54:02 +00:00
Dismissed
core-devops left a comment
Member
Copy Link
Copy Source

Approved as core-devops: scoped CI unblocker, tests updated to current behavior.

Approved as core-devops: scoped CI unblocker, tests updated to current behavior.
core-security approved these changes 2026-05-25 19:59:11 +00:00
Dismissed
core-security left a comment
Member
Copy Link
Copy Source

Approved from security team: test-only CI unblocker, no runtime security surface changed.

Approved from security team: test-only CI unblocker, no runtime security surface changed.
hongming-codex-laptop force-pushed fix/main-ci-display-deploy-blockers from 6b43a5eb62 to 7bde0ea64a 2026-05-25 20:00:14 +00:00 Compare
hongming-codex-laptop dismissed core-qa's review 2026-05-25 20:00:14 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

hongming-codex-laptop dismissed core-devops's review 2026-05-25 20:00:14 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

hongming-codex-laptop dismissed core-security's review 2026-05-25 20:00:14 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

core-security approved these changes 2026-05-25 20:00:43 +00:00
core-security left a comment
Member
Copy Link
Copy Source

Approved from security team after E2E update: test-only contract alignment; no runtime security surface changed.

Approved from security team after E2E update: test-only contract alignment; no runtime security surface changed.
core-qa approved these changes 2026-05-25 20:00:43 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

Approved after E2E update. The changed assertions now match retained acked-upload behavior and current Create Workspace UI.

Approved after E2E update. The changed assertions now match retained acked-upload behavior and current Create Workspace UI.
hongming merged commit 648ac4d61b into main 2026-05-25 20:09:54 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
core-security
core-qa
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1856
Delete Branch "fix/main-ci-display-deploy-blockers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?