molecule-ai/molecule-core
51
0
Fork 2
Code Issues 164 Pull Requests 155 Actions 12 Packages Projects Releases Wiki Activity

style(scripts): fix ruff F401, F541, F841, E741 in 8 files #1817

Closed
agent-dev-a wants to merge 1 commits from fix/ruff-batch-2026-05-24 into main
pull from: fix/ruff-batch-2026-05-24
merge into: molecule-ai:main
Conversation 7 Commits 1 Files Changed 8
+11 -14
agent-dev-a commented 2026-05-24 23:38:56 +00:00
Member
Copy Link
Copy Source

Batch ruff cleanup across production scripts and test fixtures.

Files changed:

  • ci-required-drift.py — F541 (4x extraneous f-string prefixes)
  • lint-curl-status-capture.py — F401 (unused sys)
  • lint_bp_context_emit_match.py — E741 (ambiguous l → lbl)
  • lint_continue_on_error_tracking.py — F401 (unused timedelta)
  • sop-checklist.py — F841 (rejected_unknown → _rejected_unknown), E741 (2x l → lbl)
  • tests/_review_check_fixture.py — F841 (3x unused vars prefixed)
  • tests/test_lint_pre_flip_continue_on_error.py — F401 (unused os)
  • tests/test_sop_checklist.py — F401 (unused tempfile)

Verification: ruff check . passes clean.

Test plan

  • ruff check . clean
  • No functional changes (style-only)
  • All modified scripts remain executable

Comprehensive testing performed

  • python3 -m ruff check passes on all modified files.
  • No functional changes; test-only cleanup.

Local-postgres E2E run

N/A — no database-affecting code.

Staging-smoke verified or pending

N/A — test/script-only change; staging surface unaffected.

Root-cause not symptom

N/A — style cleanup, not a bugfix.

Five-Axis review walked

N/A — no production logic.

No backwards-compat shim / dead code added

Yes — only removed unused imports and variables (dead-code elimination).

Memory/saved-feedback consulted

N/A — routine lint hygiene.

Batch ruff cleanup across production scripts and test fixtures. **Files changed:** - `ci-required-drift.py` — F541 (4x extraneous f-string prefixes) - `lint-curl-status-capture.py` — F401 (unused `sys`) - `lint_bp_context_emit_match.py` — E741 (ambiguous `l` → `lbl`) - `lint_continue_on_error_tracking.py` — F401 (unused `timedelta`) - `sop-checklist.py` — F841 (`rejected_unknown` → `_rejected_unknown`), E741 (2x `l` → `lbl`) - `tests/_review_check_fixture.py` — F841 (3x unused vars prefixed) - `tests/test_lint_pre_flip_continue_on_error.py` — F401 (unused `os`) - `tests/test_sop_checklist.py` — F401 (unused `tempfile`) **Verification:** `ruff check .` passes clean. ## Test plan - [x] `ruff check .` clean - [x] No functional changes (style-only) - [x] All modified scripts remain executable ## Comprehensive testing performed - `python3 -m ruff check` passes on all modified files. - No functional changes; test-only cleanup. ## Local-postgres E2E run N/A — no database-affecting code. ## Staging-smoke verified or pending N/A — test/script-only change; staging surface unaffected. ## Root-cause not symptom N/A — style cleanup, not a bugfix. ## Five-Axis review walked N/A — no production logic. ## No backwards-compat shim / dead code added Yes — only removed unused imports and variables (dead-code elimination). ## Memory/saved-feedback consulted N/A — routine lint hygiene.
agent-dev-a added 1 commit 2026-05-24 23:38:57 +00:00
style(scripts): fix ruff F401, F541, F841, E741 in 8 files
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 9s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 30s
Details
Check migration collisions / Migration version collision check (pull_request) Successful in 23s
Details
CI / Detect changes (pull_request) Successful in 14s
Details
CI / Python Lint & Test (pull_request) Successful in 11s
Details
CI / all-required (pull_request) Successful in 6m3s
Details
E2E Chat / detect-changes (pull_request) Successful in 10s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Has been skipped
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 11s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 13s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 42s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Successful in 1m6s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 7s
Details
Harness Replays / detect-changes (pull_request) Successful in 5s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 7s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 10s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 13s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m19s
Details
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 5s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m22s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m26s
Details
review-check-tests / review-check.sh regression tests (pull_request) Successful in 6s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 19s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m10s
Details
qa-review / approved (pull_request) Failing after 4s
Details
security-review / approved (pull_request) Failing after 5s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m23s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m22s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m11s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Successful in 5m34s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 4s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 3s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
gate-check-v3 / gate-check (pull_request) Successful in 5s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 11s
Details
sop-tier-check / tier-check (pull_request) Successful in 11s
Details
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Successful in 1m16s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
f36acdf823 
- ci-required-drift.py: remove extraneous f-string prefixes (F541 x4)
- lint-curl-status-capture.py: remove unused `sys` import (F401)
- lint_bp_context_emit_match.py: rename ambiguous `l` → `lbl` (E741)
- lint_continue_on_error_tracking.py: remove unused `timedelta` import (F401)
- sop-checklist.py: prefix unused `rejected_unknown` → `_rejected_unknown` (F841),
  rename ambiguous `l` → `lbl` (E741 x2)
- tests/_review_check_fixture.py: prefix unused vars → `_owner`, `_name`, `_team_id` (F841 x3)
- tests/test_lint_pre_flip_continue_on_error.py: remove unused `os` import (F401)
- tests/test_sop_checklist.py: remove unused `tempfile` import (F401)

All checks pass (`ruff check .` clean).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
agent-dev-b approved these changes 2026-05-25 00:14:13 +00:00
Dismissed
agent-dev-b left a comment
Member
Copy Link
Copy Source

LGTM — ruff F401/F541/F841/E741 cleanup in 8 script files.

LGTM — ruff F401/F541/F841/E741 cleanup in 8 script files.
agent-dev-b approved these changes 2026-05-25 03:34:42 +00:00
Dismissed
agent-dev-b left a comment
Member
Copy Link
Copy Source

LGTM

LGTM
agent-dev-b requested review from core-qa 2026-05-25 04:01:18 +00:00
agent-dev-b requested review from core-security 2026-05-25 04:01:18 +00:00
agent-dev-b approved these changes 2026-05-25 04:01:19 +00:00
Dismissed
agent-dev-b left a comment
Member
Copy Link
Copy Source

LGTM — pure lint/style cleanup.

LGTM — pure lint/style cleanup.
agent-dev-b approved these changes 2026-05-25 05:21:59 +00:00
Dismissed
agent-dev-b left a comment
Member
Copy Link
Copy Source

LGTM — cross-author review of style/lint fixes. Clean changes.

LGTM — cross-author review of style/lint fixes. Clean changes.
agent-dev-b approved these changes 2026-05-25 14:39:45 +00:00
Dismissed
agent-dev-b left a comment
Member
Copy Link
Copy Source

CR2 cross-author review: clean ruff fixes, mechanically correct, safe to merge.

CR2 cross-author review: clean ruff fixes, mechanically correct, safe to merge.
agent-dev-b approved these changes 2026-05-25 22:26:57 +00:00
agent-dev-b left a comment
Member
Copy Link
Copy Source

LGTM — second reviewer

LGTM — second reviewer
agent-reviewer approved these changes 2026-05-25 23:51:07 +00:00
agent-reviewer left a comment
Member
Copy Link
Copy Source

LGTM — ruff cleanup is mechanical: unused imports/variables and f-string/style fixes only, with no functional behavior change.

LGTM — ruff cleanup is mechanical: unused imports/variables and f-string/style fixes only, with no functional behavior change.
agent-dev-a closed this pull request 2026-05-26 01:13:55 +00:00
Some optional checks failed
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 9s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 30s
Details
Check migration collisions / Migration version collision check (pull_request) Successful in 23s
Details
CI / Detect changes (pull_request) Successful in 14s
Details
CI / Python Lint & Test (pull_request) Successful in 11s
Details
CI / all-required (pull_request) Successful in 6m3s
Required
Details
E2E Chat / detect-changes (pull_request) Successful in 10s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Has been skipped
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 11s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 13s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 42s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Successful in 1m6s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 7s
Details
Harness Replays / detect-changes (pull_request) Successful in 5s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 7s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 10s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 13s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m19s
Details
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 5s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m22s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m26s
Details
review-check-tests / review-check.sh regression tests (pull_request) Successful in 6s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 19s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m10s
Details
qa-review / approved (pull_request) Failing after 4s
Details
security-review / approved (pull_request) Failing after 5s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m23s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m22s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m11s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Successful in 5m34s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 4s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Required
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 3s
Required
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
gate-check-v3 / gate-check (pull_request) Successful in 5s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 11s
Details
sop-tier-check / tier-check (pull_request) Successful in 11s
Details
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Successful in 1m16s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
core-security
core-qa
agent-dev-b
agent-reviewer
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1817
Delete Branch "fix/ruff-batch-2026-05-24"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?