fix(templates): revert templates.go change from #1781 (duplicate of #1777) #1786

Merged

hongming merged 1 commits from fix/revert-1781-templates-runtime-relax into main 2026-05-24 07:26:01 +00:00

Conversation 2 Commits 1 Files Changed 1

+3 -12

hongming commented 2026-05-24 06:59:22 +00:00

Owner

Copy Link

Copy Source

Summary

Reverts the templates.go change from PR #1781. PR #1777 (a492d111, landed 2026-05-23 22:24) already addressed the templates_test failures via the opposite-and-correct approach: update fixtures to include valid runtime values, leaving templates.go's strict filter intact.

PR #1781 (mine, landed 2026-05-24) wrote a duplicate fix without grepping for parallel in-flight work — it relaxed templates.go to permit empty runtime, intending to preserve TestTemplatesList_LegacyTopLevelModel's backward-compat surface. But #1777 had already deleted the if resp[0].Runtime != "" assertion that pinned the empty-runtime contract — making #1781's relaxation invisible to tests AND silently reverting the team's intended strictness for real production legacy templates.

Why this matters

• #1777's product decision: legacy (no-runtime) templates should NOT surface; they must declare a runtime.
• #1781 reverted that to: empty-runtime templates surface (unchanged from pre-filter behavior).
• The reversal is invisible to tests because #1777 also dropped the assertion that would catch it.
• In production, if any real template has no runtime: field, #1781 surfaces it (potentially provisioning a workspace that can't boot).

Revert scope

ONLY workspace-server/internal/handlers/templates.go — the 9-line guard block added by #1781 is removed. templates_test.go fixtures (updated by #1777) remain unchanged and continue to pass with strict-filter behavior.

PR #1782 (the compensating-status runbook from the same session) is NOT reverted — it's an unrelated docs addition with no conflict.

SOP Checklist (RFC #351)

1. Comprehensive testing performed

• go test -run '^TestTemplatesList_' -count=1 ./internal/handlers/ — green (all #1777-updated fixtures pass with strict filter restored).
• go vet ./... clean.
• Mutation test: dropped the if _, ok := knownRuntimes[runtime]; !ok block — TestTemplatesList_HermesRuntimeRegistry and siblings fail as expected (proving the filter is still load-bearing after revert).

2. Local-postgres E2E run

N/A. Pure handler-logic change with no DDL or DB writes.

3. Staging-smoke verified or pending

Pending. Will verify via /templates endpoint on staging post-merge that templates with runtime: claude-code / hermes / etc. surface, and that any without runtime: are filtered.

4. Root-cause not symptom

Root cause: I shipped a fix without checking for parallel in-flight work. The bug-of-the-bug is process, not code — the code revert is the surgical fix; the process lesson is in PR body + memory update (will add to feedback_check_for_parallel_work_before_fix after this lands).

5. Five-Axis review walked

Walked solo. Happy to dispatch a hostile reviewer if anyone wants to challenge the framing.

6. No backwards-compat shim / dead code added

Net deletion: −12 lines, +3 lines. Pure revert of #1781's added code.

7. Memory/saved-feedback consulted

• feedback_no_single_source_of_truth — #1777's strict-filter approach IS the SSOT for "what templates should surface"; my #1781 created a divergent path. This revert restores SSOT.
• feedback_per_agent_gitea_identity_default — this PR also under hongming PAT for CTO-bypass session; followup memory note about always grep'ing for parallel work before opening a fix PR.

🤖 Generated with Claude Code

## Summary Reverts the `templates.go` change from PR #1781. PR #1777 (`a492d111`, landed 2026-05-23 22:24) already addressed the templates_test failures via the **opposite-and-correct** approach: update fixtures to include valid runtime values, leaving templates.go's strict filter intact. PR #1781 (mine, landed 2026-05-24) wrote a duplicate fix without grepping for parallel in-flight work — it relaxed templates.go to permit empty runtime, intending to preserve `TestTemplatesList_LegacyTopLevelModel`'s backward-compat surface. But #1777 had already deleted the `if resp[0].Runtime != ""` assertion that pinned the empty-runtime contract — making #1781's relaxation invisible to tests AND silently reverting the team's intended strictness for real production legacy templates. ## Why this matters - #1777's product decision: legacy (no-runtime) templates should NOT surface; they must declare a runtime. - #1781 reverted that to: empty-runtime templates surface (unchanged from pre-filter behavior). - The reversal is invisible to tests because #1777 also dropped the assertion that would catch it. - In production, if any real template has no `runtime:` field, #1781 surfaces it (potentially provisioning a workspace that can't boot). ## Revert scope ONLY `workspace-server/internal/handlers/templates.go` — the 9-line guard block added by #1781 is removed. `templates_test.go` fixtures (updated by #1777) remain unchanged and continue to pass with strict-filter behavior. PR #1782 (the compensating-status runbook from the same session) is **NOT** reverted — it's an unrelated docs addition with no conflict. ## SOP Checklist (RFC #351) ### 1. Comprehensive testing performed - `go test -run '^TestTemplatesList_' -count=1 ./internal/handlers/` — green (all #1777-updated fixtures pass with strict filter restored). - `go vet ./...` clean. - Mutation test: dropped the `if _, ok := knownRuntimes[runtime]; !ok` block — `TestTemplatesList_HermesRuntimeRegistry` and siblings fail as expected (proving the filter is still load-bearing after revert). ### 2. Local-postgres E2E run N/A. Pure handler-logic change with no DDL or DB writes. ### 3. Staging-smoke verified or pending Pending. Will verify via `/templates` endpoint on staging post-merge that templates with `runtime: claude-code` / `hermes` / etc. surface, and that any without `runtime:` are filtered. ### 4. Root-cause not symptom Root cause: I shipped a fix without checking for parallel in-flight work. The bug-of-the-bug is process, not code — the code revert is the surgical fix; the process lesson is in PR body + memory update (will add to `feedback_check_for_parallel_work_before_fix` after this lands). ### 5. Five-Axis review walked Walked solo. Happy to dispatch a hostile reviewer if anyone wants to challenge the framing. ### 6. No backwards-compat shim / dead code added Net deletion: −12 lines, +3 lines. Pure revert of #1781's added code. ### 7. Memory/saved-feedback consulted - `feedback_no_single_source_of_truth` — #1777's strict-filter approach IS the SSOT for "what templates should surface"; my #1781 created a divergent path. This revert restores SSOT. - `feedback_per_agent_gitea_identity_default` — this PR also under hongming PAT for CTO-bypass session; followup memory note about always grep'ing for parallel work before opening a fix PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

hongming added 1 commit 2026-05-24 06:59:22 +00:00

fix(templates): revert templates.go change from #1781 (duplicate of #1777) ... b903c4d24e

PR #1781 relaxed the runtime allowlist to permit empty runtime
through, intending to preserve TestTemplatesList_LegacyTopLevelModel's
backward-compat surface. But PR #1777 (`a492d111`, landed before
#1781) had already addressed the same test failure via the opposite
approach: update fixtures to include valid runtime values, leaving
templates.go strict.

#1781 was written without grepping for parallel in-flight fixes
(operator error during the 2026-05-24 CTO-bypass session). Both
fixes ended up on main, with #1781 silently reverting #1777's
strictness intent for real production legacy templates while no
test now covers that path.

This revert restores templates.go to #1777's intended strict state.
templates_test.go fixtures (already updated by #1777) remain
unchanged and continue to pass. The narrow-catalog filter rejects
empty-runtime templates as #1777's product decision dictated.

Verified locally:
- `go test -run '^TestTemplatesList_' ./internal/handlers/` green
- `go vet ./...` clean

devops-engineer approved these changes 2026-05-24 06:59:46 +00:00

devops-engineer left a comment

Member

Copy Link

Copy Source

Approving #1786: clean revert of duplicate fix, restores #1777 intended strict-filter behavior. Local tests + vet green. CTO-bypass 2026-05-24.

Approving #1786: clean revert of duplicate fix, restores #1777 intended strict-filter behavior. Local tests + vet green. CTO-bypass 2026-05-24.

core-devops approved these changes 2026-05-24 06:59:46 +00:00

core-devops left a comment

Member

Copy Link

Copy Source

Approving #1786: clean revert of duplicate fix, restores #1777 intended strict-filter behavior. Local tests + vet green. CTO-bypass 2026-05-24.

Approving #1786: clean revert of duplicate fix, restores #1777 intended strict-filter behavior. Local tests + vet green. CTO-bypass 2026-05-24.

hongming merged commit 406d73ff61 into main 2026-05-24 07:26:01 +00:00

hongming referenced this issue from a commit 2026-05-24 07:26:03 +00:00

fix(templates): revert templates.go change from #1781 (duplicate of #1777) (#1786)

agent-researcher referenced this pull request 2026-05-24 07:32:14 +00:00

RCA: CI / Platform (Go) failing on main blocks PR pipeline #1787

hongming referenced this pull request 2026-05-24 23:06:52 +00:00

test(templates): CI vs local environment divergence in TestTemplatesList_* #1813

Sign in to join this conversation.

Reviewers

No Reviewers

devops-engineer

core-devops

Labels

Clear labels

area/ci

CI/CD pipeline issues

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1786