molecule-ai/molecule-core
51
0
Fork 2
Code Issues 183 Pull Requests 50 Actions 6 Packages Projects Releases Wiki Activity

fix(channels): deterministic discord token-leak test (RCA #1763 Finding 2) #1771

Closed
agent-dev-a wants to merge 1 commits from fix-1763-webhook-token-redaction-skip into main
pull from: fix-1763-webhook-token-redaction-skip
merge into: molecule-ai:main
Conversation 0 Commits 1 Files Changed 2
+33 -10
agent-dev-a commented 2026-05-24 04:00:46 +00:00
Member
Copy Link
Copy Source

Summary

Replaces the flaky network-dependent TestDiscordAdapter_SendMessage_ErrorDoesNotLeakToken with a deterministic fake-transport test. Fixes RCA #1763 Finding 2.

Changes

  • Add optional httpClient field to DiscordAdapter (test-only injection point)
  • Use injected client in SendMessage when non-nil; fall back to default timeout client otherwise
  • Replace t.Skip test with fake http.RoundTripper that returns a URL-bearing error; assert adapter still redacts the token

Scope

  • ONE finding only (Finding 2 — webhook token redaction skip)
  • Single PR
  • molecule-core only

Test plan

  • go test ./workspace-server/internal/channels passes
  • All TestDiscordAdapter_* tests pass
  • No production behavior change when httpClient is nil

Fixes #1763

## Summary Replaces the flaky network-dependent `TestDiscordAdapter_SendMessage_ErrorDoesNotLeakToken` with a deterministic fake-transport test. Fixes RCA #1763 Finding 2. ## Changes - Add optional `httpClient` field to `DiscordAdapter` (test-only injection point) - Use injected client in `SendMessage` when non-nil; fall back to default timeout client otherwise - Replace `t.Skip` test with fake `http.RoundTripper` that returns a URL-bearing error; assert adapter still redacts the token ## Scope - ONE finding only (Finding 2 — webhook token redaction skip) - Single PR - molecule-core only ## Test plan - [x] `go test ./workspace-server/internal/channels` passes - [x] All `TestDiscordAdapter_*` tests pass - [x] No production behavior change when `httpClient` is nil Fixes #1763
agent-dev-a added 1 commit 2026-05-24 04:00:47 +00:00
fix(channels): make discord token-leak test deterministic (RCA #1763 Finding 2)
Block internal-flavored paths / Block forbidden paths (pull_request) Waiting to run
Details
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Waiting to run
Details
CI / all-required (pull_request) Waiting to run
Details
CI / Detect changes (pull_request) Waiting to run
Details
E2E API Smoke Test / detect-changes (pull_request) Waiting to run
Details
E2E Chat / detect-changes (pull_request) Waiting to run
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Waiting to run
Details
Handlers Postgres Integration / detect-changes (pull_request) Waiting to run
Details
Harness Replays / detect-changes (pull_request) Waiting to run
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Waiting to run
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Waiting to run
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Waiting to run
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Waiting to run
Details
gate-check-v3 / gate-check (pull_request) Waiting to run
Details
qa-review / approved (pull_request) Waiting to run
Details
security-review / approved (pull_request) Waiting to run
Details
sop-checklist / all-items-acked (pull_request) Waiting to run
Details
sop-checklist / review-refire (pull_request) Waiting to run
Details
sop-tier-check / tier-check (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 8s
Details
audit-force-merge / audit (pull_request) Waiting to run
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Has been cancelled
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Has been cancelled
Details
CI / Platform (Go) (pull_request) Has been cancelled
Details
CI / Canvas (Next.js) (pull_request) Has been cancelled
Details
CI / Shellcheck (E2E scripts) (pull_request) Has been cancelled
Details
CI / Canvas Deploy Reminder (pull_request) Has been cancelled
Details
E2E Chat / E2E Chat (pull_request) Has been cancelled
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Has been cancelled
Details
Harness Replays / Harness Replays (pull_request) Has been cancelled
Details
54b6ce0d57 
TestDiscordAdapter_SendMessage_ErrorDoesNotLeakToken previously relied
on a real network dial to an unroutable address and t.Skip'd when the
request unexpectedly succeeded.  This made the test flaky and caused
silent loss of security-coverage in environments where the dial did not
fail.

- Add optional httpClient field to DiscordAdapter so tests can inject a
  fake http.RoundTripper.
- Replace the skip-based test with a deterministic fake-transport that
  returns an error containing the webhook URL, then assert the adapter
  still redacts the token.
- Zero behavioral change when httpClient is nil (production path).

Fixes RCA #1763 Finding 2 — webhook token redaction skip.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
agent-dev-a closed this pull request 2026-05-24 04:03:17 +00:00
Some checks are pending
Block internal-flavored paths / Block forbidden paths (pull_request) Waiting to run
Details
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Waiting to run
Details
CI / all-required (pull_request) Waiting to run
Required
Details
CI / Detect changes (pull_request) Waiting to run
Details
E2E API Smoke Test / detect-changes (pull_request) Waiting to run
Details
E2E Chat / detect-changes (pull_request) Waiting to run
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Waiting to run
Details
Handlers Postgres Integration / detect-changes (pull_request) Waiting to run
Details
Harness Replays / detect-changes (pull_request) Waiting to run
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Waiting to run
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Waiting to run
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Waiting to run
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Waiting to run
Details
gate-check-v3 / gate-check (pull_request) Waiting to run
Details
qa-review / approved (pull_request) Waiting to run
Details
security-review / approved (pull_request) Waiting to run
Details
sop-checklist / all-items-acked (pull_request) Waiting to run
Details
sop-checklist / review-refire (pull_request) Waiting to run
Details
sop-tier-check / tier-check (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 8s
Details
audit-force-merge / audit (pull_request) Waiting to run
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Has been cancelled
Required
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Has been cancelled
Required
Details
CI / Platform (Go) (pull_request) Has been cancelled
Details
CI / Canvas (Next.js) (pull_request) Has been cancelled
Details
CI / Shellcheck (E2E scripts) (pull_request) Has been cancelled
Details
CI / Canvas Deploy Reminder (pull_request) Has been cancelled
Details
E2E Chat / E2E Chat (pull_request) Has been cancelled
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Has been cancelled
Details
Harness Replays / Harness Replays (pull_request) Has been cancelled
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1771
Delete Branch "fix-1763-webhook-token-redaction-skip"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?