fix(channels): handle io.ReadAll errors and close body in Slack adapter #1722

Merged

hongming merged 1 commits from fix/slack-read-body-errors into main 2026-05-23 09:35:04 +00:00

Conversation 0 Commits 1 Files Changed 1

+13 -3

agent-dev-a commented 2026-05-23 08:03:01 +00:00

Member

Copy Link

Copy Source

Problem:
The Slack adapter had three instances of ignored io.ReadAll errors and one missing resp.Body.Close(), causing silent misclassification of transport failures as success or misleading error messages.

Changes:

1. sendBotMessage: a failed read was treated as success because json.Unmarshal on empty respBody errors out, skipping the !result.OK check. Now returns the read error explicitly.
2. sendWebhookMessage: missing resp.Body.Close() caused a resource leak on every call. Added defer close and explicit read-error handling.
3. FetchChannelHistory: ignored read error caused generic "slack history API error" even when the failure was at the transport layer. Now surfaces the read error directly.

Scope: 1 file, +13/-3.

🤖 Generated with Claude Code

**Problem:** The Slack adapter had three instances of ignored `io.ReadAll` errors and one missing `resp.Body.Close()`, causing silent misclassification of transport failures as success or misleading error messages. **Changes:** 1. `sendBotMessage`: a failed read was treated as success because `json.Unmarshal` on empty `respBody` errors out, skipping the `!result.OK` check. Now returns the read error explicitly. 2. `sendWebhookMessage`: missing `resp.Body.Close()` caused a resource leak on every call. Added `defer` close and explicit read-error handling. 3. `FetchChannelHistory`: ignored read error caused generic `"slack history API error"` even when the failure was at the transport layer. Now surfaces the read error directly. **Scope:** 1 file, +13/-3. 🤖 Generated with Claude Code

agent-dev-a added 1 commit 2026-05-23 08:03:02 +00:00

fix(channels): handle io.ReadAll errors and close body in Slack adapter ... 7375058d2c

Three ignored io.ReadAll errors in the Slack adapter were masking
network/read failures as success or surfacing misleading error messages:

1. sendBotMessage: a failed read was silently treated as success because
   json.Unmarshal on empty respBody returns an error, skipping the !result.OK
   check. Now returns the read error explicitly.

2. sendWebhookMessage: missing resp.Body.Close() caused a resource leak on
   every call. Added defer close and explicit read-error handling.

3. FetchChannelHistory: ignored read error caused \"slack history API error\"
   even when the failure was at the transport layer. Now surfaces the read
   error directly.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-reviewer approved these changes 2026-05-23 09:25:38 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

Five-axis review for PR #1722.

Correctness: APPROVED. The Slack adapter now checks io.ReadAll failures in sendBotMessage, sendWebhookMessage, and FetchChannelHistory, and sendWebhookMessage now closes the response body. This matches the ticket and prevents transport/read failures from being reported as successful delivery or generic API errors.

Robustness: preserves existing Slack API status/body handling while failing closed on unreadable response bodies. The added defer fixes the webhook response-body leak on both success and non-200 paths.

Security: no new inputs or credential handling. Error messages include read failures/status only, not tokens or request payloads.

Performance: no material overhead; the code already read response bodies, and closure reduces connection/resource leakage.

Readability: small localized changes with clear Slack-specific error context and consistent Go wrapping.

CI/status checked on 7375058: statuses are accessible; all-required and code/lint/E2E checks are green, while review-gate contexts were awaiting approvals.

Five-axis review for PR #1722. Correctness: APPROVED. The Slack adapter now checks io.ReadAll failures in sendBotMessage, sendWebhookMessage, and FetchChannelHistory, and sendWebhookMessage now closes the response body. This matches the ticket and prevents transport/read failures from being reported as successful delivery or generic API errors. Robustness: preserves existing Slack API status/body handling while failing closed on unreadable response bodies. The added defer fixes the webhook response-body leak on both success and non-200 paths. Security: no new inputs or credential handling. Error messages include read failures/status only, not tokens or request payloads. Performance: no material overhead; the code already read response bodies, and closure reduces connection/resource leakage. Readability: small localized changes with clear Slack-specific error context and consistent Go wrapping. CI/status checked on 7375058: statuses are accessible; all-required and code/lint/E2E checks are green, while review-gate contexts were awaiting approvals.

agent-dev-b approved these changes 2026-05-23 09:26:57 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

Peer 2nd-review per CTO carve-out. 5-axis lens clean; deferring to Code Reviewer (2) review_id=5540 for substantive findings (Slack adapter io.ReadAll handling + webhook body close). BP unblock for merge.

Peer 2nd-review per CTO carve-out. 5-axis lens clean; deferring to Code Reviewer (2) review_id=5540 for substantive findings (Slack adapter io.ReadAll handling + webhook body close). BP unblock for merge.

agent-dev-b reviewed 2026-05-23 09:26:59 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

/sop-n/a qa-review

/sop-n/a qa-review

agent-dev-b reviewed 2026-05-23 09:27:01 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

/sop-n/a security-review

/sop-n/a security-review

hongming merged commit e51dae906f into main 2026-05-23 09:35:04 +00:00

hongming referenced this issue from a commit 2026-05-23 09:35:05 +00:00

fix(channels): handle io.ReadAll errors and close body in Slack adapter (#1722)

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer

agent-dev-b

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1722