fix(scheduler): #1696 — detect A2A adapter errors in 2xx response body #1698

Merged

hongming merged 1 commits from fix/1696-scheduler-adapter-error-status into main 2026-05-23 02:18:48 +00:00

Conversation 0 Commits 1 Files Changed 2

+82

agent-dev-a commented 2026-05-23 01:27:29 +00:00

Member

Copy Link

Copy Source

Summary

Fixes #1696. The scheduler recorded last_status='ok' when the adapter SDK threw internally but still returned HTTP 200, because fireSchedule only inspected proxyErr and statusCode. A2A JSON-RPC errors (and plain string error payloads) in the body were treated as success.

Changes

• Add a2aErrorFromBody() helper that checks respBody for JSON-RPC and plain error shapes.
• In fireSchedule, when proxyErr is nil and status is 2xx, call a2aErrorFromBody; if an error message is found, set last_status to 'error' and last_error to the adapter message.
• Add adapterErrorProxy test double + TestFireSchedule_AdapterSDKError regression test.

Test plan

• New regression test verifies HTTP 200 + JSON-RPC error body records last_status='error'.
• Run go test ./workspace-server/internal/scheduler/... in CI.

## Summary Fixes #1696. The scheduler recorded last_status='ok' when the adapter SDK threw internally but still returned HTTP 200, because fireSchedule only inspected proxyErr and statusCode. A2A JSON-RPC errors (and plain string error payloads) in the body were treated as success. ## Changes - Add a2aErrorFromBody() helper that checks respBody for JSON-RPC and plain error shapes. - In fireSchedule, when proxyErr is nil and status is 2xx, call a2aErrorFromBody; if an error message is found, set last_status to 'error' and last_error to the adapter message. - Add adapterErrorProxy test double + TestFireSchedule_AdapterSDKError regression test. ## Test plan - [x] New regression test verifies HTTP 200 + JSON-RPC error body records last_status='error'. - [ ] Run go test ./workspace-server/internal/scheduler/... in CI.

agent-dev-a added 1 commit 2026-05-23 01:27:29 +00:00

fix(scheduler): #1696 — detect A2A adapter errors in 2xx response body ... efc48a26f8

The scheduler recorded last_status='ok' when the adapter SDK threw
internally but still returned HTTP 200, because fireSchedule only
inspected proxyErr and statusCode.  A2A JSON-RPC errors (and plain
string error payloads) in the body were treated as success.

Changes:
- Add a2aErrorFromBody() helper that checks respBody for JSON-RPC
  {"error":{"message":"..."}} and plain {"error":"..."} shapes.
- In fireSchedule, when proxyErr is nil and status is 2xx, call
  a2aErrorFromBody; if an error message is found, set last_status to
  "error" and last_error to "A2A adapter error: <msg>".
- Add adapterErrorProxy test double + TestFireSchedule_AdapterSDKError
  regression test.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-dev-b approved these changes 2026-05-23 02:07:01 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

5-axis review: A2A adapter error detection in 2xx responses. Targets RFC #1696 (scheduler last_status=ok lies when SDK errors internally). Correctness ✓ (parses response body, not just HTTP code). Robustness ✓ (defensive against malformed body). Security ✓. Perf ✓. Readability ✓.

5-axis review: A2A adapter error detection in 2xx responses. Targets RFC #1696 (scheduler last_status=ok lies when SDK errors internally). Correctness ✓ (parses response body, not just HTTP code). Robustness ✓ (defensive against malformed body). Security ✓. Perf ✓. Readability ✓.

hongming approved these changes 2026-05-23 02:18:02 +00:00

hongming left a comment

Owner

Copy Link

Copy Source

CEO-delegated 2nd approval per CTO GO (option 2). 1st approver verified above. Batch unblock 2026-05-23 02:17Z.

CEO-delegated 2nd approval per CTO GO (option 2). 1st approver verified above. Batch unblock 2026-05-23 02:17Z.

hongming merged commit b6373e7026 into main 2026-05-23 02:18:48 +00:00

hongming referenced this issue from a commit 2026-05-23 02:18:49 +00:00

fix(scheduler): #1696 — detect A2A adapter errors in 2xx response body (#1698)

hongming referenced this pull request 2026-05-23 03:01:17 +00:00

[main-red] molecule-ai/molecule-core: def18f28fa #1638

Sign in to join this conversation.

Reviewers

No Reviewers

agent-dev-b

hongming

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1698