molecule-ai/molecule-core
51
0
Fork 2
Code Issues 163 Pull Requests 161 Actions 6 Packages Projects Releases Wiki Activity

fix(scheduler): #1692 — mount ScheduleHandler HTTP routes #1694

Closed
hongming wants to merge 1 commits from fix/1692-mount-schedule-routes into main
pull from: fix/1692-mount-schedule-routes
merge into: molecule-ai:main
Conversation 1 Commits 1 Files Changed 1
+18
hongming commented 2026-05-23 00:18:06 +00:00
Owner
Copy Link
Copy Source

Summary

  • ScheduleHandler + Temporal cron worker were fully implemented but the HTTP routes were never mounted in router.go → every call to /workspaces/:id/schedules returned 404
  • Canvas Schedule tab silently failed; agent MCP set_schedule returned 404; PM had no platform-side scheduler and was relying on the CTO orchestrator's /loop tick as its only heartbeat
  • 18-line patch: wire 7 endpoints under existing wsAuth group (WorkspaceAuth middleware enforces per-workspace bearer scope, matching the IDOR-fix shape inside the handler)

Routes exposed

GET    /workspaces/:id/schedules
POST   /workspaces/:id/schedules
PUT    /workspaces/:id/schedules/:scheduleId
DELETE /workspaces/:id/schedules/:scheduleId
POST   /workspaces/:id/schedules/:scheduleId/run
GET    /workspaces/:id/schedules/:scheduleId/history
GET    /workspaces/:id/schedules/health

Test plan

  • go build ./... in workspace-server compiles clean
  • Post-merge: POST /workspaces/<pm-id>/schedules with cron + autonomous-tick prompt → verify row in workspace_schedules + first fire within window
  • Post-merge: Canvas Schedule tab loads existing schedules

Fixes #1692.

## Summary - `ScheduleHandler` + Temporal cron worker were fully implemented but the HTTP routes were never mounted in `router.go` → every call to `/workspaces/:id/schedules` returned 404 - Canvas Schedule tab silently failed; agent MCP `set_schedule` returned 404; PM had no platform-side scheduler and was relying on the CTO orchestrator's /loop tick as its only heartbeat - 18-line patch: wire 7 endpoints under existing `wsAuth` group (WorkspaceAuth middleware enforces per-workspace bearer scope, matching the IDOR-fix shape inside the handler) ## Routes exposed ``` GET /workspaces/:id/schedules POST /workspaces/:id/schedules PUT /workspaces/:id/schedules/:scheduleId DELETE /workspaces/:id/schedules/:scheduleId POST /workspaces/:id/schedules/:scheduleId/run GET /workspaces/:id/schedules/:scheduleId/history GET /workspaces/:id/schedules/health ``` ## Test plan - [x] `go build ./...` in workspace-server compiles clean - [ ] Post-merge: `POST /workspaces/<pm-id>/schedules` with cron + autonomous-tick prompt → verify row in `workspace_schedules` + first fire within window - [ ] Post-merge: Canvas Schedule tab loads existing schedules Fixes #1692.
hongming added 1 commit 2026-05-23 00:18:07 +00:00
fix(scheduler): #1692 — mount ScheduleHandler HTTP routes
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Python Lint & Test (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 9s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 6s
Details
E2E Chat / detect-changes (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 6s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Details
Harness Replays / detect-changes (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 6s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
gate-check-v3 / gate-check (pull_request) Successful in 4s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
qa-review / approved (pull_request) Failing after 12s
Details
security-review / approved (pull_request) Failing after 11s
Details
sop-checklist / all-items-acked (pull_request) Successful in 10s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
sop-tier-check / tier-check (pull_request) Successful in 10s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 9s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m10s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 2m5s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
CI / Platform (Go) (pull_request) Successful in 4m45s
Details
CI / all-required (pull_request) Successful in 5m28s
Details
2e93df5d69 
The handler + Temporal cron worker are implemented in
workspace-server/internal/handlers/schedules.go +
platform/internal/scheduler, but the HTTP routes were never mounted.
Every call to /workspaces/:id/schedules returned 404, so:

- Canvas "Schedule" tab silently failed to load/save schedules
- Agent MCP set_schedule tool returned 404 → agents had no way to
  self-schedule wake-ups (PM in particular had no platform-side
  scheduler and was relying on the CTO orchestrator's /loop tick as
  its only heartbeat)

Routes are mounted under WorkspaceAuth so the per-workspace bearer
token scopes ownership, matching the IDOR-fix shape in
handlers/schedules.go (Update/Delete/RunNow/History rebind to
workspaceID before touching the row).

Endpoints exposed:
  GET    /workspaces/:id/schedules
  POST   /workspaces/:id/schedules
  PUT    /workspaces/:id/schedules/:scheduleId
  DELETE /workspaces/:id/schedules/:scheduleId
  POST   /workspaces/:id/schedules/:scheduleId/run
  GET    /workspaces/:id/schedules/:scheduleId/history
  GET    /workspaces/:id/schedules/health

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hongming closed this pull request 2026-05-23 00:20:55 +00:00
hongming commented 2026-05-23 00:20:56 +00:00
Author
Owner
Copy Link
Copy Source

Closing — bad diagnosis on my part. Schedule routes are already mounted in router.go (lines 374-385 of origin/main: wsAuth.GET/POST/PATCH/DELETE /schedules* via schedh := handlers.NewScheduleHandler()). This PR would have duplicate-registered the same paths and Gin would panic at startup.

Root cause of PM not having a scheduler is somewhere else — likely (a) the agent runtime SDK has no set_schedule MCP tool wired to call these endpoints, or (b) the Canvas Schedule tab targets a different URL/auth path. Need to re-diagnose before opening another PR. Issue #1692 also incorrect and will be closed.

Closing — bad diagnosis on my part. Schedule routes are already mounted in `router.go` (lines 374-385 of origin/main: `wsAuth.GET/POST/PATCH/DELETE /schedules*` via `schedh := handlers.NewScheduleHandler()`). This PR would have duplicate-registered the same paths and Gin would panic at startup. Root cause of PM not having a scheduler is somewhere else — likely (a) the agent runtime SDK has no `set_schedule` MCP tool wired to call these endpoints, or (b) the Canvas Schedule tab targets a different URL/auth path. Need to re-diagnose before opening another PR. Issue #1692 also incorrect and will be closed.
Some required checks failed
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Python Lint & Test (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 9s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 6s
Details
E2E Chat / detect-changes (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 6s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Details
Harness Replays / detect-changes (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 6s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
gate-check-v3 / gate-check (pull_request) Successful in 4s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
qa-review / approved (pull_request) Failing after 12s
Details
security-review / approved (pull_request) Failing after 11s
Details
sop-checklist / all-items-acked (pull_request) Successful in 10s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
sop-tier-check / tier-check (pull_request) Successful in 10s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 9s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Required
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m10s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 2m5s
Required
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
CI / Platform (Go) (pull_request) Successful in 4m45s
Details
CI / all-required (pull_request) Successful in 5m28s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1694
Delete Branch "fix/1692-mount-schedule-routes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?