molecule-ai/molecule-core
51
0
Fork 2
Code Issues 158 Pull Requests 160 Actions 14 Packages Projects Releases Wiki Activity

fix(e2e): clarify EIC diagnose SG guidance #1664

Merged
hongming merged 1 commits from fix/e2e-eic-diagnostic-sg into main 2026-05-22 02:47:29 +00:00
Conversation 9 Commits 1 Files Changed 1
+2 -2
hongming commented 2026-05-22 02:38:46 +00:00
Owner
Copy Link
Copy Source

What

  • Remove the deleted hard-coded EIC endpoint SG from the staging E2E terminal diagnose failure message.
  • Point operators at the canonical Railway env MOLECULE_EIC_ENDPOINT_SG_ID.

Why

The live staging EIC endpoint SG is resolved from AWS/Railway config. A stale hard-coded SG in the failure text sent investigation toward a deleted security group even after CP was correctly wiring the live endpoint SG.

SOP

  • Comprehensive testing performed: bash syntax, shellcheck, diff check, and live staging EIC probe.
  • Local-postgres E2E run: N/A, E2E shell diagnostic text only; no Postgres behavior changed.
  • Staging-smoke verified or pending: manual staging smoke reached terminal-reachable and Files API EIC write HTTP 200 after Railway env fix; later A2A 503 was expected because the manual probe intentionally omitted LLM credentials.
  • Root-cause not symptom: Railway staging had only the legacy EIC_ENDPOINT_SG_ID name while CP uses canonical MOLECULE_EIC_ENDPOINT_SG_ID; the repo diagnostic also hard-coded a deleted SG.
  • Five-Axis review walked: correctness/readability/architecture/security/performance checked; change is diagnostic text only.
  • No backwards-compat shim / dead code added: no shim, no runtime behavior change.
  • Memory/saved-feedback consulted: Gitea status enum and SOP/review gate patterns from saved guidance were applied.

Verification

  • bash -n tests/e2e/test_staging_full_saas.sh
  • shellcheck -x tests/e2e/test_staging_full_saas.sh
  • git diff --check
  • Manual staging smoke reached terminal-reachable and Files API EIC write HTTP 200; teardown verified no EC2 leak.
## What - Remove the deleted hard-coded EIC endpoint SG from the staging E2E terminal diagnose failure message. - Point operators at the canonical Railway env `MOLECULE_EIC_ENDPOINT_SG_ID`. ## Why The live staging EIC endpoint SG is resolved from AWS/Railway config. A stale hard-coded SG in the failure text sent investigation toward a deleted security group even after CP was correctly wiring the live endpoint SG. ## SOP - [x] Comprehensive testing performed: bash syntax, shellcheck, diff check, and live staging EIC probe. - [x] Local-postgres E2E run: N/A, E2E shell diagnostic text only; no Postgres behavior changed. - [x] Staging-smoke verified or pending: manual staging smoke reached `terminal-reachable` and Files API EIC write HTTP 200 after Railway env fix; later A2A 503 was expected because the manual probe intentionally omitted LLM credentials. - [x] Root-cause not symptom: Railway staging had only the legacy `EIC_ENDPOINT_SG_ID` name while CP uses canonical `MOLECULE_EIC_ENDPOINT_SG_ID`; the repo diagnostic also hard-coded a deleted SG. - [x] Five-Axis review walked: correctness/readability/architecture/security/performance checked; change is diagnostic text only. - [x] No backwards-compat shim / dead code added: no shim, no runtime behavior change. - [x] Memory/saved-feedback consulted: Gitea status enum and SOP/review gate patterns from saved guidance were applied. ## Verification - `bash -n tests/e2e/test_staging_full_saas.sh` - `shellcheck -x tests/e2e/test_staging_full_saas.sh` - `git diff --check` - Manual staging smoke reached `terminal-reachable` and Files API EIC write HTTP 200; teardown verified no EC2 leak.
hongming added 1 commit 2026-05-22 02:38:46 +00:00
Clarify EIC diagnose SG guidance
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Has been skipped
Details
E2E Chat / detect-changes (pull_request) Successful in 7s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 7s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 7s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 5s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 7s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 6s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 9s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 34s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 3s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 4s
Details
CI / all-required (pull_request) Successful in 51s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m8s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m2s
Details
qa-review / approved (pull_request) Refired via /qa-recheck by unknown
Details
security-review / approved (pull_request) Refired via /security-recheck by unknown
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
gate-check-v3 / gate-check (pull_request) Successful in 4s
Details
sop-tier-check / tier-check (pull_request) Successful in 4s
Details
sop-checklist / all-items-acked (pull_request) acked: 7/7
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
audit-force-merge / audit (pull_request) Successful in 6s
Details
086b479dca
core-qa approved these changes 2026-05-22 02:44:32 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

Approved for CI/E2E diagnostic cleanup. Scope is a stale failure message only; live EIC path was verified separately.

Approved for CI/E2E diagnostic cleanup. Scope is a stale failure message only; live EIC path was verified separately.
core-security approved these changes 2026-05-22 02:44:33 +00:00
core-security left a comment
Member
Copy Link
Copy Source

Approved for CI/E2E diagnostic cleanup. Scope is a stale failure message only; live EIC path was verified separately.

Approved for CI/E2E diagnostic cleanup. Scope is a stale failure message only; live EIC path was verified separately.
hongming commented 2026-05-22 02:44:44 +00:00
Author
Owner
Copy Link
Copy Source

/sop-ack 1 2 3 4 5 6 7

/sop-ack 1 2 3 4 5 6 7
core-qa commented 2026-05-22 02:46:05 +00:00
Member
Copy Link
Copy Source

/sop-ack comprehensive-testing local-postgres-e2e staging-smoke root-cause five-axis-review no-backwards-compat memory-consulted

/sop-ack comprehensive-testing local-postgres-e2e staging-smoke root-cause five-axis-review no-backwards-compat memory-consulted
core-security commented 2026-05-22 02:46:06 +00:00
Member
Copy Link
Copy Source

/sop-ack comprehensive-testing local-postgres-e2e staging-smoke root-cause five-axis-review no-backwards-compat memory-consulted

/sop-ack comprehensive-testing local-postgres-e2e staging-smoke root-cause five-axis-review no-backwards-compat memory-consulted
core-devops commented 2026-05-22 02:46:33 +00:00
Member
Copy Link
Copy Source

/sop-ack local-postgres-e2e staging-smoke root-cause five-axis-review no-backwards-compat memory-consulted

/sop-ack local-postgres-e2e staging-smoke root-cause five-axis-review no-backwards-compat memory-consulted
core-devops commented 2026-05-22 02:46:52 +00:00
Member
Copy Link
Copy Source

/sop-ack 3 4 5 6 7

/sop-ack 3 4 5 6 7
core-devops commented 2026-05-22 02:47:04 +00:00
Member
Copy Link
Copy Source

/sop-ack 4

/sop-ack 4
core-devops commented 2026-05-22 02:47:05 +00:00
Member
Copy Link
Copy Source

/sop-ack 5

/sop-ack 5
core-devops commented 2026-05-22 02:47:05 +00:00
Member
Copy Link
Copy Source

/sop-ack 6

/sop-ack 6
core-devops commented 2026-05-22 02:47:06 +00:00
Member
Copy Link
Copy Source

/sop-ack 7

/sop-ack 7
hongming merged commit 992ccfbd5e into main 2026-05-22 02:47:29 +00:00
hongming deleted branch fix/e2e-eic-diagnostic-sg 2026-05-22 02:47:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
core-qa
core-security
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1664
Delete Branch "fix/e2e-eic-diagnostic-sg"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?