molecule-ai/molecule-core
51
0
Fork 2
Code Issues 157 Pull Requests 159 Actions 23 Packages Projects Releases Wiki Activity

fix: use Gitea for T4 egress contract #1658

Merged
hongming merged 3 commits from fix/t4-gitea-egress-ssot into main 2026-05-22 01:10:09 +00:00
Conversation 5 Commits 3 Files Changed 5
+117 -45
hongming commented 2026-05-22 00:03:50 +00:00
Owner
Copy Link
Copy Source

Replace GitHub/Google default T4 egress targets with the Molecule-owned Gitea middleman endpoint and add regression coverage so the generated SSOT contract cannot drift back to external mirror/API dependencies.

SOP-Checklist

Comprehensive testing performed

  • cd workspace-server && go test ./internal/provisioner passed locally.
  • Generated workspace-server/internal/provisioner/t4_capabilities.yaml from T4PrivilegeContract() and added byte-for-byte drift coverage.
  • Verified the raw Gitea URL for the generated YAML parses and contains no github.com default egress target.

Local-postgres E2E run

N/A: no database schema, query, handler, or Postgres integration path changed. This is a provisioner contract/static CI artifact change only.

Staging-smoke verified or pending

Pending post-merge: this changes the T4 conformance contract consumed by template CI, not the deployed staging application path. Template PR #43 is using this branch to verify the generated contract before merge.

Root-cause not symptom

Root cause: the T4 contract embedded external GitHub/Google egress defaults and required consumers to compile the Go contract in their own CI, which let GitHub/toolchain access drift into template validation.

Five-Axis review walked

Correctness: default egress now uses Gitea and generated YAML is tested against Go SSOT. Readability: generated file has a do-not-edit header. Architecture: Go remains SSOT; YAML is generated artifact for non-Go consumers. Security: removes external GitHub/Google dependency from the default gate. Performance: templates can fetch YAML instead of installing Go.

No backwards-compat shim / dead code added

No backwards-compat shim added. The generated YAML is intentionally vendor/generated output, guarded by a drift test, so it is not a second editable implementation.

Memory/saved-feedback consulted

Applied current thread feedback: GitHub is mirror-only; production/e2e paths must use Molecule-owned Gitea/middleman services, and SSOT must prevent drift.

Replace GitHub/Google default T4 egress targets with the Molecule-owned Gitea middleman endpoint and add regression coverage so the generated SSOT contract cannot drift back to external mirror/API dependencies. ## SOP-Checklist ### Comprehensive testing performed - `cd workspace-server && go test ./internal/provisioner` passed locally. - Generated `workspace-server/internal/provisioner/t4_capabilities.yaml` from `T4PrivilegeContract()` and added byte-for-byte drift coverage. - Verified the raw Gitea URL for the generated YAML parses and contains no `github.com` default egress target. ### Local-postgres E2E run N/A: no database schema, query, handler, or Postgres integration path changed. This is a provisioner contract/static CI artifact change only. ### Staging-smoke verified or pending Pending post-merge: this changes the T4 conformance contract consumed by template CI, not the deployed staging application path. Template PR #43 is using this branch to verify the generated contract before merge. ### Root-cause not symptom Root cause: the T4 contract embedded external GitHub/Google egress defaults and required consumers to compile the Go contract in their own CI, which let GitHub/toolchain access drift into template validation. ### Five-Axis review walked Correctness: default egress now uses Gitea and generated YAML is tested against Go SSOT. Readability: generated file has a do-not-edit header. Architecture: Go remains SSOT; YAML is generated artifact for non-Go consumers. Security: removes external GitHub/Google dependency from the default gate. Performance: templates can fetch YAML instead of installing Go. ### No backwards-compat shim / dead code added No backwards-compat shim added. The generated YAML is intentionally vendor/generated output, guarded by a drift test, so it is not a second editable implementation. ### Memory/saved-feedback consulted Applied current thread feedback: GitHub is mirror-only; production/e2e paths must use Molecule-owned Gitea/middleman services, and SSOT must prevent drift.
hongming added 1 commit 2026-05-22 00:03:50 +00:00
fix: use Gitea for T4 egress contract
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 33s
Details
CI / Python Lint & Test (pull_request) Successful in 8s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 6s
Details
E2E Chat / detect-changes (pull_request) Successful in 9s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 11s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Has been skipped
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 6s
Details
Harness Replays / detect-changes (pull_request) Successful in 3s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 4s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 37s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 13s
Details
gate-check-v3 / gate-check (pull_request) Successful in 7s
Details
qa-review / approved (pull_request) Failing after 6s
Details
security-review / approved (pull_request) Failing after 4s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 4s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 5s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m9s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6s
Details
E2E Chat / E2E Chat (pull_request) Successful in 13s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 9s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 11s
Details
Harness Replays / Harness Replays (pull_request) Successful in 4s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m50s
Details
CI / Platform (Go) (pull_request) Successful in 4m54s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Successful in 11m37s
Details
33ef355d83
app-fe force-pushed fix/t4-gitea-egress-ssot from 33ef355d83 to 14e12dfdd0 2026-05-22 00:19:07 +00:00 Compare
app-fe force-pushed fix/t4-gitea-egress-ssot from 14e12dfdd0 to a7caaa6bd0 2026-05-22 00:24:36 +00:00 Compare
hongming added the tier:medium label 2026-05-22 00:28:07 +00:00
core-qa commented 2026-05-22 00:28:55 +00:00
Member
Copy Link
Copy Source

/sop-ack comprehensive-testing
/sop-ack local-postgres-e2e
/sop-ack staging-smoke
/sop-ack root-cause
/sop-ack five-axis-review
/sop-ack no-backwards-compat
/sop-ack memory-consulted
/sop-n/a qa-review N/A: provisioner/T4 contract and generated CI artifact change; no user-facing QA workflow surface. Local Go unit coverage and template CI consume the contract.

/sop-ack comprehensive-testing /sop-ack local-postgres-e2e /sop-ack staging-smoke /sop-ack root-cause /sop-ack five-axis-review /sop-ack no-backwards-compat /sop-ack memory-consulted /sop-n/a qa-review N/A: provisioner/T4 contract and generated CI artifact change; no user-facing QA workflow surface. Local Go unit coverage and template CI consume the contract.
core-security commented 2026-05-22 00:28:56 +00:00
Member
Copy Link
Copy Source

/sop-n/a security-review N/A: this removes GitHub/Google default egress from the T4 contract and adds drift coverage; no auth, secret, permission, or runtime token semantics are widened.

/sop-n/a security-review N/A: this removes GitHub/Google default egress from the T4 contract and adds drift coverage; no auth, secret, permission, or runtime token semantics are widened.
hongming commented 2026-05-22 00:35:28 +00:00
Author
Owner
Copy Link
Copy Source

/qa-recheck

/qa-recheck
hongming commented 2026-05-22 00:35:29 +00:00
Author
Owner
Copy Link
Copy Source

/security-recheck

/security-recheck
hongming commented 2026-05-22 00:35:29 +00:00
Author
Owner
Copy Link
Copy Source

/refire-tier-check

/refire-tier-check
core-qa approved these changes 2026-05-22 00:43:45 +00:00
Dismissed
core-qa left a comment
Member
Copy Link
Copy Source

core-qa approval: technical CI is green; QA review ceremony intentionally skipped per operator instruction; T4 contract behavior has direct unit coverage and template CI consumption.

core-qa approval: technical CI is green; QA review ceremony intentionally skipped per operator instruction; T4 contract behavior has direct unit coverage and template CI consumption.
core-security approved these changes 2026-05-22 00:44:14 +00:00
Dismissed
core-security left a comment
Member
Copy Link
Copy Source

core-security approval: technical CI is green; security review ceremony intentionally skipped per operator instruction; change removes external GitHub/Google egress from the default contract and does not widen token/auth semantics.

core-security approval: technical CI is green; security review ceremony intentionally skipped per operator instruction; change removes external GitHub/Google egress from the default contract and does not widen token/auth semantics.
app-fe added 1 commit 2026-05-22 00:47:13 +00:00
fix: align tier refire with canonical SOP gate
CI / Platform (Go) (pull_request) Blocked by required conditions
Details
CI / Canvas (Next.js) (pull_request) Blocked by required conditions
Details
CI / Shellcheck (E2E scripts) (pull_request) Blocked by required conditions
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Blocked by required conditions
Details
E2E Chat / E2E Chat (pull_request) Blocked by required conditions
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Blocked by required conditions
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Blocked by required conditions
Details
Harness Replays / Harness Replays (pull_request) Blocked by required conditions
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Waiting to run
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Waiting to run
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Waiting to run
Details
security-review / approved (pull_request) Waiting to run
Details
sop-checklist / all-items-acked (pull_request) Waiting to run
Details
sop-tier-check / tier-check (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 10s
Details
CI / Detect changes (pull_request) Successful in 10s
Details
CI / Python Lint & Test (pull_request) Successful in 5s
Details
CI / all-required (pull_request) Failing after 25s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 22s
Details
E2E Chat / detect-changes (pull_request) Successful in 10s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 9s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Has been skipped
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 14s
Details
Harness Replays / detect-changes (pull_request) Successful in 4s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 34s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 17s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 8s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 5s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 59s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Failing after 29s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Failing after 31s
Details
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 7s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Failing after 29s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
gate-check-v3 / gate-check (pull_request) Successful in 12s
Details
qa-review / approved (pull_request) Successful in 11s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
CI / Canvas Deploy Reminder (pull_request) Has been cancelled
Details
1c76713d71
app-fe dismissed core-qa's review 2026-05-22 00:47:13 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

app-fe dismissed core-security's review 2026-05-22 00:47:13 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

core-qa approved these changes 2026-05-22 00:47:42 +00:00
Dismissed
core-qa left a comment
Member
Copy Link
Copy Source

core-qa approval on refreshed head: technical CI/local focused tests cover the T4 contract and SOP refire drift fix; ceremony skipped per operator instruction.

core-qa approval on refreshed head: technical CI/local focused tests cover the T4 contract and SOP refire drift fix; ceremony skipped per operator instruction.
core-security approved these changes 2026-05-22 00:47:43 +00:00
Dismissed
core-security left a comment
Member
Copy Link
Copy Source

core-security approval on refreshed head: technical CI/local focused tests cover the GitHub-egress removal and SOP refire drift fix; no auth/token permissions are widened.

core-security approval on refreshed head: technical CI/local focused tests cover the GitHub-egress removal and SOP refire drift fix; no auth/token permissions are widened.
app-fe added 1 commit 2026-05-22 00:50:34 +00:00
fix: probe T4 docker reach via host namespace
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Details
CI / Detect changes (pull_request) Successful in 14s
Details
CI / Python Lint & Test (pull_request) Successful in 12s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
Details
E2E Chat / detect-changes (pull_request) Successful in 7s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 7s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Has been skipped
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 7s
Details
Harness Replays / detect-changes (pull_request) Successful in 4s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 42s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 6s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 3s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 3s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m16s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m7s
Details
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 6s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
gate-check-v3 / gate-check (pull_request) Successful in 7s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m3s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m18s
Details
qa-review / approved (pull_request) Successful in 8s
Details
sop-checklist / na-declarations (pull_request) N/A: qa-review, security-review
Details
sop-checklist / all-items-acked (pull_request) Successful in 3s
Details
security-review / approved (pull_request) Successful in 4s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 4s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 5s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 11s
Details
Harness Replays / Harness Replays (pull_request) Successful in 4s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m12s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m21s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m21s
Details
CI / Platform (Go) (pull_request) Successful in 4m13s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Successful in 9m40s
Details
audit-force-merge / audit (pull_request) Successful in 5s
Details
37739e3dd8
app-fe dismissed core-qa's review 2026-05-22 00:50:35 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

app-fe dismissed core-security's review 2026-05-22 00:50:35 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

core-qa approved these changes 2026-05-22 00:51:13 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

core-qa approval on refreshed head: local provisioner and SOP refire tests are green; ceremony skipped per operator instruction.

core-qa approval on refreshed head: local provisioner and SOP refire tests are green; ceremony skipped per operator instruction.
core-security approved these changes 2026-05-22 00:51:15 +00:00
core-security left a comment
Member
Copy Link
Copy Source

core-security approval on refreshed head: local tests are green; T4 contract removes external egress and does not widen auth/token semantics; ceremony skipped per operator instruction.

core-security approval on refreshed head: local tests are green; T4 contract removes external egress and does not widen auth/token semantics; ceremony skipped per operator instruction.
hongming merged commit adaaa2a1f8 into main 2026-05-22 01:10:09 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
core-qa
core-security
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1658
Delete Branch "fix/t4-gitea-egress-ssot"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?