fix(canvas/a2a-hint): route poll-mode budget timeout away from restart anti-pattern (P1 #348) #1607

Merged

core-devops merged 1 commits from fix/a2a-error-hint-timeout-class into staging 2026-05-20 13:32:38 +00:00

Conversation 0 Commits 1 Files Changed 2

+107 -2

hongming commented 2026-05-20 10:25:05 +00:00

Owner

Copy Link

Copy Source

Summary

P1 #348 sub-fix. canvas/src/components/tabs/chat/a2aErrorHint.ts
previously routed the empty-detail and generic-timeout cases to a bare
"workspace restart is the safe first move" prompt — the anti-pattern
per feedback_surface_actionable_failure_reason_to_user when the
underlying error is a still-in-flight long-running task (PM
coordinating Researcher on codex is the canonical case).

Three changes:

1. New polling timeout after/check_task_status pattern, ordered
   ABOVE the generic timeout bucket, routes the poll-mode budget-
   exhaustion shape (emitted by a2a_tools_delegation.py:199) to a
   hint that explicitly tells the user NOT to restart and to call
   check_task_status with the delegation_id to retrieve the
   in-flight result.

2. New optional context.peerKind parameter. When the caller knows
   the callee is a codex runtime, the empty-detail and generic-
   timeout hints specialise to call out that codex tasks can
   legitimately exceed the 600s sync-proxy budget.

3. The empty-detail branch (the most common "useless hint" path) no
   longer claims "restart is the safe first move" by default — it
   now tells the user to check the callee's Activity tab before
   restarting.

Risk

• Pure refactor of advice text + new optional parameter.
• Existing single-arg callers (ActivityTab.tsx:358,
  AgentCommsPanel.tsx:758) continue to compile unchanged.
• One existing test was updated where it pinned the old "safe first
  move" wording; new behavior pinned with 8 added test cases.

Test plan

• vitest run a2aErrorHint.test.ts — 17/17 pass (9 prior + 8 new)
• tsc --noEmit clean for the file (pre-existing unrelated errors
  in other test files persist)
• post-merge: trigger a poll-mode 600s timeout end-to-end and verify
  canvas shows the new "Do NOT restart" hint

Refs P1 #348, feedback_surface_actionable_failure_reason_to_user.

## Summary P1 #348 sub-fix. `canvas/src/components/tabs/chat/a2aErrorHint.ts` previously routed the empty-detail and generic-timeout cases to a bare "workspace restart is the safe first move" prompt — the anti-pattern per `feedback_surface_actionable_failure_reason_to_user` when the underlying error is a still-in-flight long-running task (PM coordinating Researcher on codex is the canonical case). Three changes: 1. New `polling timeout after`/`check_task_status` pattern, ordered ABOVE the generic timeout bucket, routes the poll-mode budget- exhaustion shape (emitted by `a2a_tools_delegation.py:199`) to a hint that explicitly tells the user NOT to restart and to call check_task_status with the delegation_id to retrieve the in-flight result. 2. New optional `context.peerKind` parameter. When the caller knows the callee is a codex runtime, the empty-detail and generic- timeout hints specialise to call out that codex tasks can legitimately exceed the 600s sync-proxy budget. 3. The empty-detail branch (the most common "useless hint" path) no longer claims "restart is the safe first move" by default — it now tells the user to check the callee's Activity tab before restarting. ## Risk - Pure refactor of advice text + new optional parameter. - Existing single-arg callers (`ActivityTab.tsx:358`, `AgentCommsPanel.tsx:758`) continue to compile unchanged. - One existing test was updated where it pinned the old "safe first move" wording; new behavior pinned with 8 added test cases. ## Test plan - [x] `vitest run a2aErrorHint.test.ts` — 17/17 pass (9 prior + 8 new) - [x] `tsc --noEmit` clean for the file (pre-existing unrelated errors in other test files persist) - [ ] post-merge: trigger a poll-mode 600s timeout end-to-end and verify canvas shows the new "Do NOT restart" hint Refs P1 #348, feedback_surface_actionable_failure_reason_to_user.

hongming added 1 commit 2026-05-20 10:25:06 +00:00

fix(canvas/a2a-hint): route poll-mode budget timeout away from restart anti-pattern (P1 #348) ... dd3d11c51d

Per `feedback_surface_actionable_failure_reason_to_user`, an opaque
"workspace restart is the safe first move" prompt is the anti-pattern
when the underlying error is a still-in-flight long-running task —
which is exactly the canonical PM→Researcher codex coordination case
that surfaces "FAILED TO DELIVER" today.

Three improvements:

1. New `polling timeout after`/`check_task_status` pattern, ordered
   ABOVE the generic timeout bucket, routes to a hint that explicitly
   tells the user NOT to restart and to call check_task_status with
   the delegation_id to retrieve the in-flight result.

2. New optional `context.peerKind` parameter. When the caller knows
   the callee is a codex runtime, the empty-detail and generic-timeout
   hints specialise to call out that codex tasks can legitimately
   exceed the 600s sync-proxy budget.

3. The empty-detail branch (the most common "useless hint" path) no
   longer claims "restart is the safe first move" by default — it now
   tells the user to check the callee's Activity tab before restarting.

Existing single-arg callers continue to compile unchanged (context is
optional). Regression test count goes 9 → 17.

Refs P1 #348, feedback_surface_actionable_failure_reason_to_user.

core-be approved these changes 2026-05-20 13:32:35 +00:00

core-be left a comment

Member

Copy Link

Copy Source

APPROVED from core-be lens. PR routes poll-mode budget-timeout away from the misleading 'agent error' surface to a more specific 'budget exhausted' hint in canvas. Per feedback_surface_actionable_failure_reason_to_user; closes a UX-papercut where opaque timeouts looked like crashes. CI/all-required=success.

APPROVED from core-be lens. PR routes poll-mode budget-timeout away from the misleading 'agent error' surface to a more specific 'budget exhausted' hint in canvas. Per feedback_surface_actionable_failure_reason_to_user; closes a UX-papercut where opaque timeouts looked like crashes. CI/all-required=success.

core-qa approved these changes 2026-05-20 13:32:36 +00:00

core-qa left a comment

Member

Copy Link

Copy Source

APPROVED from core-qa lens. Hint-routing logic unit-tested; matches canvas TypeScript a2aErrorHint signature. CI green.

APPROVED from core-qa lens. Hint-routing logic unit-tested; matches canvas TypeScript a2aErrorHint signature. CI green.

core-devops merged commit c3ba26ead2 into staging 2026-05-20 13:32:38 +00:00

core-devops referenced this issue from a commit 2026-05-20 13:32:38 +00:00

Merge pull request 'fix(canvas/a2a-hint): route poll-mode budget timeout away from restart anti-pattern (P1 #348)' (#1607) from fix/a2a-error-hint-timeout-class into staging

Sign in to join this conversation.

Reviewers

No Reviewers

core-be

core-qa

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1607