fix(delegation): emit error_detail alongside error in /delegations rows (P1 #348) #1606

Merged

core-devops merged 1 commits from fix/a2a-error-detail-field-rename into staging 2026-05-20 13:32:34 +00:00

Conversation 0 Commits 1 Files Changed 2

+84 -1

hongming commented 2026-05-20 10:25:03 +00:00

Owner

Copy Link

Copy Source

Summary

P1 #348 sub-fix. The Python poll-mode A2A consumer
(workspace/a2a_tools_delegation.py:184) reads
terminal.get("error_detail") from /workspaces/:id/delegations,
but the Go listDelegations handlers in
workspace-server/internal/handlers/delegation.go emitted only
error. On failure poll-mode silently lost the detail and fell
through to the generic "delegation failed" string — leaving the
canvas "FAILED TO DELIVER" with no actionable reason.

Both ledger-path (listDelegationsFromLedger) and activity_logs-path
(listDelegationsFromActivityLogs) now emit BOTH keys.

Risk

• Additive only. Existing canvas UI consumers reading error keep working.
• New error_detail field exposed in the JSON envelope; canvas/python
  consumers that parse strict-schema would have to opt-in, none today.
• No DB migration, no flag, no env change.

Test plan

• TestListDelegations_LedgerFailedIncludesErrorDetail now pins both keys
• new TestListDelegations_ActivityLogsFailedEmitsBothErrorKeys covers fallback path
• go vet clean, go build ./internal/handlers/... clean
• post-merge: stage a delegation that fails on agents-team workspace,
  observe poll-mode surfaces the real error instead of "delegation failed"

Refs P1 #348, RFC #2829 PR-2 follow-up.

## Summary P1 #348 sub-fix. The Python poll-mode A2A consumer (`workspace/a2a_tools_delegation.py:184`) reads `terminal.get("error_detail")` from `/workspaces/:id/delegations`, but the Go listDelegations handlers in `workspace-server/internal/handlers/delegation.go` emitted only `error`. On failure poll-mode silently lost the detail and fell through to the generic "delegation failed" string — leaving the canvas "FAILED TO DELIVER" with no actionable reason. Both ledger-path (`listDelegationsFromLedger`) and activity_logs-path (`listDelegationsFromActivityLogs`) now emit BOTH keys. ## Risk - Additive only. Existing canvas UI consumers reading `error` keep working. - New `error_detail` field exposed in the JSON envelope; canvas/python consumers that parse strict-schema would have to opt-in, none today. - No DB migration, no flag, no env change. ## Test plan - [x] `TestListDelegations_LedgerFailedIncludesErrorDetail` now pins both keys - [x] new `TestListDelegations_ActivityLogsFailedEmitsBothErrorKeys` covers fallback path - [x] `go vet` clean, `go build ./internal/handlers/...` clean - [ ] post-merge: stage a delegation that fails on agents-team workspace, observe poll-mode surfaces the real error instead of "delegation failed" Refs P1 #348, RFC #2829 PR-2 follow-up.

hongming added 1 commit 2026-05-20 10:25:03 +00:00

fix(delegation): emit error_detail alongside error in /delegations rows (P1 #348) ... 5d6dccfb18

The Python poll-mode A2A consumer in a2a_tools_delegation.py:184 reads
`terminal.get("error_detail")` from `/workspaces/:id/delegations` rows,
but the Go listDelegations handlers emitted only `error`. When a
delegation failed, polling silently lost the failure reason and fell
through to the generic "delegation failed" string — leaving the canvas
"FAILED TO DELIVER" surface with no actionable detail.

Both ledger-path (listDelegationsFromLedger) and activity_logs-path
(listDelegationsFromActivityLogs) now emit BOTH keys: `error_detail`
(canonical, what poll-mode reads) and `error` (kept for back-compat
with existing canvas UI consumers).

Regression tests pin both keys for both code paths.

Refs P1 #348, RFC #2829 PR-2 follow-up.

core-be approved these changes 2026-05-20 13:32:33 +00:00

core-be left a comment

Member

Copy Link

Copy Source

APPROVED from core-be lens. PR adds error_detail alongside error in /delegation responses — surface-actionable failure-reason per feedback_surface_actionable_failure_reason_to_user. Both fields populated (backwards compat via dual-emit). Small UX/observability win. CI/all-required=success.

APPROVED from core-be lens. PR adds `error_detail` alongside `error` in /delegation responses — surface-actionable failure-reason per feedback_surface_actionable_failure_reason_to_user. Both fields populated (backwards compat via dual-emit). Small UX/observability win. CI/all-required=success.

core-qa approved these changes 2026-05-20 13:32:33 +00:00

core-qa left a comment

Member

Copy Link

Copy Source

APPROVED from core-qa lens. Test coverage extends existing /delegation tests; field-rename verified via JSON shape assertion. CI green.

APPROVED from core-qa lens. Test coverage extends existing /delegation tests; field-rename verified via JSON shape assertion. CI green.

core-devops merged commit 3a1654818c into staging 2026-05-20 13:32:34 +00:00

core-devops referenced this issue from a commit 2026-05-20 13:32:35 +00:00

Merge pull request 'fix(delegation): emit error_detail alongside error in /delegations rows (P1 #348)' (#1606) from fix/a2a-error-detail-field-rename into staging

Sign in to join this conversation.

Reviewers

No Reviewers

core-qa

core-be

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1606