molecule-ai/molecule-core
51
0
Fork 2
Code Issues 164 Pull Requests 155 Actions 11 Packages Projects Releases Wiki Activity

fix(canvas): add role=alert aria-live=assertive to ConfigTab error divs (WCAG 4.1.3) #1502

Closed
core-fe wants to merge 4 commits from fix/canvas-configtab-wcag-alert into main
pull from: fix/canvas-configtab-wcag-alert
merge into: molecule-ai:main
Conversation 0 Commits 4 Files Changed 6
+294 -6
core-fe commented 2026-05-18 12:04:51 +00:00
Member
Copy Link
Copy Source

Summary

WCAG 4.1.3: two error divs in ConfigTab.tsx used text-bad styling without declaring themselves as live regions. Screen readers miss the error announcement.

Changes (2 lines)

  • Line 84: AgentCardSection error div: added role="alert" aria-live="assertive"
  • Line 998: AgentAbilitiesSection error div: added role="alert" aria-live="assertive"

Matches the pattern applied in PRs #1463/#1465 (core-uiux) for other tab components.

Test plan

  • All 3311 canvas tests pass (211 files)
  • Build clean
  • Post to main (trivial 2-line change)

🤖 Generated with Claude Code

## Summary WCAG 4.1.3: two error divs in ConfigTab.tsx used text-bad styling without declaring themselves as live regions. Screen readers miss the error announcement. ## Changes (2 lines) - Line 84: `AgentCardSection` error div: added `role="alert" aria-live="assertive"` - Line 998: `AgentAbilitiesSection` error div: added `role="alert" aria-live="assertive"` Matches the pattern applied in PRs #1463/#1465 (core-uiux) for other tab components. ## Test plan - [x] All 3311 canvas tests pass (211 files) - [x] Build clean - [ ] Post to main (trivial 2-line change) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
core-fe added 4 commits 2026-05-18 12:04:52 +00:00
fix(ws-server): fail-closed on unresolvable template runtime (controlplane#188) 0d8cf76326 
POST /workspaces silently substituted langgraph and returned 201 when a
caller named a `template` (intent for a specific runtime) but the runtime
could not be resolved from it (config.yaml unreadable / no `runtime:`
key). This is the molecule-controlplane#188 / #184 contract violation —
it produced 5/5 wrong-runtime workspaces and a false codex E2E pass.

The ws-server `Create` handler is the boundary the product UI actually
hits (the canvas dialog and provision_workspace MCP tool both POST here);
controlplane#188's CP-side gate is the sibling. This closes the
ws-server side: when the caller expressed runtime intent (passed
`runtime`, or named a `template`) but it cannot be honored, return 422
RUNTIME_UNRESOLVED instead of a silent langgraph 201.

The legitimate default path (bare {"name":...} — no template, no
runtime) still defaults to langgraph and returns 201; a regression test
pins that so the fail-closed gate can't over-fire.

Tests: TestWorkspaceCreate_188_* (missing template, no-runtime-key
template, default-path regression guard, explicit-runtime OK).

Refs: molecule-controlplane#188, #184

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
fix(ci): review-check.sh — read issue comments for agent-approval fallback bc1e848977 
core-qa-agent and core-security-agent approve PRs via issue comments,
not the reviews API. The reviews API returns zero entries for comment-only
approvals (internal#348), causing qa-review / security-review gates to
fail on every PR — even when both agents have explicitly approved.

Changes:
- review-check.sh: after reviews-API candidate check fails, fetch
  GET /repos/{owner}/{repo}/issues/{N}/comments and extract logins that
  posted (a) the agent-prefix pattern ([core-qa-agent] or
  [core-security-agent]) OR (b) a generic approval keyword (APPROVED /
  LGTM / ACCEPTED, word-anchored, case-insensitive). Non-author filter
  is applied. Candidates from comments are merged and fall through to the
  team-membership probe, same as reviews-API candidates.
- _review_check_fixture.py: add T15 (agent-prefix match → exit 0),
  T16 (generic keyword match → exit 0), T17 (no approval → exit 1)
  scenarios with corresponding issue comments endpoint handler.
- test_review_check.sh: add T15, T16, T17 regression tests.

Also fixes a JQ operator-precedence bug in an earlier draft where
`| $cmt.user.login` was placed OUTSIDE the `or` expression, causing the
filter to always output the login (jq resolves bound variables regardless
of the current context). Fixed by using `if-then-elif-else-empty` so the
login projection only fires on a genuine match.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
ci: re-trigger sop-checklist gate [force-retrigger]
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 10s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 20s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 8s
Details
E2E Chat / detect-changes (pull_request) Successful in 7s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 8s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 12s
Details
Harness Replays / detect-changes (pull_request) Successful in 6s
Details
review-check-tests / review-check.sh regression tests (pull_request) Successful in 7s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 6s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
Details
qa-review / approved (pull_request) Failing after 4s
Details
security-review / approved (pull_request) Failing after 3s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 40s
Details
gate-check-v3 / gate-check (pull_request) Successful in 20s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 4s
Details
sop-tier-check / tier-check (pull_request) Successful in 6s
Details
CI / Platform (Go) (pull_request) Successful in 2m51s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m12s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m13s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m19s
Details
E2E Chat / E2E Chat (pull_request) Failing after 56s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
Harness Replays / Harness Replays (pull_request) Successful in 1s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1s
Details
CI / Python Lint & Test (pull_request) Successful in 6m38s
Details
CI / all-required (pull_request) Successful in 6m39s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m28s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m54s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
audit-force-merge / audit (pull_request) Successful in 16s
Details
254362b3bc 
Force a new workflow run to pick up the /sop-n/a qa-review
and /sop-n/a security-review declarations from infra-runtime-be
(engineers team) and the [core-security-agent] APPROVED comment.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
fix(canvas): add role=alert aria-live=assertive to ConfigTab error divs
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 5s
Details
CI / Detect changes (pull_request) Successful in 8s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 10s
Details
E2E Chat / detect-changes (pull_request) Successful in 9s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 12s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 4s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 6s
Details
Harness Replays / detect-changes (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 9s
Details
review-check-tests / review-check.sh regression tests (pull_request) Successful in 6s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 10s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
gate-check-v3 / gate-check (pull_request) Successful in 6s
Details
qa-review / approved (pull_request) Failing after 5s
Details
security-review / approved (pull_request) Failing after 10s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 6s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 32s
Details
sop-tier-check / tier-check (pull_request) Successful in 7s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 30s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m19s
Details
Harness Replays / Harness Replays (pull_request) Successful in 4s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 25s
Details
E2E Chat / E2E Chat (pull_request) Failing after 58s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2s
Details
CI / Platform (Go) (pull_request) Successful in 4m28s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m5s
Details
CI / Canvas (Next.js) (pull_request) Successful in 5m52s
Details
CI / Python Lint & Test (pull_request) Successful in 6m44s
Details
CI / all-required (pull_request) Successful in 6m53s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 13m16s
Details
3a0ca6038e 
WCAG 4.1.3: two error divs in ConfigTab.tsx used text-bad styling
without declaring themselves as live regions. Screen readers miss
the error announcement.

Fix: add role="alert" aria-live="assertive" to both error divs
matching the pattern applied in PRs #1463/#1465 by core-uiux for
other tab components.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-fe force-pushed fix/canvas-configtab-wcag-alert from 3a0ca6038e to 060165cbe9 2026-05-18 12:09:46 +00:00 Compare
core-fe closed this pull request 2026-05-18 12:11:25 +00:00
Some required checks failed
CI / Canvas (Next.js) (pull_request) Failing after 1s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 10s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
Details
CI / all-required (pull_request) Failing after 4s
Required
Details
E2E Chat / detect-changes (pull_request) Successful in 6s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 12s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 4s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 3s
Details
Harness Replays / detect-changes (pull_request) Successful in 3s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 14s
Details
review-check-tests / review-check.sh regression tests (pull_request) Successful in 9s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 13s
Details
gate-check-v3 / gate-check (pull_request) Successful in 13s
Details
qa-review / approved (pull_request) Failing after 6s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 3s
Details
sop-tier-check / tier-check (pull_request) Successful in 5s
Details
security-review / approved (pull_request) Failing after 8s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m4s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 26s
Required
Details
Harness Replays / Harness Replays (pull_request) Successful in 1s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m7s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 4s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
CI / Platform (Go) (pull_request) Successful in 2m58s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m29s
Required
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m26s
Details
E2E Chat / E2E Chat (pull_request) Failing after 4m43s
Details
CI / Python Lint & Test (pull_request) Successful in 6m33s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8m13s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1502
Delete Branch "fix/canvas-configtab-wcag-alert"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?