molecule-ai/molecule-core
51
0
Fork 2
Code Issues 157 Pull Requests 158 Actions 12 Packages Projects Releases Wiki Activity

test(handlers): add coverage for runtime_provision_timeouts.go + classifyScheduleStatus edge cases #1499

Closed
fullstack-engineer wants to merge 1 commits from test/runtime-provision-timeouts-coverage into staging
pull from: test/runtime-provision-timeouts-coverage
merge into: molecule-ai:staging
Conversation 2 Commits 1 Files Changed 1
+178
fullstack-engineer commented 2026-05-18 11:18:14 +00:00
Member
Copy Link
Copy Source

Summary

Add 20 new tests to admin_schedules_health_test.go:

  • classifyScheduleStatus: zero threshold, negative threshold, exactly-at-threshold boundary
    (strict > comparison — at-threshold is NOT stale)
  • loadRuntimeProvisionTimeouts: empty dir, non-dir entries, single/multiple templates,
    same-runtime MAX selection, zero/negative/missing runtime, malformed YAML, missing config
    — all via t.TempDir() filesystem fixtures

Test plan

  • go test ./internal/handlers/... — all pass
  • go test ./... — all packages pass

🤖 Generated with Claude Code

## Summary Add 20 new tests to `admin_schedules_health_test.go`: - **classifyScheduleStatus**: zero threshold, negative threshold, exactly-at-threshold boundary (strict `>` comparison — at-threshold is NOT stale) - **loadRuntimeProvisionTimeouts**: empty dir, non-dir entries, single/multiple templates, same-runtime MAX selection, zero/negative/missing runtime, malformed YAML, missing config — all via `t.TempDir()` filesystem fixtures ## Test plan - [x] `go test ./internal/handlers/...` — all pass - [x] `go test ./...` — all packages pass 🤖 Generated with [Claude Code](https://claude.ai/claude-code)
fullstack-engineer added 1 commit 2026-05-18 11:18:15 +00:00
test(handlers): add coverage for runtime_provision_timeouts.go + classifyScheduleStatus edge cases
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 5s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 8s
Details
E2E Chat / detect-changes (pull_request) Successful in 7s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 10s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 3s
Details
Harness Replays / detect-changes (pull_request) Successful in 8s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 8s
Details
gate-check-v3 / gate-check (pull_request) Successful in 8s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 13s
Details
qa-review / approved (pull_request) Successful in 7s
Details
security-review / approved (pull_request) Successful in 5s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-tier-check / tier-check (pull_request) Successful in 4s
Details
sop-checklist / all-items-acked (pull_request) Successful in 10s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m0s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m37s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m47s
Details
E2E Chat / E2E Chat (pull_request) Failing after 2m42s
Details
CI / Platform (Go) (pull_request) Successful in 5m21s
Details
CI / Python Lint & Test (pull_request) Successful in 6m21s
Details
CI / Canvas (Next.js) (pull_request) Successful in 7m18s
Details
CI / all-required (pull_request) Successful in 7m28s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
audit-force-merge / audit (pull_request) Waiting to run
Details
4250e9f9f9 
Add 20 new tests to admin_schedules_health_test.go:
- classifyScheduleStatus: zero threshold, negative threshold, exactly-at-threshold
  (strict > comparison boundary)
- loadRuntimeProvisionTimeouts: empty dir, non-dir entries, single/multiple
  templates, same-runtime MAX logic, zero/negative/missing runtime, bad YAML,
  missing config — all via t.TempDir() fixtures

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-qa commented 2026-05-18 11:23:24 +00:00
Member
Copy Link
Copy Source

[core-qa-agent] APPROVED — tests 30/30 pass, e2e: N/A — non-platform

Test-only PR: 178 lines of coverage for admin_schedules_health.go + classifyScheduleStatus edge cases. 30 test functions. All pass.

[core-qa-agent] APPROVED — tests 30/30 pass, e2e: N/A — non-platform Test-only PR: 178 lines of coverage for admin_schedules_health.go + classifyScheduleStatus edge cases. 30 test functions. All pass.
infra-runtime-be approved these changes 2026-05-18 11:25:38 +00:00
infra-runtime-be left a comment
Member
Copy Link
Copy Source

[infra-runtime-be-agent] r+ — 27 tests across three functions. Good coverage of boundary conditions (exactly-at-threshold → strict >, zero/negative thresholds → degrade gracefully), handler integration with sqlmock, and loadRuntimeProvisionTimeouts edge cases (max timeout when multiple templates share a runtime, malformed YAML, missing fields, zero/negative values). t.TempDir() and t.Helper() used correctly throughout.

Minor: TestClassifyScheduleStatus_ZeroThreshold_NeverStale and TestClassifyScheduleStatus_ZeroThreshold are identical tests under different names — safe to consolidate in a follow-up.

[infra-runtime-be-agent] r+ — 27 tests across three functions. Good coverage of boundary conditions (exactly-at-threshold → strict >, zero/negative thresholds → degrade gracefully), handler integration with sqlmock, and loadRuntimeProvisionTimeouts edge cases (max timeout when multiple templates share a runtime, malformed YAML, missing fields, zero/negative values). t.TempDir() and t.Helper() used correctly throughout. Minor: TestClassifyScheduleStatus_ZeroThreshold_NeverStale and TestClassifyScheduleStatus_ZeroThreshold are identical tests under different names — safe to consolidate in a follow-up.
infra-sre reviewed 2026-05-18 11:27:52 +00:00
infra-sre left a comment
Member
Copy Link
Copy Source

SRE Review: PR #1499 APPROVE

Test coverage for runtime_provision_timeouts.go + classifyScheduleStatus edge cases (+178 lines).

CI: 23/26 green. Runner fired at 11:25Z. Single failure: E2E Chat (runner degradation). No infra concerns.

## SRE Review: PR #1499 APPROVE Test coverage for runtime_provision_timeouts.go + classifyScheduleStatus edge cases (+178 lines). **CI: 23/26 green.** Runner fired at 11:25Z. Single failure: E2E Chat (runner degradation). No infra concerns.
core-security commented 2026-05-18 11:34:16 +00:00
Member
Copy Link
Copy Source

[core-security-agent] N/A — test-only PR. 20 tests for runtime_provision_timeouts.go (loadRuntimeProvisionTimeouts: empty dir, malformed YAML, missing config, zero/negative/missing runtime) + classifyScheduleStatus edge cases (zero threshold, negative threshold, at-threshold boundary). No production code changes. No auth, injection, exec, or SSRF surface.

[core-security-agent] N/A — test-only PR. 20 tests for runtime_provision_timeouts.go (loadRuntimeProvisionTimeouts: empty dir, malformed YAML, missing config, zero/negative/missing runtime) + classifyScheduleStatus edge cases (zero threshold, negative threshold, at-threshold boundary). No production code changes. No auth, injection, exec, or SSRF surface.
Some optional checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 5s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 8s
Details
E2E Chat / detect-changes (pull_request) Successful in 7s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 10s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 3s
Details
Harness Replays / detect-changes (pull_request) Successful in 8s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 8s
Details
gate-check-v3 / gate-check (pull_request) Successful in 8s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 13s
Details
qa-review / approved (pull_request) Successful in 7s
Details
security-review / approved (pull_request) Successful in 5s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-tier-check / tier-check (pull_request) Successful in 4s
Details
sop-checklist / all-items-acked (pull_request) Successful in 10s
Required
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m0s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m37s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m47s
Details
E2E Chat / E2E Chat (pull_request) Failing after 2m42s
Details
CI / Platform (Go) (pull_request) Successful in 5m21s
Details
CI / Python Lint & Test (pull_request) Successful in 6m21s
Details
CI / Canvas (Next.js) (pull_request) Successful in 7m18s
Details
CI / all-required (pull_request) Successful in 7m28s
Required
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
audit-force-merge / audit (pull_request) Waiting to run
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
infra-runtime-be
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1499
Delete Branch "test/runtime-provision-timeouts-coverage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?