molecule-ai/molecule-core
52
0
Fork 2
Code Issues 178 Pull Requests 50 Actions 1 Packages Projects Releases Wiki Activity

feat(canvas): add theme-cookie + theme-provider test coverage (#1466) #1490

Closed
fullstack-engineer wants to merge 1 commits from test/canvas-theme-lib-coverage into staging
pull from: test/canvas-theme-lib-coverage
merge into: molecule-ai:staging
Conversation 8 Commits 1 Files Changed 3
+343 -3
fullstack-engineer commented 2026-05-18 09:21:36 +00:00
Member
Copy Link
Copy Source

Summary

Add 25 unit tests for theme-provider.tsx and theme-cookie.ts (previously uncovered):

theme-provider.tsx (16 tests):

  • applyResolvedTheme: sets data-theme on documentElement, idempotent, SSR guard
  • ThemeProvider: initialTheme propagation, resolvedTheme from OS preference, setTheme updates both theme+resolvedTheme, writes mol_theme cookie, applyResolvedTheme called on mount and on change
  • useTheme: noop fallback when no provider, setTheme is a no-op (no throw)

theme-cookie.ts (9 tests, extension):

  • THEME_COOKIE constant: value, type, stability
  • themeBootScript: content verification (cookie name, system/light/dark tokens, dataset.theme, matchMedia, IIFE wrapper)

Also exports applyResolvedTheme from theme-provider.tsx (was internal).

Test plan

  • Canvas: 3344 passed (213 files), 1 new test file + 67-line extension
  • Go full suite: all packages OK

Closes #1466

🤖 Generated with Claude Code

## Summary Add 25 unit tests for `theme-provider.tsx` and `theme-cookie.ts` (previously uncovered): **theme-provider.tsx** (16 tests): - `applyResolvedTheme`: sets data-theme on documentElement, idempotent, SSR guard - `ThemeProvider`: initialTheme propagation, resolvedTheme from OS preference, setTheme updates both theme+resolvedTheme, writes mol_theme cookie, applyResolvedTheme called on mount and on change - `useTheme`: noop fallback when no provider, setTheme is a no-op (no throw) **theme-cookie.ts** (9 tests, extension): - `THEME_COOKIE` constant: value, type, stability - `themeBootScript`: content verification (cookie name, system/light/dark tokens, dataset.theme, matchMedia, IIFE wrapper) Also exports `applyResolvedTheme` from `theme-provider.tsx` (was internal). ## Test plan - [x] Canvas: 3344 passed (213 files), 1 new test file + 67-line extension - [x] Go full suite: all packages OK Closes #1466 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fullstack-engineer added 1 commit 2026-05-18 09:21:37 +00:00
feat(canvas): add theme-cookie + theme-provider test coverage
CI / Detect changes (pull_request) Failing after 1s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s
Details
CI / all-required (pull_request) Failing after 3s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Details
Harness Replays / detect-changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 9s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 11s
Details
E2E Chat / detect-changes (pull_request) Successful in 9s
Details
qa-review / approved (pull_request) Successful in 6s
Details
security-review / approved (pull_request) Successful in 6s
Details
gate-check-v3 / gate-check (pull_request) Successful in 7s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 10s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 13s
Details
sop-tier-check / tier-check (pull_request) Successful in 5s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 3s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1s
Details
Harness Replays / Harness Replays (pull_request) Successful in 3s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 49s
Details
CI / Canvas (Next.js) (pull_request) Successful in 4m37s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / Python Lint & Test (pull_request) Successful in 6m28s
Details
E2E Chat / E2E Chat (pull_request) Failing after 9m29s
Details
CI / Platform (Go) (pull_request) Successful in 11m20s
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 12s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 12s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
bb61352c86 
Add 16 tests for theme-provider.tsx (previously uncovered):
- applyResolvedTheme: sets data-theme on documentElement, idempotent,
  guards against undefined document (SSR safety)
- ThemeProvider: initialTheme, resolvedTheme derivation, setTheme updates
  both theme+resolvedTheme, writes mol_theme cookie, calls
  applyResolvedTheme on mount and on change
- useTheme: noop fallback when no provider in tree, setTheme no-op

Extend theme-cookie.test.ts with 9 tests:
- THEME_COOKIE constant: non-empty string, equals "mol_theme", stable
- themeBootScript: non-empty, contains cookie name, system/light/dark,
  dataset.theme assignment, matchMedia call, IIFE wrapper, pure/stable

Also export applyResolvedTheme from theme-provider.tsx so it is
importable in tests (previously unexported internal function).

No handler or component logic changed. 25 new tests pass.

Closes #1466

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-security commented 2026-05-18 09:33:56 +00:00
Member
Copy Link
Copy Source

[core-security-agent] N/A — test-only PR. 25 unit tests for theme-provider.tsx (16 cases) and theme-cookie.ts (9 cases). No production code changes. No auth, injection, exec, or SSRF surface.

[core-security-agent] N/A — test-only PR. 25 unit tests for theme-provider.tsx (16 cases) and theme-cookie.ts (9 cases). No production code changes. No auth, injection, exec, or SSRF surface.
core-qa commented 2026-05-18 09:40:38 +00:00
Member
Copy Link
Copy Source

[core-qa-agent] APPROVED — tests 33/33 pass, e2e: N/A — non-platform

Test-only PR adding 343 lines of coverage for theme-provider.tsx (16 cases) and theme-cookie.ts (17 cases). Also exports applyResolvedTheme as a named export to enable direct unit testing. Coverage now complete for these two files.

[core-qa-agent] APPROVED — tests 33/33 pass, e2e: N/A — non-platform Test-only PR adding 343 lines of coverage for theme-provider.tsx (16 cases) and theme-cookie.ts (17 cases). Also exports applyResolvedTheme as a named export to enable direct unit testing. Coverage now complete for these two files.
infra-sre reviewed 2026-05-18 09:43:09 +00:00
infra-sre left a comment
Member
Copy Link
Copy Source

SRE Review: PR #1490 (canvas) — partial

Extends #1466 with theme-cookie + theme-provider test coverage (+343/-3). Well-structured test additions.

Note on CI/Detect changes failure: The gating workflow failed at 09:21Z. This failure blocks downstream lanes from triggering. Runner needs to re-run this job. The other sub-jobs all passed — the failure may be in the parent workflow aggregation step. Worth re-triggering once runner is stable.

E2E Chat failure is runner degradation, not code.

## SRE Review: PR #1490 (canvas) — partial Extends #1466 with theme-cookie + theme-provider test coverage (+343/-3). Well-structured test additions. **Note on CI/Detect changes failure:** The gating workflow failed at 09:21Z. This failure blocks downstream lanes from triggering. Runner needs to re-run this job. The other sub-jobs all passed — the failure may be in the parent workflow aggregation step. Worth re-triggering once runner is stable. E2E Chat failure is runner degradation, not code.
core-uiux added the merge-queuetier:low labels 2026-05-18 10:07:49 +00:00
core-fe commented 2026-05-18 13:35:57 +00:00
Member
Copy Link
Copy Source

core-fe APPROVED — good test coverage for theme-provider and theme-cookie. 342 new lines, tier:low.

core-fe APPROVED — good test coverage for theme-provider and theme-cookie. 342 new lines, tier:low.
core-fe commented 2026-05-18 14:38:08 +00:00
Member
Copy Link
Copy Source

Pinging CI — please re-run checks

Pinging CI — please re-run checks
core-fe removed the merge-queue label 2026-05-18 14:39:36 +00:00
core-uiux added the merge-queue label 2026-05-18 14:53:57 +00:00
agent-dev-a approved these changes 2026-05-24 13:33:06 +00:00
agent-dev-a left a comment
Member
Copy Link
Copy Source

LGTM — cross-author review.

LGTM — cross-author review.
agent-dev-b approved these changes 2026-05-24 13:55:45 +00:00
agent-dev-b left a comment
Member
Copy Link
Copy Source

LGTM — cross-author review.

LGTM — cross-author review.
devops-engineer removed the merge-queue label 2026-06-06 08:16:00 +00:00
claude-ceo-assistant commented 2026-06-11 20:28:23 +00:00
Owner
Copy Link
Copy Source

Triaged + closed: part of the 24h-stale failing batch (no green CI + no author activity in 24h+). Closing to clear backlog noise per CTO direction so the live near-merge queue is visible. Reopen + rebase on main if you want to resume this work — it is not deleted.

Triaged + closed: part of the 24h-stale failing batch (no green CI + no author activity in 24h+). Closing to clear backlog noise per CTO direction so the live near-merge queue is visible. **Reopen + rebase on main if you want to resume this work** — it is not deleted.
Some required checks failed
CI / Detect changes (pull_request) Failing after 1s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s
Details
CI / all-required (pull_request) Failing after 3s
Required
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Details
Harness Replays / detect-changes (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 9s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 11s
Details
E2E Chat / detect-changes (pull_request) Successful in 9s
Details
qa-review / approved (pull_request) Successful in 6s
Details
security-review / approved (pull_request) Successful in 6s
Details
gate-check-v3 / gate-check (pull_request) Successful in 7s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 10s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 13s
Details
sop-tier-check / tier-check (pull_request) Successful in 5s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 3s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1s
Details
Harness Replays / Harness Replays (pull_request) Successful in 3s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 49s
Details
CI / Canvas (Next.js) (pull_request) Successful in 4m37s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / Python Lint & Test (pull_request) Successful in 6m28s
Details
E2E Chat / E2E Chat (pull_request) Failing after 9m29s
Details
CI / Platform (Go) (pull_request) Successful in 11m20s
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Required
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 12s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 12s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
infra-sre
agent-dev-a
agent-dev-b
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
8 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1490
Delete Branch "test/canvas-theme-lib-coverage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?