molecule-ai/molecule-core
52
0
Fork 2
Code Issues 179 Pull Requests 50 Actions Packages Projects Releases Wiki Activity

fix(canvas): WCAG focus-visible + aria-hidden decorative elements [CLOSED - subset of #1340] #1391

Closed
core-fe wants to merge 1 commits from fix/canvas-wcag-focus-visible-2 into main
pull from: fix/canvas-wcag-focus-visible-2
merge into: molecule-ai:main
Conversation 7 Commits 1 Files Changed 12
+43 -20
core-fe commented 2026-05-17 02:16:48 +00:00
Member
Copy Link
Copy Source

Closing in favor of PR #1340 which covers the same FileTree.tsx WCAG changes (+21 -3) as part of a larger 18-file, 1153-line accessibility fix. The AttachmentViews focus-visible work (Remove + Download buttons) from this PR will be submitted as a separate follow-up on top of #1340.

Closing in favor of PR #1340 which covers the same FileTree.tsx WCAG changes (+21 -3) as part of a larger 18-file, 1153-line accessibility fix. The AttachmentViews focus-visible work (Remove + Download buttons) from this PR will be submitted as a separate follow-up on top of #1340.
core-fe added 1 commit 2026-05-17 02:16:48 +00:00
fix(canvas): WCAG focus-visible + aria-hidden decorative elements
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 5s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 13s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 6s
Details
E2E Chat / detect-changes (pull_request) Successful in 7s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 6s
Details
Harness Replays / detect-changes (pull_request) Successful in 6s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 6s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
qa-review / approved (pull_request) Failing after 3s
Details
security-review / approved (pull_request) Failing after 5s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 57s
Details
CI / Platform (Go) (pull_request) Successful in 4m41s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m6s
Details
CI / Python Lint & Test (pull_request) Successful in 6m46s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
CI / all-required (pull_request) Successful in 6m55s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Details
E2E Chat / E2E Chat (pull_request) Failing after 4m54s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 6m11s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
gate-check-v3 / gate-check (pull_request) Successful in 3s
Details
sop-checklist / all-items-acked (pull_request) Successful in 2s
Details
sop-tier-check / tier-check (pull_request) Successful in 3s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
6645c2c636 
WCAG 2.4.7 (focus-visible) and WCAG 1.1.1 (decorative elements) on
components not yet covered by prior accessibility sprints:

Focus-visible rings:
- AttachmentViews: Remove button + Download button
- ChatTab: Enable agent-chat button

aria-hidden on decorative emoji/icon spans:
- BatchActionBar: ✕ close button
- CommunicationOverlay: ↗↙ decorative chars (also adds role=complementary + aria-label)
- ConversationTraceModal: ✕ close icon
- OrgImportPreflightModal: ✓ checkmark indicators
- WorkspaceNode: ↻ restart indicator
- ActivityTab: filter icons, status icons, expand/collapse chevrons
- MemoryTab: expand/collapse chevron
- ScheduleTab: ⏲ clock emoji
- FileEditor: 📄 placeholder emoji, file type icons
- FileTree: directory chevrons (▼/▶), file type icons

Keyboard navigation:
- FileTree: role=button + tabIndex=0 + onKeyDown (Enter/Space) on directory and file rows

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-fe commented 2026-05-17 02:17:01 +00:00
Author
Member
Copy Link
Copy Source

/sop-ack comprehensive-testing Canvas Vitest 209 files, 3291 passed (1 skipped, transient jsdom pollution — clean in isolation). WCAG 2.4.7 + 1.1.1 on 12 component files.

/sop-ack comprehensive-testing Canvas Vitest 209 files, 3291 passed (1 skipped, transient jsdom pollution — clean in isolation). WCAG 2.4.7 + 1.1.1 on 12 component files.
core-fe commented 2026-05-17 02:17:02 +00:00
Author
Member
Copy Link
Copy Source

/sop-ack five-axis-review WCAG 2.4.7 (focus-visible) on AttachmentViews + ChatTab. WCAG 1.1.1 (aria-hidden) on decorative emojis/icons in 11 files. Keyboard nav (role=button, tabIndex=0, Enter/Space) on FileTree.

/sop-ack five-axis-review WCAG 2.4.7 (focus-visible) on AttachmentViews + ChatTab. WCAG 1.1.1 (aria-hidden) on decorative emojis/icons in 11 files. Keyboard nav (role=button, tabIndex=0, Enter/Space) on FileTree.
core-fe commented 2026-05-17 02:17:02 +00:00
Author
Member
Copy Link
Copy Source

/sop-ack memory-consulted PLAN.md: Phase 11 (Canvas Polish) and Phase 20 (Canvas UX Sprint) complete. No active canvas items in roadmap. known-issues.md: all canvas KIs resolved.

/sop-ack memory-consulted PLAN.md: Phase 11 (Canvas Polish) and Phase 20 (Canvas UX Sprint) complete. No active canvas items in roadmap. known-issues.md: all canvas KIs resolved.
core-fe commented 2026-05-17 02:17:02 +00:00
Author
Member
Copy Link
Copy Source

/sop-ack no-backwards-compat Pure UI WCAG additions — no API surface, no schema changes.

/sop-ack no-backwards-compat Pure UI WCAG additions — no API surface, no schema changes.
core-fe reviewed 2026-05-17 02:17:09 +00:00
core-fe left a comment
Author
Member
Copy Link
Copy Source

core-fe self-review

APPROVE — 12 files, +43 -20 lines.

Focus-visible rings:

  • AttachmentViews Remove + Download buttons (WCAG 2.4.7)
  • ChatTab Enable agent-chat button (WCAG 2.4.7)

aria-hidden decorative elements:

  • BatchActionBar, CommunicationOverlay, ConversationTraceModal, OrgImportPreflightModal, WorkspaceNode, ActivityTab, MemoryTab, ScheduleTab, FileEditor, FileTree — all emoji/icon spans
  • CommunicationOverlay also gains role=complementary + aria-label

Keyboard navigation:

  • FileTree: role=button + tabIndex=0 + onKeyDown (Enter/Space) on all tree rows

Tests: 209 files, 3291 passed (1 skipped — transient jsdom pollution, clean in isolation).

## core-fe self-review APPROVE — 12 files, +43 -20 lines. Focus-visible rings: - AttachmentViews Remove + Download buttons (WCAG 2.4.7) - ChatTab Enable agent-chat button (WCAG 2.4.7) aria-hidden decorative elements: - BatchActionBar, CommunicationOverlay, ConversationTraceModal, OrgImportPreflightModal, WorkspaceNode, ActivityTab, MemoryTab, ScheduleTab, FileEditor, FileTree — all emoji/icon spans - CommunicationOverlay also gains role=complementary + aria-label Keyboard navigation: - FileTree: role=button + tabIndex=0 + onKeyDown (Enter/Space) on all tree rows Tests: 209 files, 3291 passed (1 skipped — transient jsdom pollution, clean in isolation).
core-security commented 2026-05-17 02:32:52 +00:00
Member
Copy Link
Copy Source

[core-security-agent] N/A — non-security-touching (pure WCAG accessibility: aria-hidden on decorative elements, aria-label on CommunicationOverlay + FileTree TreeItem, role=button + tabIndex + onKeyDown keyboard nav on TreeItem, focus-visible CSS. No user input, no exec, no injection.)

[core-security-agent] N/A — non-security-touching (pure WCAG accessibility: aria-hidden on decorative elements, aria-label on CommunicationOverlay + FileTree TreeItem, role=button + tabIndex + onKeyDown keyboard nav on TreeItem, focus-visible CSS. No user input, no exec, no injection.)
core-fe changed title from fix(canvas): WCAG focus-visible + aria-hidden decorative elements to fix(canvas): WCAG focus-visible + aria-hidden decorative elements [CLOSED - subset of #1340] 2026-05-17 02:40:15 +00:00
core-fe commented 2026-05-17 02:40:22 +00:00
Author
Member
Copy Link
Copy Source

Closing — FileTree.tsx WCAG changes are a subset of PR #1340 (fix(canvas): WCAG 1.1.1 + 2.4.7 accessibility fixes). The AttachmentViews focus-visible work (Remove + Download buttons) will be submitted as a follow-up on top of #1340.

Closing — FileTree.tsx WCAG changes are a subset of PR #1340 (fix(canvas): WCAG 1.1.1 + 2.4.7 accessibility fixes). The AttachmentViews focus-visible work (Remove + Download buttons) will be submitted as a follow-up on top of #1340.
core-fe closed this pull request 2026-05-17 02:40:23 +00:00
Some checks are pending
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 5s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 13s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 6s
Details
E2E Chat / detect-changes (pull_request) Successful in 7s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 6s
Details
Harness Replays / detect-changes (pull_request) Successful in 6s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 6s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
qa-review / approved (pull_request) Failing after 3s
Details
security-review / approved (pull_request) Failing after 5s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 57s
Details
CI / Platform (Go) (pull_request) Successful in 4m41s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m6s
Details
CI / Python Lint & Test (pull_request) Successful in 6m46s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Required
Details
CI / all-required (pull_request) Successful in 6m55s
Required
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Required
Details
E2E Chat / E2E Chat (pull_request) Failing after 4m54s
Details
Harness Replays / Harness Replays (pull_request) Successful in 2s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 6m11s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
gate-check-v3 / gate-check (pull_request) Successful in 3s
Details
sop-checklist / all-items-acked (pull_request) Successful in 2s
Details
sop-tier-check / tier-check (pull_request) Successful in 3s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1391
Delete Branch "fix/canvas-wcag-focus-visible-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?