chore(runtime): remove crewai/deepagents/gemini-cli from the runtime catalog (internal#483) #1385

Merged

devops-engineer merged 2 commits from chore/remove-crewai-deepagents-gemini-cli into main 2026-05-16 22:48:51 +00:00

Conversation 7 Commits 2 Files Changed 9 +84 -38

2 Commits

Author	SHA1	Message	Date
core-devops	862a90a316	fix(runtime): complete crewai/deepagents/gemini-cli removal + fail-closed on unresolvable runtime ... Addresses core-security REQUEST-CHANGES (review 4269) on PR #1385 (RFC internal#483). The original removal was incomplete and silently changed behavior: 1. manifest.json workspace_templates still listed crewai/deepagents/ gemini-cli. handlers.knownRuntimes (the workspace-create admission allowlist) is built at boot from manifest.json via runtime_registry.go — NOT from provisioner.knownRuntimes — so a create request for a "removed" runtime was still admitted. Removed the 3 entries; the manifest now resolves to the 6 kept template-backed runtimes (claude-code, hermes, openclaw, codex, langgraph, autogen) + injected meta-runtimes. langgraph/autogen retained intentionally — not in the internal#483 removal set and still in provisioner.knownRuntimes. 2. selectImage silently fell back to DefaultImage (langgraph) for any named-but-unresolvable runtime: a user asking for crewai got a langgraph container with no signal. selectImage now returns (string, error) and rejects a NAMED-but-unresolvable runtime with ErrUnresolvableRuntime (naming the offending runtime). Start propagates it; the existing markProvisionFailed path already broadcasts WorkspaceProvisionFailed + records the message. Implements the CTO hardgate directive (feedback_platform_must_hardgate_base_contract — fail-closed, no silent degrade). The genuinely-unspecified (empty) runtime remains a distinct legitimate path → DefaultImage. go build ./... and go test ./internal/provisioner/ ./internal/handlers/ ./internal/imagewatch/ ./internal/registry/ ./internal/models/ all pass. selectImage tests updated to assert the new fail-closed contract (new expected values verified against the security finding, not made-green). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-16 15:36:16 -07:00
core-devops	e809a2e319	chore(runtime): remove crewai/deepagents/gemini-cli from the runtime catalog ... CTO-approved scope-narrowing to the four maintained runtimes (claude-code, openclaw, hermes, codex) plus autogen/langgraph legacy. RFC molecule-ai/internal#483. - provisioner/registry.go: drop the 3 from knownRuntimes (kept alphabetical ordering; count pin updated 9 -> 6 in registry_test.go). - handlers/admin_workspace_images.go: drop the 3 from AllRuntimes so imagewatch stops pulling now-removed template images. - models/runtime_defaults.go: doc-comment list updated; drop the 3 explicit drift-detection rows from runtime_defaults_test.go. - localbuild_test.go RepoNotFound fixture switched crewai -> hermes (post-removal crewai is no longer a known runtime, so the test would hit the "unknown runtime" branch instead of the intended 404 path). - provisioner_test.go error-classification fixture string crewai -> hermes (no removed-runtime names in fixtures). Live-workspace safety gate cleared first: zero workspaces on the 3 runtimes across the production fleet (per-tenant DB query on hongming/go-to-market/chloe-dong + CP tenant_resources provisioning ledger covering reno-stars). Registry/pin row removal handled by a separate controlplane migration PR, landed after this merges. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-16 15:17:26 -07:00