test(ci): kill absolute wall-clock perf assertions that false-red CI under host load #1381

Open
infra-sre wants to merge 4 commits from ci/timing-test-hygiene-host-load-internal into main

4 Commits

Author SHA1 Message Date
5d70b1faf8 Merge branch 'main' into ci/timing-test-hygiene-host-load-internal
Some checks failed
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
E2E Chat / E2E Chat (pull_request) Successful in 3s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2m6s
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 8s
CI / Detect changes (pull_request) Successful in 10s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 18s
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
E2E Chat / detect-changes (pull_request) Successful in 6s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 7s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 6s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m2s
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 5s
publish-runtime-autobump / pr-validate (pull_request) Successful in 26s
gate-check-v3 / gate-check (pull_request) Successful in 3s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
qa-review / approved (pull_request) Failing after 3s
security-review / approved (pull_request) Failing after 3s
sop-checklist / all-items-acked (pull_request) Failing after 4s
sop-tier-check / tier-check (pull_request) Successful in 7s
CI / Platform (Go) (pull_request) Successful in 6m10s
CI / Canvas (Next.js) (pull_request) Successful in 7m28s
CI / Python Lint & Test (pull_request) Successful in 6m43s
CI / all-required (pull_request) Successful in 6m40s
2026-05-17 17:21:14 +00:00
0d40f3fd78 trigger: re-run CI after SOP_TIER_CHECK_TOKEN provision
Some checks are pending
E2E API Smoke Test / detect-changes (pull_request) Successful in 5s
E2E Chat / detect-changes (pull_request) Successful in 6s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 6s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 3s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 2s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m13s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 53s
CI / Platform (Go) (pull_request) Successful in 4m33s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m10s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 53s
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 4s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 2s
gate-check-v3 / gate-check (pull_request) Successful in 2s
publish-runtime-autobump / pr-validate (pull_request) Successful in 27s
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-tier-check / tier-check (pull_request) Successful in 4s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m7s
CI / Canvas (Next.js) (pull_request) Successful in 6m14s
CI / Python Lint & Test (pull_request) Successful in 6m40s
CI / all-required (pull_request) Successful in 6m24s
E2E Chat / E2E Chat (pull_request) Successful in 2s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 1s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1m35s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
qa-review / approved (pull_request) N/A declared by core-devops; qa-review waived per sop-checklist config
security-review / approved (pull_request) N/A declared by core-devops; security-review waived per sop-checklist config
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 7/7
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-17 03:04:53 +00:00
4f466d6e8b ci: re-trigger after SOP_TIER_CHECK_TOKEN provision [skip ci]
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-17 02:43:06 +00:00
df897571c0 test(ci): replace absolute wall-clock perf assertions with structural ones
Some checks failed
CI / Detect changes (pull_request) Successful in 4s
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 2s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
E2E API Smoke Test / detect-changes (pull_request) Successful in 4s
E2E Chat / detect-changes (pull_request) Successful in 5s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 6s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 3s
publish-runtime-autobump / pr-validate (pull_request) Successful in 21s
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 4s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 2s
CI / Platform (Go) (pull_request) Successful in 4m33s
gate-check-v3 / gate-check (pull_request) Successful in 6s
qa-review / approved (pull_request) Failing after 3s
security-review / approved (pull_request) Failing after 2s
sop-tier-check / tier-check (pull_request) Successful in 3s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 49s
CI / Canvas (Next.js) (pull_request) Successful in 5m46s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1s
E2E Chat / E2E Chat (pull_request) Successful in 2s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 1s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1m39s
CI / Python Lint & Test (pull_request) Successful in 6m25s
CI / all-required (pull_request) Successful in 5m51s
sop-checklist / na-declarations (pull_request) N/A: (none)
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 7/7
Three tests asserted hard wall-clock bounds that double as perf gates,
silently encoding "the runner host is idle". Under CI contention they
false-red CI/all-required for unrelated PRs (motivating incident:
#190 / PR#1348 false-failed on a 1.6ms overshoot at host load ~107).

Rewritten to assert the load-invariant structural intent, not a magic
absolute second (not a threshold bump):
- test_batch_fetcher_runs_submitted_rows_concurrently:
  elapsed < serial_total * 0.6 (concurrency proven vs serial sum)
- test_batch_fetcher_close_after_timeout_does_not_block_on_running_workers:
  elapsed < BLOCK_SECS * 0.3 (vs worker self-unblock window)
- test_wait_returns_existing_head_immediately:
  elapsed < wait_timeout * 0.2 (vs configured timeout)

Host load scales the reference and the measurement together, so the
ratio remains a reliable discriminator while real regressions still
fail loudly. Validated passing under heavy simulated CPU contention.
Anti-pattern + lint-to-prevent-regrowth tracked in #1380.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-17 00:44:54 +00:00