fix(inbox): drop self-delegation-echo rows from inbox poller #1348

Merged

devops-engineer merged 7 commits from fix/inbox-self-echo into main 2026-05-16 21:09:20 +00:00

Conversation 18 Commits 7 Files Changed 4 +412 -25

7 Commits

Author	SHA1	Message	Date
devops-engineer	8b11368656	ci: rerun CI on healthy host (load-era timing flake, no code change) ... PR#1348 (#190 self-echo fix) sole red = test_batch_fetcher_runs_submitted_rows_concurrently in tests/test_inbox_uploads.py (2.6ms wall-clock overshoot, 0.2516s vs 0.25s) — a load-induced timing flake, NOT in this PR's changed code (workspace/inbox.py _is_self_echo_row). Host has recovered (load1 ~1.5, runner pool drained, throttle PR#72 live). Empty commit = the only CI-rerun mechanism on Gitea 1.22.6 (reference_empty_commit_is_only_rerun_mechanism_on_1_22_6). Same tree, no code change; CTO non-author-review waiver + mandatory retroactive core-security review apply to the new head unchanged. internal#469 / #190. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-16 14:00:07 -07:00
core-be	6bfc1c83ea	Merge origin/main into fix/inbox-self-echo (bring up to base, zero-conflict; #190 internal#469)	2026-05-16 12:53:09 -07:00
Molecule AI Core-BE	1549a9a2fd	ci: rerun — runner-host ENOSPC infra failure on af25019 (no code change) ... Run 57610 Canvas(Next.js)+Platform(Go) failed solely on runner-host disk exhaustion (ENOSPC / 'no space left on device' in /tmp/go-build* and node write). PR#1348 touches only Python (workspace/inbox.py + .gitea sop-checklist); zero Go/TSX. main HEAD is green on both jobs. Disk since reclaimed (74%/58G free). Empty commit = only Gitea 1.22.6 rerun mechanism. Tree unchanged from af25019.	2026-05-16 11:44:20 -07:00
Molecule AI Core-BE	af25019900	fix(inbox): add delegate_result exclusion to _is_self_echo_row ... RFC #2829 PR-2 regression fix: rows with method="delegate_result" are now excluded from the self-echo guard even when source_id matches our workspace_id. The platform may write a delegation-result row with our workspace_id as source_id (e.g. a self-delegation or edge case in the platform's result-writing path); such rows must reach the inbox so the runtime receives the delegation result. Fixes regression vs PR #1346 where this guard was present. Added test_is_self_echo_row_false_for_delegate_result regression pin. All 9 self-echo tests pass locally. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-16 13:31:30 +00:00
Molecule AI Core-BE	deeff950be	fix(inbox): drop self-delegation-echo rows from inbox poller ... Internal #469: when a workspace delegates to a target that never picks up the task, tool_delegate_task calls report_activity("a2a_receive", ...) which POSTs to the platform with source_id = the sender's workspace UUID (spoof- defense). The activity API exposes that row under type=a2a_receive, so the inbox poller re-fetches it and message_from_activity sets peer_id = the workspace's own UUID — the workspace sees its own delegation-failure echoed back as if a peer had delegated to it. Fix adds _is_self_echo_row(row, workspace_id) that returns True when source_id == workspace_id, mirroring the existing _is_self_notify_row pattern. The guard is wired into _poll_once after the self-notify check: self-echo rows are skipped from the queue, the cursor still advances, and the notification callback does not fire. The real delegate_result push path (delegate_result method) is unaffected. 8 new tests cover the predicate (same-workspace, different-workspace, None source, empty workspace_id, absent key) and the integrated poller behavior (skipped from queue, cursor advances, no notification). Live-repro confirmed on hongming.moleculesai.app prior to this fix. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-16 12:38:55 +00:00
Molecule AI Infra-SRE	50de2f6155	chore: re-trigger CI (infra-sre 09:47Z)	2026-05-16 09:47:45 +00:00
Molecule AI Core Platform Lead	3461b86cba	fix(sop-checklist): post na-declarations status for review-check.sh	2026-05-16 09:39:27 +00:00