molecule-ai/molecule-core
41
0
Fork 2
Code Issues 103 Pull Requests 140 Actions 191 Packages Projects Releases Wiki Activity

fix(inbox): drop self-delegation-echo bookkeeping rows from inbox poller #1346

Closed
core-devops wants to merge 2 commits from fix/a2a-self-delegation-echo-inbox into main
pull from: fix/a2a-self-delegation-echo-inbox
merge into: molecule-ai:main
Conversation 8 Commits 2 Files Changed 2 +199

2 Commits

Author SHA1 Message Date
devops-engineer
4baecebf8e Merge branch 'main' into fix/a2a-self-delegation-echo-inbox
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Waiting to run
Details
CI / Detect changes (pull_request) Waiting to run
Details
CI / Platform (Go) (pull_request) Waiting to run
Details
CI / Canvas (Next.js) (pull_request) Waiting to run
Details
CI / Shellcheck (E2E scripts) (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Waiting to run
Details
CI / all-required (pull_request) Waiting to run
Details
E2E API Smoke Test / detect-changes (pull_request) Waiting to run
Details
E2E Chat / detect-changes (pull_request) Waiting to run
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Waiting to run
Details
Handlers Postgres Integration / detect-changes (pull_request) Waiting to run
Details
audit-force-merge / audit (pull_request) Waiting to run
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Waiting to run
Details
publish-runtime-autobump / pr-validate (pull_request) Waiting to run
Details
publish-runtime-autobump / bump-and-tag (pull_request) Waiting to run
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Waiting to run
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Waiting to run
Details
gate-check-v3 / gate-check (pull_request) Waiting to run
Details
qa-review / approved (pull_request) Waiting to run
Details
security-review / approved (pull_request) Waiting to run
Details
sop-checklist / all-items-acked (pull_request) Waiting to run
Details
sop-tier-check / tier-check (pull_request) Waiting to run
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Has been cancelled
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Has been cancelled
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Has been cancelled
Details
CI / Canvas Deploy Reminder (pull_request) Has been cancelled
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Has been cancelled
Details
E2E Chat / E2E Chat (pull_request) Has been cancelled
Details
2026-05-16 13:03:54 +00:00
Molecule AI Core-DevOps
3bda7e1c07 fix(inbox): drop self-delegation-echo bookkeeping rows from inbox poller
Some checks failed
CI / Canvas Deploy Reminder (pull_request) Blocked by required conditions
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 9s
Details
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 17s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 26s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 25s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 26s
Details
E2E Chat / detect-changes (pull_request) Successful in 27s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 23s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 20s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 8s
Details
qa-review / approved (pull_request) Failing after 20s
Details
security-review / approved (pull_request) Failing after 21s
Details
sop-tier-check / tier-check (pull_request) Successful in 18s
Details
sop-checklist / all-items-acked (pull_request) Successful in 20s
Details
publish-runtime-autobump / pr-validate (pull_request) Successful in 51s
Details
gate-check-v3 / gate-check (pull_request) Successful in 33s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 15s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 14s
Details
E2E Chat / E2E Chat (pull_request) Successful in 51s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m34s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 3m22s
Details
CI / Python Lint & Test (pull_request) Successful in 7m52s
Details
CI / Canvas (Next.js) (pull_request) Successful in 22m40s
Details
CI / Platform (Go) (pull_request) Successful in 23m33s
Details
CI / all-required (pull_request) Successful in 24m11s
Details 
A workspace delegating to a target that never picks up the task hits
the 300s polling timeout; tool_delegate_task then reports the outcome
via a2a_tools.report_activity("a2a_receive", ...), which POSTs an
activity_type='a2a_receive' row to /workspaces/<self>/activity with
source_id=WORKSPACE_ID (its own id — mandated by the workspace-server's
source_id spoof-defense, activity.go:549) and method='message/send'.

The workspace's own inbox poller then re-fetches that row from
?type=a2a_receive; message_from_activity sets peer_id=source_id
(non-empty) so to_dict classifies it kind=peer_agent, registry-resolved
to the workspace's own display name ("mac laptop"). The agent sees its
own delegation-failure echoed back as if a peer delegated to it
(confirmed live on hongming.moleculesai.app 2026-05-16).

This is NOT a self-delegation (the platform + agent self-delegation
guards are correct and fire on source==target — the real target here
was a different workspace that legitimately timed out). The producer
side is also correct by platform contract (report_activity MUST send
source_id=WORKSPACE_ID). The defect is the inbox poller mis-classifying
a self-originated bookkeeping row as an inbound peer message — the same
class as the already-fixed self-notify echo, slipping through because
it uses method='message/send' + non-empty self source_id.

Fix at the correct layer (the consumer): add inbox._is_self_echo_row
and skip+advance-cursor for any a2a_receive row whose source_id equals
the polled workspace_id, mirroring _is_self_notify_row exactly. A
genuine inbound peer always has source_id != polled workspace_id
(self-delegation is blocked upstream by two guards). RFC #2829 PR-2
delegation-result pushes (method='delegate_result', source_id==self)
are explicitly preserved so the durable async result-delivery path
keeps working.

Tests: 8 new tests (predicate + integrated _poll_once skip/cursor +
delegate_result preservation). test_inbox.py 62/62 green; related
delegation/a2a suites 48/48 green; zero regression.

Refs: molecule-ai/internal#469

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
 2026-05-16 05:30:46 -07:00