ci(workflows): consolidate issue_comment subscribers — sop-checklist + review-refire (issue #1280) #1333

Open
infra-sre wants to merge 6 commits from sre/comment-dispatch-consolidation-v2 into main

6 Commits

Author SHA1 Message Date
834eb29508 trigger: re-run gate-check-v3 after stale REQUEST_CHANGES review dismissed
Some checks failed
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Has been skipped
Handlers Postgres Integration / detect-changes (pull_request) Successful in 2s
Harness Replays / detect-changes (pull_request) Successful in 3s
CI / Platform (Go) (pull_request) Successful in 4m29s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 2s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m4s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 55s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m12s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 53s
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 3s
publish-runtime-autobump / pr-validate (pull_request) Successful in 21s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s
CI / Canvas (Next.js) (pull_request) Successful in 5m55s
gate-check-v3 / gate-check (pull_request) Successful in 3s
qa-review / approved (pull_request) Failing after 3s
security-review / approved (pull_request) Failing after 3s
sop-checklist / all-items-acked (pull_request) Failing after 2s
sop-tier-check / tier-check (pull_request) Successful in 3s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m0s
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 55s
CI / Python Lint & Test (pull_request) Successful in 6m28s
CI / all-required (pull_request) Successful in 5m21s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Harness Replays / Harness Replays (pull_request) Successful in 1s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 44s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m20s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1m40s
E2E Chat / E2E Chat (pull_request) Failing after 4m13s
Stale review id=4198 (core-devops, SHA d132b5df) has been dismissed.
Pushing to re-trigger gate-check-v3 CI status on HEAD a6814bc5.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-16 23:12:16 +00:00
a6814bc574 trigger: re-run gate-check-v3 after runner recovery
Some checks failed
E2E API Smoke Test / detect-changes (pull_request) Successful in 4s
E2E Chat / detect-changes (pull_request) Successful in 5s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 7s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 4s
CI / Platform (Go) (pull_request) Successful in 4m40s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 2s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 1m4s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 51s
CI / Canvas (Next.js) (pull_request) Successful in 5m53s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m8s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 57s
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
publish-runtime-autobump / pr-validate (pull_request) Successful in 25s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 5s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s
gate-check-v3 / gate-check (pull_request) Failing after 3s
qa-review / approved (pull_request) Failing after 4s
security-review / approved (pull_request) Failing after 3s
sop-tier-check / tier-check (pull_request) Successful in 3s
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 59s
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 58s
CI / Python Lint & Test (pull_request) Successful in 6m36s
CI / all-required (pull_request) Successful in 4m34s
sop-checklist / all-items-acked (pull_request) acked: 7/7
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1s
E2E Chat / E2E Chat (pull_request) Successful in 2s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1m43s
2026-05-16 21:24:06 +00:00
1e26408997 fix(sop-checklist): use SOP_TIER_CHECK_TOKEN for review-refire job
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 22s
CI / Detect changes (pull_request) Successful in 31s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 45s
E2E API Smoke Test / detect-changes (pull_request) Successful in 31s
E2E Chat / detect-changes (pull_request) Successful in 33s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 25s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 25s
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 22s
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Successful in 2m23s
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m54s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m43s
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 2m3s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 49s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 17s
gate-check-v3 / gate-check (pull_request) Failing after 1m0s
qa-review / approved (pull_request) Failing after 48s
security-review / approved (pull_request) Failing after 23s
sop-checklist / all-items-acked (pull_request) Successful in 25s
CI / Python Lint & Test (pull_request) Successful in 8m12s
sop-tier-check / tier-check (pull_request) Successful in 21s
CI / Canvas (Next.js) (pull_request) Successful in 22m15s
CI / Platform (Go) (pull_request) Successful in 24m41s
CI / all-required (pull_request) Successful in 24m7s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 16s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 15s
E2E Chat / E2E Chat (pull_request) Successful in 16s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 14s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 23s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
The review-refire job's qa-review and security-review refire steps were
using RFC_324_TEAM_READ_TOKEN which has read-only scope. review-refire-status.sh
POSTs to /repos/{owner}/{repo}/statuses/{sha} — requires write scope.

Same fix that PR #1366 applied to review-refire-comments.yml lines 73 and 90.
SOP_TIER_CHECK_TOKEN carries write:repository + write:issue + read:organization
and satisfies all required teams (qa, security, managers, engineers, ceo).

Reported by core-devops-agent review comments on PR #1333.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-16 19:18:02 +00:00
f8b160c768 fix(review-refire-comments): eliminate duplicate steps block causing YAML error
The consolidation commit (PR #1333) attempted to convert this workflow
into a no-op stub by adding a deprecation step, but left the original
dispatch steps in place — producing two `runs-on:` and two `steps:`
blocks under the `dispatch` job. YAML allowed this (merging the duplicate
`steps:` keys) so it parsed silently, but the original refire logic
still ran, defeating the entire purpose of the deprecation stub.

Fix: replace the file with a clean 39-line no-op stub that emits a
warning and exits immediately. All refire logic lives in
sop-checklist.yml review-refire job per issue #1280.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-16 19:18:02 +00:00
5b3e86a0dd fix(sop-checklist): add bp-exempt directive to review-refire job
The new review-refire job (added by PR #1333 consolidation per issue #1280)
emits qa-review and security-review status contexts but was missing the
required # bp-exempt: directive comment, causing lint-required-context-exists-in-bp
to fail on PR #1333.

The review-refire job is informational-only (not a merge gate) — it posts
status updates on /qa-recheck et al slash commands. Marking it bp-exempt
correctly reflects its non-blocking nature per RFC#351 §Tier-awareness.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-16 19:18:02 +00:00
862f75e3a6 ci(workflows): consolidate issue_comment subscribers — sop-checklist + review-refire (issue #1280)
Merge review-refire-comments.yml logic into sop-checklist.yml as the
`review-refire` job. Before: 2 workflows subscribed to issue_comment,
causing Gitea to queue 2 runner-assigned runs per comment
(~650 no-op runs/day, ~1,300 runner-slot-occupancy-hours/day).
After: 1 workflow, 1 issue_comment subscription, ~50% reduction.

Changes:
- sop-checklist.yml: add `review-refire` job with if: guard for
  /qa-recheck, /security-recheck, /refire-tier-check commands
- review-refire-comments.yml: deprecate, convert to no-op stub
  (will be deleted in follow-up PR after sop-checklist.yml lands)

Sequencing: review-refire-comments.yml kept as stub during transition
to avoid refire gap. Will be deleted after consolidation is confirmed.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-16 19:18:02 +00:00