fix(sop-checklist): implement /sop-n/a N/A declarations for qa/sec gates (mc#1111) #1196

Closed
core-devops wants to merge 1 commits from infra/staging-sop-na-fix into staging

1 Commits

Author SHA1 Message Date
c9c9bd2498 fix(sop-checklist): implement /sop-n/a N/A declarations for qa/sec gates
Some checks failed
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
CI / Shellcheck (E2E scripts) (pull_request) Blocked by required conditions
CI / Canvas Deploy Reminder (pull_request) Blocked by required conditions
CI / Python Lint & Test (pull_request) Blocked by required conditions
CI / all-required (pull_request) Blocked by required conditions
E2E API Smoke Test / E2E API Smoke Test (pull_request) Blocked by required conditions
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Blocked by required conditions
CI / Platform (Go) (pull_request) Failing after 7m10s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Blocked by required conditions
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 5s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 12s
CI / Canvas (Next.js) (pull_request) Successful in 8m48s
security-review / approved (pull_request) Successful in 16s
gate-check-v3 / gate-check (pull_request) Successful in 16s
qa-review / approved (pull_request) Successful in 17s
sop-tier-check / tier-check (pull_request) Successful in 16s
CI / Detect changes (pull_request) Successful in 27s
E2E API Smoke Test / detect-changes (pull_request) Successful in 27s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 27s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 28s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m3s
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m8s
audit-force-merge / audit (pull_request) Has been skipped
Cherry-pick of N/A implementation from PR #1192 (infra/sop-n-a-plus-drift-fix).
Adds:
  - parse_directives() now returns (directives, na_directives) tuple
  - _NA_DIRECTIVE_RE regex for /sop-n/a <gate> [reason] parsing
  - compute_na_state() evaluates N/A declarations with team-membership check
  - Posts 'sop-checklist / na-declarations (pull_request)' status
  - review-check.sh reads this status to waive qa-review/security-review
    APPROVE requirement when N/A is declared by a team member

This unblocks PRs #1158 and #1159 which have valid /sop-n/a
comments from core-lead/infra-lead but were failing qa/sec gates.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-15 14:46:46 +00:00