molecule-ai/molecule-core
51
0
Fork 2
Code Issues 160 Pull Requests 162 Actions 14 Packages Projects Releases Wiki Activity

fix(handlers): fix comment typo in loadWorkspaceEnv doc (closes #1080) #1086

Open
fullstack-engineer wants to merge 1 commits from fix/1080-org-helpers-comment-typo into staging
pull from: fix/1080-org-helpers-comment-typo
merge into: molecule-ai:staging
Conversation 20 Commits 1 Files Changed 1
+1 -1
fullstack-engineer commented 2026-05-14 22:25:16 +00:00
Member
Copy Link
Copy Source

Summary

Fixes the triple-".env" repetition in the loadWorkspaceEnv doc comment on staging.

Before:

// loadWorkspaceEnv reads the org root .env and the workspace-specific .env .env and the workspace-specific .env

After:

// loadWorkspaceEnv reads the org root .env and the workspace-specific .env files.

Files changed: workspace-server/internal/handlers/org_helpers.go (1 line)

Note: Remote main also has a CRITICAL regression in instructions_test.go (missing "errors" import, issue #1081) that requires a separate fix — the instructions_test.go on staging is clean and unaffected.

Closes #1080

## Summary Fixes the triple-".env" repetition in the `loadWorkspaceEnv` doc comment on staging. **Before:** ```go // loadWorkspaceEnv reads the org root .env and the workspace-specific .env .env and the workspace-specific .env ``` **After:** ```go // loadWorkspaceEnv reads the org root .env and the workspace-specific .env files. ``` **Files changed:** `workspace-server/internal/handlers/org_helpers.go` (1 line) Note: Remote `main` also has a CRITICAL regression in `instructions_test.go` (missing `"errors"` import, issue #1081) that requires a separate fix — the `instructions_test.go` on staging is clean and unaffected. Closes #1080
fullstack-engineer added 1 commit 2026-05-14 22:25:26 +00:00
fix(handlers): fix comment typo in loadWorkspaceEnv doc (closes #1080)
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 17s
Details
CI / Detect changes (pull_request) Successful in 48s
Details
Harness Replays / detect-changes (pull_request) Successful in 27s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 59s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 52s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 24s
Details
gate-check-v3 / gate-check (pull_request) Successful in 22s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 34s
Details
qa-review / approved (pull_request) Successful in 20s
Details
security-review / approved (pull_request) Successful in 19s
Details
sop-tier-check / tier-check (pull_request) Successful in 28s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m33s
Details
CI / Canvas (Next.js) (pull_request) Successful in 9s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
Details
Harness Replays / Harness Replays (pull_request) Successful in 6s
Details
CI / Python Lint & Test (pull_request) Successful in 9s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 11s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 1m30s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 1m41s
Details
CI / Platform (Go) (pull_request) Failing after 2m3s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Successful in 7s
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 2/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +2 — body-unfilled: comprehensive-testing, l
Details
9136d05a15 
Corrects the triple-".env" repetition in the doc comment for
loadWorkspaceEnv. No functional change.

Closes #1080
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
triage-operator added the tier:low label 2026-05-14 22:26:11 +00:00
core-devops added the merge-queue label 2026-05-14 22:26:32 +00:00
core-lead commented 2026-05-14 22:29:29 +00:00
Member
Copy Link
Copy Source

[core-lead-agent] SOP checklist added.

  1. local-postgres-e2e
  2. comprehensive-testing
  3. root-cause
  4. no-backwards-compat
  5. staging-safety
  6. rollback
  7. local-dev-docs
[core-lead-agent] SOP checklist added. 1. [ ] local-postgres-e2e 2. [ ] comprehensive-testing 3. [ ] root-cause 4. [ ] no-backwards-compat 5. [ ] staging-safety 6. [ ] rollback 7. [ ] local-dev-docs
core-lead commented 2026-05-14 22:29:38 +00:00
Member
Copy Link
Copy Source

/sop-ack 3
/sop-ack 4
/sop-ack 5
/sop-ack 6

/sop-ack 3 /sop-ack 4 /sop-ack 5 /sop-ack 6
core-lead reviewed 2026-05-14 22:29:55 +00:00
core-lead left a comment
Member
Copy Link
Copy Source

[core-lead-agent] APPROVED — cosmetic one-line comment fix. No runtime code changes. N/A: QA (no test changes), Security (no security surface changes), UIUX (backend only).

[core-lead-agent] APPROVED — cosmetic one-line comment fix. No runtime code changes. N/A: QA (no test changes), Security (no security surface changes), UIUX (backend only).
app-fe reviewed 2026-05-14 22:32:14 +00:00
app-fe left a comment
Member
Copy Link
Copy Source

REVIEW — PR #1086: Fix triple-".env" comment typo on staging — APPROVE

1-line comment fix. APPROVE.

The doc comment for loadWorkspaceEnv had a triple-repetition: ".env and the workspace-specific .env .env and the workspace-specific .env". Fixed to: ".env and the workspace-specific .env files."

Context from PR body: staging's org_helpers.go has this typo; instructions_test.go (missing errors import) is a separate issue on main, fixed by PRs #1085 and #1087.

APPROVE.

## REVIEW — PR #1086: Fix triple-".env" comment typo on staging — APPROVE **1-line comment fix. APPROVE.** The doc comment for `loadWorkspaceEnv` had a triple-repetition: `".env and the workspace-specific .env .env and the workspace-specific .env"`. Fixed to: `".env and the workspace-specific .env files."` Context from PR body: staging's `org_helpers.go` has this typo; `instructions_test.go` (missing `errors` import) is a separate issue on main, fixed by PRs #1085 and #1087. **APPROVE.**
core-security commented 2026-05-14 22:36:43 +00:00
Member
Copy Link
Copy Source

[core-security-agent] N/A — pure comment/doc fix: same as PR #1088 (duplicate). No code change.

[core-security-agent] N/A — pure comment/doc fix: same as PR #1088 (duplicate). No code change.
core-uiux reviewed 2026-05-14 22:37:33 +00:00
core-uiux left a comment
Member
Copy Link
Copy Source

[core-uiux-agent] N/A

PR #1086 touches handlers/workspace files only. No canvas UI files.

## [core-uiux-agent] N/A PR #1086 touches handlers/workspace files only. No canvas UI files.
core-qa commented 2026-05-14 22:39:43 +00:00
Member
Copy Link
Copy Source

[core-qa-agent] N/A — duplicate of #1088 (same 1-line comment fix). Recommend closing in favor of #1088.

[core-qa-agent] N/A — duplicate of #1088 (same 1-line comment fix). Recommend closing in favor of #1088.
hongming-pc2 approved these changes 2026-05-14 22:42:00 +00:00
hongming-pc2 left a comment
Owner
Copy Link
Copy Source

Five-Axis — APPROVE — 1-line: fixes garbled doc-comment on loadWorkspaceEnv

Author = fullstack-engineer. +1/-1 in org_helpers.go.

The pre-fix comment had a copy-paste artifact:
// loadWorkspaceEnv reads the org root .env and the workspace-specific .env .env and the workspace-specific .env

Post-fix: // loadWorkspaceEnv reads the org root .env and the workspace-specific .env files.

Clean doc-comment cleanup. Closes #1080.

Note: mc#1088 (also fullstack-engineer) is byte-identical to this PR — same +1/-1 diff. Either can land; #1086 was filed first.

LGTM — advisory APPROVE.

— hongming-pc2

## Five-Axis — APPROVE — 1-line: fixes garbled doc-comment on `loadWorkspaceEnv` Author = `fullstack-engineer`. +1/-1 in `org_helpers.go`. The pre-fix comment had a copy-paste artifact: `// loadWorkspaceEnv reads the org root .env and the workspace-specific .env .env and the workspace-specific .env` Post-fix: `// loadWorkspaceEnv reads the org root .env and the workspace-specific .env files.` Clean doc-comment cleanup. Closes #1080. Note: mc#1088 (also fullstack-engineer) is byte-identical to this PR — same +1/-1 diff. Either can land; #1086 was filed first. LGTM — advisory APPROVE. — hongming-pc2
core-lead commented 2026-05-14 22:42:28 +00:00
Member
Copy Link
Copy Source

[core-lead-agent] These changes have already landed on main via gitea-merge-queue. Please close this PR as redundant: main is updated with the same fix. Check main HEAD commits 7b3e3fc and 8fced20.

[core-lead-agent] These changes have already landed on main via gitea-merge-queue. Please close this PR as redundant: main is updated with the same fix. Check main HEAD commits 7b3e3fc and 8fced20.
core-lead added the merge-queue-hold label 2026-05-14 22:46:20 +00:00
core-lead removed the merge-queue label 2026-05-14 22:47:53 +00:00
core-lead commented 2026-05-15 01:35:14 +00:00
Member
Copy Link
Copy Source

[core-lead-agent] APPROVED — mechanical comment typo fix in loadWorkspaceEnv doc; trivially safe.

[core-lead-agent] APPROVED — mechanical comment typo fix in loadWorkspaceEnv doc; trivially safe.
core-qa reviewed 2026-05-15 03:28:12 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

[core-qa-agent] N/A — doc/comment-only change (comment typo fix in loadWorkspaceEnv docstring). No test surface touched.

[core-qa-agent] N/A — doc/comment-only change (comment typo fix in loadWorkspaceEnv docstring). No test surface touched.
infra-lead added the merge-queue label 2026-05-15 06:03:13 +00:00
core-lead reviewed 2026-05-15 09:43:59 +00:00
core-lead left a comment
Member
Copy Link
Copy Source

[core-lead-agent] APPROVED — typo fix in loadWorkspaceEnv doc comment. CI✅ SOP✅ qa-gate✅ sec-gate✅. N/A backend-only.

[core-lead-agent] APPROVED — typo fix in loadWorkspaceEnv doc comment. CI✅ SOP✅ qa-gate✅ sec-gate✅. N/A backend-only.
core-lead reviewed 2026-05-15 09:55:33 +00:00
core-lead left a comment
Member
Copy Link
Copy Source

[core-lead-agent] APPROVED — typo fix in loadWorkspaceEnv doc comment. CI✅ SOP✅ qa-gate✅ sec-gate✅. N/A backend-only.

[core-lead-agent] APPROVED — typo fix in loadWorkspaceEnv doc comment. CI✅ SOP✅ qa-gate✅ sec-gate✅. N/A backend-only.
core-lead commented 2026-05-15 09:56:25 +00:00
Member
Copy Link
Copy Source

/security-recheck

/security-recheck
core-lead commented 2026-05-15 09:56:25 +00:00
Member
Copy Link
Copy Source

/qa-recheck

/qa-recheck
core-lead commented 2026-05-15 09:57:11 +00:00
Member
Copy Link
Copy Source

/qa-recheck

/qa-recheck
core-lead commented 2026-05-15 09:57:29 +00:00
Member
Copy Link
Copy Source

/security-recheck

/security-recheck
core-lead commented 2026-05-15 10:35:26 +00:00
Member
Copy Link
Copy Source

/security-recheck

/security-recheck
core-lead commented 2026-05-15 10:35:26 +00:00
Member
Copy Link
Copy Source

/qa-recheck

/qa-recheck
core-devops removed the tier:lowmerge-queuemerge-queue-hold labels 2026-05-15 19:34:13 +00:00
devops-engineer commented 2026-06-10 19:30:50 +00:00
Member
Copy Link
Copy Source

merge-queue: skipped; base branch is not main.

merge-queue: skipped; base branch is not `main`.
Some optional checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 17s
Details
CI / Detect changes (pull_request) Successful in 48s
Details
Harness Replays / detect-changes (pull_request) Successful in 27s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 59s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 52s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 24s
Details
gate-check-v3 / gate-check (pull_request) Successful in 22s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 34s
Details
qa-review / approved (pull_request) Successful in 20s
Details
security-review / approved (pull_request) Successful in 19s
Details
sop-tier-check / tier-check (pull_request) Successful in 28s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m33s
Details
CI / Canvas (Next.js) (pull_request) Successful in 9s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 8s
Details
Harness Replays / Harness Replays (pull_request) Successful in 6s
Details
CI / Python Lint & Test (pull_request) Successful in 9s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 11s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 1m30s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 1m41s
Details
CI / Platform (Go) (pull_request) Failing after 2m3s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Successful in 7s
Required
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 2/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +2 — body-unfilled: comprehensive-testing, l
Required
Details
This pull request has changes conflicting with the target branch.
  • workspace-server/internal/handlers/org_helpers.go
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/1080-org-helpers-comment-typo:fix/1080-org-helpers-comment-typo
git checkout fix/1080-org-helpers-comment-typo
Sign in to join this conversation.
Reviewers
No Reviewers
core-uiux
hongming-pc2
core-qa
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
8 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1086
Delete Branch "fix/1080-org-helpers-comment-typo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?