molecule-ai/molecule-core

fix(handlers): add rows.Err() checks after all secrets scan loops #1039

Merged

devops-engineer merged 1 commits from fix/secrets-rows-err-check into main

2026-05-14 16:26:26 +00:00

Author	SHA1	Message	Date
Molecule AI Core-BE	420c42a202	fix(handlers): add rows.Err() checks after all secrets scan loops Some checks failed Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 11s Details Harness Replays / detect-changes (pull_request) Successful in 12s Details Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 11s Details CI / Detect changes (pull_request) Successful in 26s Details qa-review / approved (pull_request) Successful in 18s Details E2E API Smoke Test / detect-changes (pull_request) Successful in 28s Details Handlers Postgres Integration / detect-changes (pull_request) Successful in 26s Details E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 27s Details security-review / approved (pull_request) Successful in 20s Details Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 26s Details Harness Replays / Harness Replays (pull_request) Successful in 7s Details CI / Shellcheck (E2E scripts) (pull_request) Successful in 10s Details CI / Python Lint & Test (pull_request) Successful in 9s Details CI / Canvas (Next.js) (pull_request) Successful in 13s Details Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 7s Details E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 10s Details lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m14s Details Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 1m22s Details CI / Canvas Deploy Reminder (pull_request) Has been skipped Details E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m57s Details CI / Platform (Go) (pull_request) Failing after 3m7s Details CI / all-required (pull_request) Successful in 5s Details sop-checklist / na-declarations (pull_request) N/A: qa-review Details sop-tier-check / tier-check (pull_request) Successful in 19s Details gate-check-v3 / gate-check (pull_request) Successful in 28s Details sop-checklist / all-items-acked (pull_request) Successful in 25s Details audit-force-merge / audit (pull_request) Successful in 24s Details Regression from audit #109: rows.Err() checks were removed from List, ListGlobal, restartAllAffectedByGlobalKey, and Values between commits `3a30b073` and `b25b4fb6`. Without these checks, a mid-stream query error (e.g. connection loss during iteration) is silently ignored and partial results are returned as if the query succeeded. Fix: add if err := rows.Err(); err != nil { log.Printf(...) } after every for rows.Next() loop in secrets.go. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-14 09:17:31 -07:00