molecule-ai/molecule-core
41
0
Fork 2
Code Issues 67 Pull Requests 42 Actions 295 Packages Projects Releases Wiki Activity

fix(handlers): add rows.Err() checks after all secrets scan loops #1036

Closed
core-be wants to merge 1 commits from fix/secrets-rows-err-check into main
pull from: fix/secrets-rows-err-check
merge into: molecule-ai:main
Conversation 6 Commits 1 Files Changed 1 +18

1 Commits

Author SHA1 Message Date
Molecule AI Core-BE
6ab4a7791a fix(handlers): add rows.Err() checks after all secrets scan loops
Some checks failed
Harness Replays / detect-changes (pull_request) Successful in 22s
Details
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
Details
Harness Replays / Harness Replays (pull_request) Successful in 10s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 26s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m38s
Details
CI / Detect changes (pull_request) Successful in 1m51s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m44s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 23s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m45s
Details
gate-check-v3 / gate-check (pull_request) Successful in 42s
Details
qa-review / approved (pull_request) Failing after 32s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m34s
Details
security-review / approved (pull_request) Failing after 27s
Details
sop-checklist / all-items-acked (pull_request) Successful in 31s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m12s
Details
sop-tier-check / tier-check (pull_request) Successful in 23s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 10s
Details
CI / Canvas (Next.js) (pull_request) Successful in 11s
Details
CI / Python Lint & Test (pull_request) Successful in 9s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 10s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 6s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m59s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / Platform (Go) (pull_request) Failing after 3m56s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 3m44s
Details
CI / all-required (pull_request) Successful in 9s
Details 
Regression from audit #109: rows.Err() checks were removed from List,
ListGlobal, restartAllAffectedByGlobalKey, and Values between commits
3a30b073 and b25b4fb6. Without these checks, a mid-stream query error
(e.g. connection loss during iteration) is silently ignored and partial
results are returned as if the query succeeded.

Fix: add if err := rows.Err(); err != nil { log.Printf(...) } after
every for rows.Next() loop in secrets.go.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-14 15:07:44 +00:00