fix(canvas): remove invalid CSS child-combinator from ThemeToggle querySelectorAll (closes #1008) #1012
Merged
devops-engineer
merged 1 commits from 2026-05-14 13:53:06 +00:00
fix/1008-themetoggle-css-selector into staging
1 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
| d5e362690f |
fix(canvas): remove invalid CSS child-combinator from ThemeToggle querySelectorAll (closes #1008)
Some checks are pending
sop-checklist / all-items-acked (pull_request) All items acked
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 18s
Harness Replays / detect-changes (pull_request) Successful in 17s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 18s
gate-check-v3 / gate-check (pull_request) Successful in 24s
qa-review / approved (pull_request) Successful in 26s
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m4s
CI / Detect changes (pull_request) Successful in 1m5s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m6s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m1s
security-review / approved (pull_request) Successful in 22s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m32s
Harness Replays / Harness Replays (pull_request) Successful in 7s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 11s
CI / Platform (Go) (pull_request) Successful in 11s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 12s
CI / Python Lint & Test (pull_request) Successful in 11s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 14s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 12s
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
CI / Canvas (Next.js) (pull_request) Successful in 14m50s
CI / all-required (pull_request) Successful in 6s
CI / Canvas Deploy Reminder (pull_request) Successful in 9s
audit-force-merge / audit (pull_request) Successful in 12s
The `> [role=radio]` selector is malformed — the `>` combinator requires a parent selector to its left. In a browser, element.querySelectorAll() accepts this implicitly but jsdom's parser rejects it with: SyntaxError: Invalid selector > [role=radio] This caused 5 uncaught exceptions per test run in ThemeToggle.test.tsx. Fix: remove the `>` since the query is already scoped to radiogroup. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> |
