test(handlers): add InstructionsHandler coverage — 18 sqlmock cases #1005
Merged
devops-engineer
merged 1 commits from 2026-05-14 13:58:34 +00:00
test/instructions-handler-coverage into main
1 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
| f417c1a870 |
test(handlers): add InstructionsHandler coverage — 18 cases
Some checks failed
sop-checklist / all-items-acked (pull_request) All items acked
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 19s
CI / Detect changes (pull_request) Successful in 41s
E2E API Smoke Test / detect-changes (pull_request) Successful in 46s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 42s
Harness Replays / detect-changes (pull_request) Successful in 17s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 41s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 19s
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
qa-review / approved (pull_request) Successful in 21s
gate-check-v3 / gate-check (pull_request) Successful in 33s
security-review / approved (pull_request) Failing after 19s
sop-tier-check / tier-check (pull_request) Successful in 18s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 44s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 16s
CI / Python Lint & Test (pull_request) Successful in 15s
CI / Canvas (Next.js) (pull_request) Successful in 17s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 9s
Harness Replays / Harness Replays (pull_request) Successful in 8s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 11s
CI / Canvas Deploy Reminder (pull_request) Successful in 10s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m18s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 56s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m32s
CI / Platform (Go) (pull_request) Failing after 2m51s
CI / all-required (pull_request) Successful in 7s
audit-force-merge / audit (pull_request) Successful in 19s
Add sqlmock unit tests for InstructionsHandler (instructions.go): - List: empty result, scope filter, workspace_id filter, DB error - Create: success (global), success (workspace with scope_target), invalid scope, workspace scope missing scope_target, content too long (>8192), title too long (>200) - Update: success, not found (0 rows), content too long, title too long - Delete: success, not found (0 rows) - Resolve: empty workspace, with global+workspace instructions, missing workspace_id - scanInstructions: rows.Err() handled gracefully (continues, not fatal) All 18 tests cover the DB query paths using sqlmock. |
