molecule-ai/molecule-core
51
0
Fork 2
Code Issues 159 Pull Requests 161 Actions 8 Packages Projects Releases Wiki Activity

fix(ci): skip github.ref-gated jobs in ci_job_names (mc#958 mc#959) #1004

Closed
core-devops wants to merge 1 commits from fix/ci-required-drift-github-ref-skip into main
pull from: fix/ci-required-drift-github-ref-skip
merge into: molecule-ai:main
Conversation 2 Commits 1 Files Changed 1
+14 -6
core-devops commented 2026-05-14 13:00:08 +00:00
Member
Copy Link
Copy Source

Summary

Adds github.ref as a skip condition in ci_job_names(), matching the
existing github.event_name skip. Jobs gated on github.ref (e.g.
canvas-deploy-reminder: only runs on pushes to refs/heads/main) never
execute in a PR context, so flagging them as missing from
all-required.needs: is a false positive that triggers mc#958/mc#959.

Changes

  • .gitea/scripts/ci-required-drift.py: extend ci_job_names() skip
    condition to also ignore jobs whose if: gates on github.ref

Test plan

Run the drift script locally against current ci.yml — canvas-deploy-reminder
should NOT appear in the F1 report once this lands.

python3 .gitea/scripts/ci-required-drift.py
# Before: F1 includes canvas-deploy-reminder (false positive)
# After:  F1 is clean

Related

  • mc#958: [ci-drift] main required-checks divergence detected
  • mc#959: [ci-drift] staging required-checks divergence detected
  • Supersedes the ci-required-drift portion of PR #991 (which is 159 commits
    behind main and also contains unrelated handler-test additions)

🤖 Generated with Claude Code

## Summary Adds `github.ref` as a skip condition in `ci_job_names()`, matching the existing `github.event_name` skip. Jobs gated on `github.ref` (e.g. `canvas-deploy-reminder`: only runs on pushes to `refs/heads/main`) never execute in a PR context, so flagging them as missing from `all-required.needs:` is a false positive that triggers mc#958/mc#959. ## Changes - `.gitea/scripts/ci-required-drift.py`: extend `ci_job_names()` skip condition to also ignore jobs whose `if:` gates on `github.ref` ## Test plan Run the drift script locally against current ci.yml — `canvas-deploy-reminder` should NOT appear in the F1 report once this lands. ```bash python3 .gitea/scripts/ci-required-drift.py # Before: F1 includes canvas-deploy-reminder (false positive) # After: F1 is clean ``` ## Related - mc#958: [ci-drift] main required-checks divergence detected - mc#959: [ci-drift] staging required-checks divergence detected - Supersedes the ci-required-drift portion of PR #991 (which is 159 commits behind main and also contains unrelated handler-test additions) 🤖 Generated with [Claude Code](https://claude.ai/code)
core-devops added 1 commit 2026-05-14 13:00:17 +00:00
fix(ci): skip github.ref-gated jobs in ci_job_names (mc#958 mc#959)
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 13s
Details
CI / Detect changes (pull_request) Successful in 45s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 52s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 58s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 59s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 19s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m19s
Details
qa-review / approved (pull_request) Failing after 22s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 49s
Details
security-review / approved (pull_request) Failing after 21s
Details
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
Details
gate-check-v3 / gate-check (pull_request) Successful in 31s
Details
sop-tier-check / tier-check (pull_request) Successful in 14s
Details
sop-checklist / all-items-acked (pull_request) Successful in 17s
Details
CI / Platform (Go) (pull_request) Successful in 6s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 6s
Details
CI / Canvas (Next.js) (pull_request) Successful in 7s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Failing after 1m27s
Details
CI / Python Lint & Test (pull_request) Successful in 7s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 10s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 8s
Details
CI / Canvas Deploy Reminder (pull_request) Successful in 4s
Details
CI / all-required (pull_request) Successful in 3s
Details
3eef828173 
Adds `github.ref` as a skip condition in ci_job_names(), matching the
existing github.event_name skip. Jobs gated on github.ref (e.g.
canvas-deploy-reminder: only runs on pushes to refs/heads/main) never
execute in a PR context, so flagging them as missing from
all-required.needs: is a false positive that triggers mc#958/mc#959.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-devops added the merge-queue label 2026-05-14 13:00:59 +00:00
hongming commented 2026-05-14 13:02:41 +00:00
Owner
Copy Link
Copy Source

Superseded by #991 which landed the identical github.ref skip in ci_job_names(). Closing.

Superseded by #991 which landed the identical `github.ref` skip in `ci_job_names()`. Closing.
hongming closed this pull request 2026-05-14 13:02:54 +00:00
hongming-pc2 commented 2026-05-14 13:03:57 +00:00
Owner
Copy Link
Copy Source

[core-offsec-agent] APPROVED — security review complete.

Finding: CLEAN — no security concerns.

Analysis: ci-required-drift.py F1 detection — extends the skip list for jobs gated on github.event_name or github.ref. Prevents false positives when branch-push-only jobs are skipped in PR context. Same github.event_name skip pattern already in use; github.ref is the companion case. No injection/exec/auth surface. Operational CI hardening.

Static analysis: bandit — 0 findings.
Secrets scan: clean.

[core-offsec-agent] **APPROVED** — security review complete. **Finding:** CLEAN — no security concerns. **Analysis:** `ci-required-drift.py` F1 detection — extends the skip list for jobs gated on `github.event_name` or `github.ref`. Prevents false positives when branch-push-only jobs are skipped in PR context. Same `github.event_name` skip pattern already in use; `github.ref` is the companion case. No injection/exec/auth surface. Operational CI hardening. **Static analysis:** bandit — 0 findings. **Secrets scan:** clean.
Some optional checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 13s
Details
CI / Detect changes (pull_request) Successful in 45s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 52s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 58s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 59s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 19s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m19s
Details
qa-review / approved (pull_request) Failing after 22s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 49s
Details
security-review / approved (pull_request) Failing after 21s
Details
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
Details
gate-check-v3 / gate-check (pull_request) Successful in 31s
Details
sop-tier-check / tier-check (pull_request) Successful in 14s
Details
sop-checklist / all-items-acked (pull_request) Successful in 17s
Details
CI / Platform (Go) (pull_request) Successful in 6s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 6s
Details
CI / Canvas (Next.js) (pull_request) Successful in 7s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Failing after 1m27s
Details
CI / Python Lint & Test (pull_request) Successful in 7s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 10s
Required
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
Required
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 8s
Details
CI / Canvas Deploy Reminder (pull_request) Successful in 4s
Details
CI / all-required (pull_request) Successful in 3s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label merge-queue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1004
Delete Branch "fix/ci-required-drift-github-ref-skip"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?