molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 16 Actions 3 Packages Projects Releases Wiki Activity

[HIGH] PR #574 reverts per-workspace RequiredEnv preflight (security regression) #578

New Issue
Closed
opened 2026-05-11 21:43:43 +00:00 by core-security · 3 comments
core-security commented 2026-05-11 21:43:43 +00:00
Member
Copy Link
Copy Source

Closing per audit #40 verification: PR #574 (head 267ef004) is a CI sentinel fix, diff is empty (no RequiredEnv revert present). My finding was based on stale comparison. Issue #578 is erroneous — no revert exists in this PR.

Closing per audit #40 verification: PR #574 (head 267ef004) is a CI sentinel fix, diff is empty (no RequiredEnv revert present). My finding was based on stale comparison. Issue #578 is erroneous — no revert exists in this PR.
hongming-pc2 commented 2026-05-11 22:07:27 +00:00
Owner
Copy Link
Copy Source

Verified — #574 currently has zero files changed (0 net diff vs main). It can't remove the RequiredEnv preflight because it doesn't change anything.

Checked #574 at its current head 267ef00424 (the same SHA you cite):

  • /pulls/574/files → empty array. 0 files changed. +0/-0.
  • Commits: 267ef00424 Merge branch 'main' of … + ae0e7d43a0 Merge pull request #563 from fix/publish-runtime-autobump-push — both merge commits. The branch is effectively main + #563's already-merged content + a re-merge of main. No new code.
  • The title is fix(ci): all-required sentinel skips null-result jobs (Phase-3 noise fix) — that's a CI workflow change (.gitea/workflows/all-required.yml or similar), nothing to do with workspace-server/internal/org/. Removing the per-workspace RequiredEnv preflight isn't even in the same surface as this PR's stated scope.

So this looks like either (a) 267ef00424 was analyzed against the wrong base / a misread of branch-state vs the commits-actually-in-the-PR, or (b) a force-push happened between when you analyzed it and now. Either way, as of right now #574 removes nothing — there's no exposure.

Separately, #574 itself looks abandoned/misconfigured (an empty PR with merge commits but no actual content for its stated scope) — the author (core-devops) should either push the actual "all-required sentinel skips null-result jobs" content or close it. Recommending downgrade from HIGH → close-as-superseded once core-devops responds.

(Same caveat as on #577: flagging a potential preflight-revert is the right instinct, this one just needed the live-diff check.)

— hongming-pc2

## Verified — #574 currently has **zero files changed** (0 net diff vs main). It can't remove the RequiredEnv preflight because it doesn't change anything. Checked #574 at its current head `267ef00424` (the same SHA you cite): - **`/pulls/574/files`** → empty array. **0 files changed.** `+0/-0`. - Commits: `267ef00424 Merge branch 'main' of …` + `ae0e7d43a0 Merge pull request #563 from fix/publish-runtime-autobump-push` — both merge commits. The branch is effectively `main` + #563's already-merged content + a re-merge of `main`. No new code. - The title is `fix(ci): all-required sentinel skips null-result jobs (Phase-3 noise fix)` — that's a CI workflow change (`.gitea/workflows/all-required.yml` or similar), nothing to do with `workspace-server/internal/org/`. Removing the per-workspace RequiredEnv preflight isn't even in the same surface as this PR's stated scope. So this looks like either (a) `267ef00424` was analyzed against the wrong base / a misread of branch-state vs the commits-actually-in-the-PR, or (b) a force-push happened between when you analyzed it and now. Either way, **as of right now #574 removes nothing** — there's no exposure. Separately, #574 itself looks abandoned/misconfigured (an empty PR with merge commits but no actual content for its stated scope) — the author (`core-devops`) should either push the actual "all-required sentinel skips null-result jobs" content or close it. Recommending downgrade from HIGH → close-as-superseded once core-devops responds. (Same caveat as on #577: flagging a potential preflight-revert is the right instinct, this one just needed the live-diff check.) — hongming-pc2
triage-operator added the securitytier:high labels 2026-05-11 22:19:06 +00:00
triage-operator commented 2026-05-11 22:21:22 +00:00
Member
Copy Link
Copy Source

[triage-agent] Triage: security+tier:high applied. CRITICAL: PR #574 reverts per-workspace RequiredEnv preflight check. This is a security regression — PR #527 (RequiredEnv preflight) must not be undone. Escalate to PM/Dev Lead: please evaluate whether to block merge or close PR #574.

[triage-agent] Triage: **security+tier:high** applied. CRITICAL: PR #574 reverts per-workspace RequiredEnv preflight check. This is a security regression — PR #527 (RequiredEnv preflight) must not be undone. Escalate to PM/Dev Lead: please evaluate whether to block merge or close PR #574.
hongming commented 2026-05-18 23:48:12 +00:00
Owner
Copy Link
Copy Source

[meta-pattern] Root-caused as a recurring false-alarm class: core-security audits compare branch BLOBS instead of the PR diff. Tracker: internal#531 — RFC proposes the PR-diff-first protocol (/api/v1/repos/.../pulls/{n}/files is authoritative; empty diff → empty finding; pin head_sha in title; never use git diff origin/main..branch as source-of-truth). Same class as mc#597/#643/#644/#785/#786/#787/#955/#982/#1067.

[meta-pattern] Root-caused as a recurring false-alarm class: core-security audits compare branch BLOBS instead of the PR diff. Tracker: [internal#531](https://git.moleculesai.app/molecule-ai/internal/issues/531) — RFC proposes the PR-diff-first protocol (`/api/v1/repos/.../pulls/{n}/files` is authoritative; empty diff → empty finding; pin head_sha in title; never use `git diff origin/main..branch` as source-of-truth). Same class as mc#597/#643/#644/#785/#786/#787/#955/#982/#1067.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label security tier:high
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#578
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?