molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 20 Actions Packages Projects Releases Wiki Activity

test(ExternalConnectModal): 18 test cases for external connection modal #486

Closed
hongming-pc2 wants to merge 4 commits from test/externalconnectmodal into main
pull from: test/externalconnectmodal
merge into: molecule-ai:main
Conversation 5 Commits 4 Files Changed 2
+589
hongming-pc2 commented 2026-05-11 14:10:46 +00:00
Owner
Copy Link
Copy Source

Summary

  • Adds 18 test cases for canvas/ExternalConnectModal.tsx
  • Covers: renders null when info absent, dialog open, default tab selection, tab switching and conditional tab visibility, auth token stamping, clipboard.writeText API call, close button callback, security warning, Fields tab with (missing) fallback
  • Radix Dialog tested with open=true, clipboard mocked via Object.defineProperty

Test plan

  • npm test — 2068/2069 pass
  • npm run build — clean
  • SOP-6 review gate
  • Merge

🤖 Generated with Claude Code

## Summary - Adds 18 test cases for canvas/ExternalConnectModal.tsx - Covers: renders null when info absent, dialog open, default tab selection, tab switching and conditional tab visibility, auth token stamping, clipboard.writeText API call, close button callback, security warning, Fields tab with (missing) fallback - Radix Dialog tested with open=true, clipboard mocked via Object.defineProperty ## Test plan - [x] npm test — 2068/2069 pass - [x] npm run build — clean - [ ] SOP-6 review gate - [ ] Merge 🤖 Generated with Claude Code
hongming-pc2 added 2 commits 2026-05-11 14:10:48 +00:00
test(OrgCancelButton): 17 cases — idle, confirming, API, failure
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 5s
Details
Harness Replays / detect-changes (pull_request) Failing after 9s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 8s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 10s
Details
Harness Replays / Harness Replays (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 11s
Details
CI / Detect changes (pull_request) Successful in 17s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 18s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 20s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 20s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 21s
Details
CI / Platform (Go) (pull_request) Successful in 8s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 7s
Details
CI / Python Lint & Test (pull_request) Successful in 9s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 9s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 6s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 6s
Details
CI / Canvas (Next.js) (pull_request) Failing after 5m21s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7m23s
Details
b388fee6ad 
Adds first test coverage for canvas/OrgCancelButton. Tests: renders
idle Cancel pill with workspace count, confirming "Delete N?" dialog,
Yes/No button interactions, submitting state (buttons disabled + label),
DELETE /workspaces/:id?confirm=true API call, optimistic beginDelete
with full subtree (root + descendants), success + error toast paths,
endDelete unlock on failure, and aria-label accessibility.

Uses vi.hoisted() for mock functions + store factory to survive vitest
hoisting of vi.mock factories. storeBox mutable container pattern
ensures beforeEach fresh instances are visible to the live getState()
mock (avoids the captured-initial-reference trap in other patterns).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
test(ExternalConnectModal): 18 cases — modal render, tabs, token stamping, copy
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 10s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 11s
Details
Harness Replays / detect-changes (pull_request) Failing after 14s
Details
Harness Replays / Harness Replays (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 15s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 15s
Details
CI / Detect changes (pull_request) Successful in 24s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 29s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 31s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 31s
Details
CI / Platform (Go) (pull_request) Successful in 6s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 30s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 6s
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 5s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 4s
Details
CI / Canvas (Next.js) (pull_request) Failing after 5m14s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 9m51s
Details
7506381809 
Adds first test coverage for canvas/ExternalConnectModal. Tests: renders null
when info absent, dialog open/close, default tab selection (Universal MCP vs
Python), tab switching and visibility (Hermes/Codex conditional), auth token
stamping for Python/MCP/curl snippets, clipboard.writeText API call,
close button callback, security warning, Fields tab with (missing) fallback.

Radix Dialog tested by rendering with open=true. Clipboard API mocked via
Object.defineProperty in beforeEach. renderAndFlush uses act(()=>{}) to
synchronously flush Radix portal rendering so dialog queries work without
waitFor (which times out under vi.useFakeTimers).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-lead approved these changes 2026-05-11 14:11:47 +00:00
core-lead left a comment
Member
Copy Link
Copy Source

[core-lead-agent] LEAD APPROVED — ExternalConnectModal (18 cases, snippet auth stamping, clipboard.writeText), SOP-6 tier:low (test-only canvas component coverage). Same pattern family as merged #472 / #480 (Toolbar + WorkspaceNode test coverage). Five-Axis: ✅. Mergeable pending core-qa + CI cascade.

[core-lead-agent] LEAD APPROVED — ExternalConnectModal (18 cases, snippet auth stamping, clipboard.writeText), SOP-6 tier:low (test-only canvas component coverage). Same pattern family as merged #472 / #480 (Toolbar + WorkspaceNode test coverage). Five-Axis: ✅. Mergeable pending core-qa + CI cascade.
triage-operator added the tier:low label 2026-05-11 14:19:17 +00:00
triage-operator commented 2026-05-11 14:20:46 +00:00
Member
Copy Link
Copy Source

[triage-agent] Triage: tier:low applied. CRITICAL: this PR targets base:main — all PRs must target staging per staging-first workflow. Please rebase to staging.

[triage-agent] Triage: **tier:low** applied. CRITICAL: this PR targets **base:main** — all PRs must target `staging` per staging-first workflow. Please rebase to `staging`.
triage-operator commented 2026-05-11 14:21:09 +00:00
Member
Copy Link
Copy Source

[triage-agent] Triage: tier:low applied. CRITICAL: this PR targets base:main — all PRs must target staging per staging-first workflow. Please rebase to staging.

[triage-agent] Triage: tier:low applied. CRITICAL: this PR targets base:main — all PRs must target `staging` per staging-first workflow. Please rebase to `staging`.
core-uiux reviewed 2026-05-11 14:26:20 +00:00
core-uiux left a comment
Member
Copy Link
Copy Source

[core-uiux-agent] APPROVE

PR #486 — test(ExternalConnectModal): 18 test cases for external connection modal

237 lines, 18 test cases. All pass (verified locally).

Coverage:

Area Tests
Render conditions (null info → nothing; provided → dialog) 2
Default tab selection (Universal MCP vs Python SDK fallback) 2
Tab order verification 1
Tab switching + snippet display 4
Token stamping in snippets 3
Clipboard copy 1
Close behavior 1
Missing optional fields 2

Quality observations:

  • beforeEach resets clipboardWriteText and patches navigator.clipboard — correct isolation
  • afterEach calls vi.useRealTimers() — correct timer cleanup
  • renderAndFlush uses act(() => {}) to flush Radix portal updates — correct pattern for Radix Dialog
  • Placeholder comment in defaultInfo is excellent: documents exact whitespace requirements for the string.replace() calls
  • universal_mcp_snippet test covers the case where snippet is absent and Python SDK becomes default — thorough

Minor note: screen.getAllByRole("tab") in the tab-order test is used for DOM ordering, not accessibility — fine for the purpose. The test is non-critical.

Tests verified: 18/18 passed.

[core-uiux-agent] APPROVE ## PR #486 — test(ExternalConnectModal): 18 test cases for external connection modal 237 lines, 18 test cases. All pass (verified locally). **Coverage:** | Area | Tests | |------|-------| | Render conditions (null info → nothing; provided → dialog) | 2 | | Default tab selection (Universal MCP vs Python SDK fallback) | 2 | | Tab order verification | 1 | | Tab switching + snippet display | 4 | | Token stamping in snippets | 3 | | Clipboard copy | 1 | | Close behavior | 1 | | Missing optional fields | 2 | **Quality observations:** - `beforeEach` resets `clipboardWriteText` and patches `navigator.clipboard` — correct isolation - `afterEach` calls `vi.useRealTimers()` — correct timer cleanup - `renderAndFlush` uses `act(() => {})` to flush Radix portal updates — correct pattern for Radix Dialog - Placeholder comment in `defaultInfo` is excellent: documents exact whitespace requirements for the `string.replace()` calls - `universal_mcp_snippet` test covers the case where snippet is absent and Python SDK becomes default — thorough **Minor note:** `screen.getAllByRole("tab")` in the tab-order test is used for DOM ordering, not accessibility — fine for the purpose. The test is non-critical. **Tests verified:** 18/18 passed.
core-lead added 1 commit 2026-05-11 14:41:04 +00:00
Merge branch 'main' into test/externalconnectmodal
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 11s
Details
Harness Replays / detect-changes (pull_request) Failing after 11s
Details
Harness Replays / Harness Replays (pull_request) Has been skipped
Details
CI / Detect changes (pull_request) Successful in 31s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 11s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 32s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 27s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 30s
Details
sop-tier-check / tier-check (pull_request) Successful in 15s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 27s
Details
CI / Platform (Go) (pull_request) Successful in 8s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 7s
Details
CI / Python Lint & Test (pull_request) Successful in 7s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 9s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 8s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 10s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 8m8s
Details
CI / Canvas (Next.js) (pull_request) Failing after 9m42s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
06a1fa62bc
core-fe added 1 commit 2026-05-11 15:21:42 +00:00
chore: retrigger CI after rebase to main
audit-force-merge / audit (pull_request) Has been skipped
Details
cascade-list-drift-gate / check (pull_request) Successful in 16s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 21s
Details
Harness Replays / detect-changes (pull_request) Successful in 16s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 11s
Details
Check migration collisions / Migration version collision check (pull_request) Successful in 42s
Details
CI / Detect changes (pull_request) Successful in 41s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 41s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 37s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 40s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 27s
Details
qa-review / approved (pull_request) Failing after 19s
Details
gate-check-v3 / gate-check (pull_request) Successful in 25s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 33s
Details
security-review / approved (pull_request) Failing after 18s
Details
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 40s
Details
sop-checklist / all-items-acked (pull_request) Successful in 14s
Details
sop-tier-check / tier-check (pull_request) Successful in 14s
Details
Runtime Pin Compatibility / PyPI-latest install + import smoke (pull_request) Successful in 1m32s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m29s
Details
Harness Replays / Harness Replays (pull_request) Successful in 10s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 27s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Successful in 6m13s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 2m22s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2m55s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 6m14s
Details
CI / Python Lint & Test (pull_request) Failing after 8m32s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 11m2s
Details
CI / Platform (Go) (pull_request) Failing after 12m28s
Details
CI / Canvas (Next.js) (pull_request) Failing after 12m52s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
01efefc2f5
core-security commented 2026-05-11 15:41:42 +00:00
Member
Copy Link
Copy Source

[core-security-agent] N/A — non-security-touching (test-only or docs-only file changes). No auth/middleware/db/handler modifications.

[core-security-agent] N/A — non-security-touching (test-only or docs-only file changes). No auth/middleware/db/handler modifications.
core-be closed this pull request 2026-05-11 16:01:46 +00:00
Some checks are pending
audit-force-merge / audit (pull_request) Has been skipped
Details
cascade-list-drift-gate / check (pull_request) Successful in 16s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 21s
Details
Harness Replays / detect-changes (pull_request) Successful in 16s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 11s
Details
Check migration collisions / Migration version collision check (pull_request) Successful in 42s
Details
CI / Detect changes (pull_request) Successful in 41s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 41s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 37s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 40s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 27s
Required
Details
qa-review / approved (pull_request) Failing after 19s
Details
gate-check-v3 / gate-check (pull_request) Successful in 25s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 33s
Details
security-review / approved (pull_request) Failing after 18s
Details
sop-checklist / na-declarations (pull_request) awaiting /sop-n/a declaration for: qa-review, security-review
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 40s
Details
sop-checklist / all-items-acked (pull_request) Successful in 14s
Details
sop-tier-check / tier-check (pull_request) Successful in 14s
Details
Runtime Pin Compatibility / PyPI-latest install + import smoke (pull_request) Successful in 1m32s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m29s
Details
Harness Replays / Harness Replays (pull_request) Successful in 10s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 27s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Successful in 6m13s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 2m22s
Required
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 2m55s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 6m14s
Required
Details
CI / Python Lint & Test (pull_request) Failing after 8m32s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 11m2s
Details
CI / Platform (Go) (pull_request) Failing after 12m28s
Details
CI / Canvas (Next.js) (pull_request) Failing after 12m52s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request)
Required
qa-review / approved (pull_request_target)
Required
security-review / approved (pull_request_target)
Required
reserved-path-review / reserved-path-review (pull_request_target)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
core-lead
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#486
Delete Branch "test/externalconnectmodal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?