molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 20 Actions Packages Projects Releases Wiki Activity

[needs-regression-test] handlers-api: author missing real-infra scripts (test_a2a_e2e.sh, test_secrets_dispatch.sh) + ensure handler surface is exercised by the (un-masked) real-PG/live-server gate #2151

New Issue
Closed
opened 2026-06-03 00:20:22 +00:00 by molecule-code-reviewer · 1 comment
molecule-code-reviewer commented 2026-06-03 00:20:22 +00:00
Member
Copy Link
Copy Source

P1 (critical, paired with the continue-on-error un-mask PR). 34/34 handlers currently unit/mock-only; the real-infra contexts exist but are masked (mc#1982). test_layer: real-postgres.

Filed under SOP rule internal#765 (regression-coverage). From the 2026-06-02 platform-wide coverage audit (only ~13% of features have a real CI-gated regression test). Implementation incoming via dispatched subagents; CI + CR2 + CTO signoff validate (watch-fail-first per SOP).

P1 (critical, paired with the continue-on-error un-mask PR). 34/34 handlers currently unit/mock-only; the real-infra contexts exist but are masked (mc#1982). test_layer: real-postgres. --- Filed under SOP rule internal#765 (regression-coverage). From the 2026-06-02 platform-wide coverage audit (only ~13% of features have a real CI-gated regression test). Implementation incoming via dispatched subagents; CI + CR2 + CTO signoff validate (watch-fail-first per SOP).
molecule-code-reviewer commented 2026-06-03 03:10:46 +00:00
Author
Member
Copy Link
Copy Source

MECHANISM: Several workspace-server handler integration tests are still guarded by direct t.Skip branches when their real-infra prerequisite is absent, so a required gate can appear healthy while not exercising the handler path unless the CI job also proves the prerequisite exists. The concrete pattern is in workspace-server/internal/handlers/*_integration_test.go: tests for workspace create-name, tokens, workspace broadcast org-root, pending uploads, and delegation ledger all skip on missing INTEGRATION_DB_URL. This is the same class #2151 is trying to remove: mock/unit coverage exists, but real-Postgres handler behavior can remain masked by environment availability.

EVIDENCE: Local read-only scan found workspace_create_name_integration_test.go:64, tokens_test.go:30, workspace_broadcast_org_root_integration_test.go:63, pending_uploads_integration_test.go:68, and delegation_ledger_integration_test.go:62 all skipping when INTEGRATION_DB_URL is unset. Representative excerpt: INTEGRATION_DB_URL not set; skipping. This is distinct from harmless platform-conditioned skips like symlink unsupported or missing local git fixtures.

RECOMMENDED FIX SHAPE: Keep #2151 scoped to real-infra handler coverage, but add an explicit CI preflight/fixture invariant for the handlers-postgres-integration gate: if the gate is required, missing INTEGRATION_DB_URL or an unreachable Postgres fixture should fail the job before tests run, not be converted into Go test skips. The responsible surface is molecule-core/.gitea/workflows/handlers-postgres-integration.yml plus the affected workspace-server/internal/handlers/*_integration_test.go tests; implementation should not remove local-dev skips unless CI has a separate hard-preflight.

MECHANISM: Several workspace-server handler integration tests are still guarded by direct `t.Skip` branches when their real-infra prerequisite is absent, so a required gate can appear healthy while not exercising the handler path unless the CI job also proves the prerequisite exists. The concrete pattern is in `workspace-server/internal/handlers/*_integration_test.go`: tests for workspace create-name, tokens, workspace broadcast org-root, pending uploads, and delegation ledger all skip on missing `INTEGRATION_DB_URL`. This is the same class #2151 is trying to remove: mock/unit coverage exists, but real-Postgres handler behavior can remain masked by environment availability. EVIDENCE: Local read-only scan found `workspace_create_name_integration_test.go:64`, `tokens_test.go:30`, `workspace_broadcast_org_root_integration_test.go:63`, `pending_uploads_integration_test.go:68`, and `delegation_ledger_integration_test.go:62` all skipping when `INTEGRATION_DB_URL` is unset. Representative excerpt: `INTEGRATION_DB_URL not set; skipping`. This is distinct from harmless platform-conditioned skips like symlink unsupported or missing local git fixtures. RECOMMENDED FIX SHAPE: Keep #2151 scoped to real-infra handler coverage, but add an explicit CI preflight/fixture invariant for the handlers-postgres-integration gate: if the gate is required, missing `INTEGRATION_DB_URL` or an unreachable Postgres fixture should fail the job before tests run, not be converted into Go test skips. The responsible surface is `molecule-core/.gitea/workflows/handlers-postgres-integration.yml` plus the affected `workspace-server/internal/handlers/*_integration_test.go` tests; implementation should not remove local-dev skips unless CI has a separate hard-preflight.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2151
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?