molecule-ai/molecule-core
49
0
Fork 2
Code Issues 145 Pull Requests 157 Actions 5 Packages Projects Releases Wiki Activity

feat(display): proxy native desktop streams after takeover #1752

Merged
hongming merged 1 commits from feat/1686-display-session-proxy into main 2026-05-24 01:33:25 +00:00
Conversation 2 Commits 1 Files Changed 13
+601 -65
hongming commented 2026-05-23 23:28:41 +00:00
Owner
Copy Link
Copy Source

Implements the remaining native Display takeover path for issue #1686.

Changes:

  • Canvas uses trusted @novnc/novnc client instead of iframeing workspace-served HTML.
  • Take Control now returns a short-lived signed display session URL with the token in the URL fragment; Canvas sends it as a WebSocket subprotocol so it is not logged as a request query string.
  • workspace-server proxies only /websockify, only after validating the active display-control lock token, and strips credentials plus the custom token subprotocol before forwarding upstream.
  • Display status reports ready only when display is enabled and the EC2 instance_id exists.
  • Tenant startup now applies DISPLAY_SESSION_SIGNING_SECRET from the existing /cp/tenants/config self-refresh path.
  • Adds regression coverage for token signing, empty-secret fail-closed behavior, auth gating, stream proxy credential stripping, no query-token URLs, and tenant startup env refresh.

Verification:

  • workspace-server: go test ./cmd/server ./internal/handlers ./internal/router
  • canvas: npm test -- --run src/components/tabs/tests/DisplayTab.test.tsx src/components/tests/CreateWorkspaceDialog.test.tsx
  • canvas: npm run build -- --no-lint (passes; Next emits an @novnc/novnc top-level-await compatibility warning)

Review notes:

  • Follow-up to PR #1732. This avoids same-origin proxying of workspace-controlled HTML by serving trusted viewer code from Canvas and proxying only the VNC websocket.
  • Requires matching controlplane PR #263, which injects DISPLAY_SESSION_SIGNING_SECRET for new tenants and lazily backfills it for existing tenants through /cp/tenants/config on restart/redeploy.
Implements the remaining native Display takeover path for issue #1686. Changes: - Canvas uses trusted @novnc/novnc client instead of iframeing workspace-served HTML. - Take Control now returns a short-lived signed display session URL with the token in the URL fragment; Canvas sends it as a WebSocket subprotocol so it is not logged as a request query string. - workspace-server proxies only /websockify, only after validating the active display-control lock token, and strips credentials plus the custom token subprotocol before forwarding upstream. - Display status reports ready only when display is enabled and the EC2 instance_id exists. - Tenant startup now applies DISPLAY_SESSION_SIGNING_SECRET from the existing /cp/tenants/config self-refresh path. - Adds regression coverage for token signing, empty-secret fail-closed behavior, auth gating, stream proxy credential stripping, no query-token URLs, and tenant startup env refresh. Verification: - workspace-server: go test ./cmd/server ./internal/handlers ./internal/router - canvas: npm test -- --run src/components/tabs/__tests__/DisplayTab.test.tsx src/components/__tests__/CreateWorkspaceDialog.test.tsx - canvas: npm run build -- --no-lint (passes; Next emits an @novnc/novnc top-level-await compatibility warning) Review notes: - Follow-up to PR #1732. This avoids same-origin proxying of workspace-controlled HTML by serving trusted viewer code from Canvas and proxying only the VNC websocket. - Requires matching controlplane PR #263, which injects DISPLAY_SESSION_SIGNING_SECRET for new tenants and lazily backfills it for existing tenants through /cp/tenants/config on restart/redeploy.
hongming added 1 commit 2026-05-23 23:28:41 +00:00
feat(display): proxy native desktop streams after takeover
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Canvas Deploy Reminder (pull_request) Blocked by required conditions
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 9s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 16s
Details
CI / Python Lint & Test (pull_request) Successful in 19s
Details
CI / Detect changes (pull_request) Successful in 23s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 9s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Details
Harness Replays / detect-changes (pull_request) Successful in 7s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 10s
Details
E2E Chat / detect-changes (pull_request) Successful in 11s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 9s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 8s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s
Details
gate-check-v3 / gate-check (pull_request) Successful in 5s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
security-review / approved (pull_request) Failing after 10s
Details
sop-checklist / all-items-acked (pull_request) Successful in 9s
Details
qa-review / approved (pull_request) Failing after 10s
Details
sop-tier-check / tier-check (pull_request) Successful in 8s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m4s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m26s
Details
E2E Chat / E2E Chat (pull_request) Successful in 5s
Details
CI / Platform (Go) (pull_request) Successful in 5m22s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 11s
Details
Harness Replays / Harness Replays (pull_request) Successful in 5s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1m52s
Details
CI / Canvas (Next.js) (pull_request) Successful in 7m16s
Details
CI / all-required (pull_request) Successful in 20m31s
Details
759e1133df
app-fe force-pushed feat/1686-display-session-proxy from 759e1133df to ce9dcfd75c 2026-05-23 23:33:36 +00:00 Compare
app-fe force-pushed feat/1686-display-session-proxy from ce9dcfd75c to 3fa5a90bc1 2026-05-23 23:40:02 +00:00 Compare
core-qa approved these changes 2026-05-23 23:43:50 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

Approved from QA: focused local verification covers Display tab takeover, workspace-server display/session handlers, tenant startup env refresh, and Canvas build.

Approved from QA: focused local verification covers Display tab takeover, workspace-server display/session handlers, tenant startup env refresh, and Canvas build.
core-security approved these changes 2026-05-23 23:43:51 +00:00
core-security left a comment
Member
Copy Link
Copy Source

Approved from security: token moved out of request query logging path, session proxy validates active control lock, strips browser credentials, and forwards only /websockify.

Approved from security: token moved out of request query logging path, session proxy validates active control lock, strips browser credentials, and forwards only /websockify.
app-fe force-pushed feat/1686-display-session-proxy from 3fa5a90bc1 to 3c82b39f3d 2026-05-24 00:41:49 +00:00 Compare
hongming merged commit 43422e0ba9 into main 2026-05-24 01:33:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
core-qa
core-security
Labels
Clear labels
area/ci
CI/CD pipeline issues
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1752
Delete Branch "feat/1686-display-session-proxy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?