molecule-ai/molecule-core
49
0
Fork 2
Code Issues 145 Pull Requests 157 Actions 5 Packages Projects Releases Wiki Activity

feat(display): add desktop workspace creation flow #1732

Merged
hongming merged 1 commits from feat/1686-display-workspace-flow into main 2026-05-23 21:00:00 +00:00
Conversation 14 Commits 1 Files Changed 10
+502 -31
hongming commented 2026-05-23 19:49:17 +00:00
Owner
Copy Link
Copy Source

Implements the molecule-core side of #1686 target display flow.\n\nChanges:\n- Adds Display controls to New Workspace under Container Config with defaults: t3.xlarge, 80GB, 1920x1080.\n- Sends compute.display through workspace create and CP provision payloads.\n- Adds Display tab iframe rendering for available viewer sessions and explicit Release control.\n- Adds viewer URL contract for DISPLAY_VIEWER_BASE_URL or DISPLAY_WORKSPACE_DOMAIN_SUFFIX.\n\nVerification:\n- npm test -- --run src/components/tests/CreateWorkspaceDialog.test.tsx src/components/tabs/tests/DisplayTab.test.tsx\n- npm run build\n- go test ./internal/handlers ./internal/provisioner -run 'TestWorkspaceDisplay|TestBuildProvisionerConfig_CopiesComputeSizingFromPayload|TestStart_HappyPath'\n\nPair PR: molecule-controlplane feat/1686-display-workspace-flow.

Implements the molecule-core side of #1686 target display flow.\n\nChanges:\n- Adds Display controls to New Workspace under Container Config with defaults: t3.xlarge, 80GB, 1920x1080.\n- Sends compute.display through workspace create and CP provision payloads.\n- Adds Display tab iframe rendering for available viewer sessions and explicit Release control.\n- Adds viewer URL contract for DISPLAY_VIEWER_BASE_URL or DISPLAY_WORKSPACE_DOMAIN_SUFFIX.\n\nVerification:\n- npm test -- --run src/components/__tests__/CreateWorkspaceDialog.test.tsx src/components/tabs/__tests__/DisplayTab.test.tsx\n- npm run build\n- go test ./internal/handlers ./internal/provisioner -run 'TestWorkspaceDisplay|TestBuildProvisionerConfig_CopiesComputeSizingFromPayload|TestStart_HappyPath'\n\nPair PR: molecule-controlplane feat/1686-display-workspace-flow.
hongming added 1 commit 2026-05-23 19:49:17 +00:00
feat(display): add desktop workspace creation flow
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Canvas Deploy Reminder (pull_request) Blocked by required conditions
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 10s
Details
CI / Detect changes (pull_request) Successful in 13s
Details
CI / Python Lint & Test (pull_request) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 10s
Details
E2E Chat / detect-changes (pull_request) Successful in 15s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Has been skipped
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 10s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 21s
Details
Harness Replays / detect-changes (pull_request) Successful in 13s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 8s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 9s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 45s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 13s
Details
gate-check-v3 / gate-check (pull_request) Successful in 13s
Details
qa-review / approved (pull_request) Failing after 7s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
security-review / approved (pull_request) Failing after 7s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) Successful in 6s
Details
sop-tier-check / tier-check (pull_request) Successful in 4s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m11s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 12s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1m42s
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
CI / Platform (Go) (pull_request) Failing after 5m25s
Details
CI / all-required (pull_request) Failing after 9m16s
Details
Harness Replays / Harness Replays (pull_request) Successful in 4s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 6s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m51s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2m23s
Details
3ca2755044
app-fe force-pushed feat/1686-display-workspace-flow from 3ca2755044 to 3fca753eea 2026-05-23 20:03:09 +00:00 Compare
core-qa approved these changes 2026-05-23 20:03:59 +00:00
Dismissed
core-qa left a comment
Member
Copy Link
Copy Source

QA review approved after amended fixes: target create flow now sends an explicit model, display compute payload is covered, and focused Canvas/Go tests pass.

QA review approved after amended fixes: target create flow now sends an explicit model, display compute payload is covered, and focused Canvas/Go tests pass.
core-security approved these changes 2026-05-23 20:04:19 +00:00
Dismissed
core-security left a comment
Member
Copy Link
Copy Source

Security review approved after amended fixes: no public noVNC fallback, viewer URLs require https DISPLAY_VIEWER_BASE_URL, dimensions are capped, and the display stream is proxy-ready instead of public.

Security review approved after amended fixes: no public noVNC fallback, viewer URLs require https DISPLAY_VIEWER_BASE_URL, dimensions are capped, and the display stream is proxy-ready instead of public.
core-qa approved these changes 2026-05-23 20:05:09 +00:00
Dismissed
core-qa left a comment
Member
Copy Link
Copy Source

QA approved.

QA approved.
core-security approved these changes 2026-05-23 20:05:10 +00:00
Dismissed
core-security left a comment
Member
Copy Link
Copy Source

Security approved.

Security approved.
app-fe force-pushed feat/1686-display-workspace-flow from 3fca753eea to eec3aca785 2026-05-23 20:29:07 +00:00 Compare
app-fe dismissed core-qa's review 2026-05-23 20:29:07 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

app-fe dismissed core-security's review 2026-05-23 20:29:07 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

core-qa reviewed 2026-05-23 20:29:22 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

QA approved on amended head eec3aca7: invalid-compute test now includes explicit model and focused tests pass.

QA approved on amended head eec3aca7: invalid-compute test now includes explicit model and focused tests pass.
core-security reviewed 2026-05-23 20:29:23 +00:00
core-security left a comment
Member
Copy Link
Copy Source

Security approved on amended head eec3aca7: security fixes unchanged from prior approval.

Security approved on amended head eec3aca7: security fixes unchanged from prior approval.
core-qa approved these changes 2026-05-23 20:29:41 +00:00
Dismissed
core-qa left a comment
Member
Copy Link
Copy Source

QA approved on amended head eec3aca7: invalid-compute test now includes explicit model and focused tests pass.

QA approved on amended head eec3aca7: invalid-compute test now includes explicit model and focused tests pass.
core-qa approved these changes 2026-05-23 20:29:41 +00:00
Dismissed
core-qa left a comment
Member
Copy Link
Copy Source

Approved on amended head.

Approved on amended head.
core-security approved these changes 2026-05-23 20:29:42 +00:00
Dismissed
core-security left a comment
Member
Copy Link
Copy Source

Security approved on amended head eec3aca7: security fixes unchanged from prior approval.

Security approved on amended head eec3aca7: security fixes unchanged from prior approval.
core-security approved these changes 2026-05-23 20:29:43 +00:00
Dismissed
core-security left a comment
Member
Copy Link
Copy Source

Approved on amended head.

Approved on amended head.
app-fe force-pushed feat/1686-display-workspace-flow from eec3aca785 to 5551ef40e3 2026-05-23 20:46:43 +00:00 Compare
app-fe dismissed core-qa's review 2026-05-23 20:46:43 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

app-fe dismissed core-security's review 2026-05-23 20:46:43 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

core-qa approved these changes 2026-05-23 20:46:57 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

QA approved on rebased head 5551ef40; conflict resolved and focused tests pass.

QA approved on rebased head 5551ef40; conflict resolved and focused tests pass.
core-qa approved these changes 2026-05-23 20:46:59 +00:00
core-qa left a comment
Member
Copy Link
Copy Source

Approved on rebased head.

Approved on rebased head.
core-security approved these changes 2026-05-23 20:47:00 +00:00
core-security left a comment
Member
Copy Link
Copy Source

Security approved on rebased head 5551ef40; security posture unchanged from reviewed amendment.

Security approved on rebased head 5551ef40; security posture unchanged from reviewed amendment.
core-security approved these changes 2026-05-23 20:47:01 +00:00
core-security left a comment
Member
Copy Link
Copy Source

Approved on rebased head.

Approved on rebased head.
hongming merged commit 2d1a853bf9 into main 2026-05-23 21:00:00 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
core-qa
core-security
Labels
Clear labels
area/ci
CI/CD pipeline issues
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1732
Delete Branch "feat/1686-display-workspace-flow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?