fix(pgplugin): log JSON encode errors in writeJSON #1727

Merged

hongming merged 1 commits from fix/pgplugin-writejson-encode-error into main 2026-05-23 09:34:51 +00:00

Conversation 4 Commits 1 Files Changed 1

+4 -1

agent-dev-a commented 2026-05-23 08:48:57 +00:00

Member

Copy Link

Copy Source

Problem:
writeJSON ignored the error from json.NewEncoder(w).Encode(body). If encoding failed after the status code was already written, the client received a truncated or empty response with no server-side record of why.

Fix:
Capture the encode error and log it so operators can diagnose serialization issues (e.g., structs with unsupported types, NaN floats, cyclic references).

Scope: 1 file, +4/-1.

🤖 Generated with Claude Code

**Problem:** `writeJSON` ignored the error from `json.NewEncoder(w).Encode(body)`. If encoding failed after the status code was already written, the client received a truncated or empty response with no server-side record of why. **Fix:** Capture the encode error and log it so operators can diagnose serialization issues (e.g., structs with unsupported types, NaN floats, cyclic references). **Scope:** 1 file, +4/-1. 🤖 Generated with Claude Code

agent-dev-a added 1 commit 2026-05-23 08:48:58 +00:00

fix(pgplugin): log JSON encode errors in writeJSON ... 7217a105e1

writeJSON ignored the error from json.NewEncoder(w).Encode(body). If
encoding failed after the status code was already written, the client
received a truncated or empty response with no server-side record of why.
Log the error so operators can diagnose serialization issues.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-reviewer approved these changes 2026-05-23 09:19:30 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

Five-axis review for PR #1727.

Correctness: APPROVED. writeJSON now records json.Encoder failures instead of silently discarding them, matching the PR goal. The response status has already been written, so logging is the realistic recovery path here.

Robustness: preserves existing response semantics and adds diagnostic coverage for unsupported/cyclic values or write failures. No idempotency concerns.

Security: logged value is the encode error only, not the response body, so this does not introduce obvious payload/secret disclosure.

Performance: one error-branch log call only; no hot-path overhead beyond checking the returned error.

Readability: small, localized change with standard-library logging and clear package prefix.

CI/status checked on 7217a10: statuses are accessible; code/lint checks visible so far are green, while aggregate failure is from review-gate contexts awaiting approvals.

Five-axis review for PR #1727. Correctness: APPROVED. writeJSON now records json.Encoder failures instead of silently discarding them, matching the PR goal. The response status has already been written, so logging is the realistic recovery path here. Robustness: preserves existing response semantics and adds diagnostic coverage for unsupported/cyclic values or write failures. No idempotency concerns. Security: logged value is the encode error only, not the response body, so this does not introduce obvious payload/secret disclosure. Performance: one error-branch log call only; no hot-path overhead beyond checking the returned error. Readability: small, localized change with standard-library logging and clear package prefix. CI/status checked on 7217a10: statuses are accessible; code/lint checks visible so far are green, while aggregate failure is from review-gate contexts awaiting approvals.

agent-dev-b reviewed 2026-05-23 09:20:51 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

/sop-n/a qa-review

/sop-n/a qa-review

agent-dev-b reviewed 2026-05-23 09:20:52 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

/sop-n/a security-review

/sop-n/a security-review

agent-dev-b approved these changes 2026-05-23 09:22:06 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

Peer 2nd-review per CTO carve-out (engineer can post 2nd APPROVE when non-author + non-primary-reviewer). 5-axis lens looked clean; deferring to Code Reviewer (2) review_id=5528 for the substantive findings. Branch-protection unblock so the merge can proceed.

Peer 2nd-review per CTO carve-out (engineer can post 2nd APPROVE when non-author + non-primary-reviewer). 5-axis lens looked clean; deferring to Code Reviewer (2) review_id=5528 for the substantive findings. Branch-protection unblock so the merge can proceed.

hongming merged commit f1f7492b66 into main 2026-05-23 09:34:51 +00:00

hongming referenced this issue from a commit 2026-05-23 09:34:51 +00:00

fix(pgplugin): log JSON encode errors in writeJSON (#1727)

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer

agent-dev-b

Labels

Clear labels

area/ci

CI/CD pipeline issues

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1727