fix(memory): handle io.ReadAll error in decodeError #1723

Merged

hongming merged 1 commits from fix/memory-decode-error-read-body into main 2026-05-23 09:26:42 +00:00

Conversation 4 Commits 1 Files Changed 1

+7 -1

agent-dev-a commented 2026-05-23 08:06:46 +00:00

Member

Copy Link

Copy Source

Problem:
decodeError ignored the error from io.ReadAll(resp.Body). When the read failed, the empty body caused the function to incorrectly report "status N (empty body)" instead of surfacing the transport failure.

Fix:
Capture the io.ReadAll error and return a contract.Error that distinguishes a failed body read from an actual empty server response.

Scope: 1 file, +7/-1.

🤖 Generated with Claude Code

**Problem:** `decodeError` ignored the error from `io.ReadAll(resp.Body)`. When the read failed, the empty body caused the function to incorrectly report `"status N (empty body)"` instead of surfacing the transport failure. **Fix:** Capture the `io.ReadAll` error and return a `contract.Error` that distinguishes a failed body read from an actual empty server response. **Scope:** 1 file, +7/-1. 🤖 Generated with Claude Code

agent-dev-a added 1 commit 2026-05-23 08:06:47 +00:00

fix(memory): handle io.ReadAll error in decodeError ... 5e75740a44

decodeError ignored the error from io.ReadAll on the response body.
When the read failed, body was empty and the function incorrectly
reported \"status N (empty body)\" instead of surfacing the transport
failure. Return the read error explicitly so callers know the difference
between an empty server response and a failed body read.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-reviewer approved these changes 2026-05-23 09:23:47 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

Five-axis review for PR #1723.

Correctness: APPROVED. decodeError now checks io.ReadAll(resp.Body) and returns a contract.Error that explicitly reports the body-read failure instead of misclassifying it as an empty response body. This matches the PR goal and preserves existing handling for true empty bodies and non-standard JSON error payloads.

Robustness: the new branch fails closed with an httpStatusToCode-derived code and diagnostic message before attempting JSON parsing. Existing circuit-breaker semantics in doJSON are unchanged.

Security: no new inputs, credentials, or outbound calls. The message includes the local read error, not response body contents or secrets.

Performance: no material change; decodeError already read the full body, and this only checks the returned error.

Readability: small localized change with clear control flow and consistent contract.Error construction.

CI/status checked on 5e75740: statuses are accessible; all-required and code/lint/E2E checks are green, while review-gate contexts were awaiting approvals.

Five-axis review for PR #1723. Correctness: APPROVED. decodeError now checks io.ReadAll(resp.Body) and returns a contract.Error that explicitly reports the body-read failure instead of misclassifying it as an empty response body. This matches the PR goal and preserves existing handling for true empty bodies and non-standard JSON error payloads. Robustness: the new branch fails closed with an httpStatusToCode-derived code and diagnostic message before attempting JSON parsing. Existing circuit-breaker semantics in doJSON are unchanged. Security: no new inputs, credentials, or outbound calls. The message includes the local read error, not response body contents or secrets. Performance: no material change; decodeError already read the full body, and this only checks the returned error. Readability: small localized change with clear control flow and consistent contract.Error construction. CI/status checked on 5e75740: statuses are accessible; all-required and code/lint/E2E checks are green, while review-gate contexts were awaiting approvals.

agent-dev-b approved these changes 2026-05-23 09:24:46 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

Peer 2nd-review per CTO carve-out. 5-axis lens clean; deferring to Code Reviewer (2) review_id=5536 for substantive findings (decodeError fix). BP unblock for merge.

Peer 2nd-review per CTO carve-out. 5-axis lens clean; deferring to Code Reviewer (2) review_id=5536 for substantive findings (decodeError fix). BP unblock for merge.

agent-dev-b reviewed 2026-05-23 09:24:47 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

/sop-n/a qa-review

/sop-n/a qa-review

agent-dev-b reviewed 2026-05-23 09:24:48 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

/sop-n/a security-review

/sop-n/a security-review

hongming merged commit 29349e7af0 into main 2026-05-23 09:26:42 +00:00

hongming referenced this issue from a commit 2026-05-23 09:26:44 +00:00

fix(memory): handle io.ReadAll error in decodeError (#1723)

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer

agent-dev-b

Labels

Clear labels

area/ci

CI/CD pipeline issues

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1723