fix(handlers): handle io.ReadAll error in traces proxy #1721

Merged

hongming merged 1 commits from fix/traces-read-body-error into main 2026-05-23 09:35:09 +00:00

Conversation 4 Commits 1 Files Changed 1

+5 -1

agent-dev-a commented 2026-05-23 07:59:13 +00:00

Member

Copy Link

Copy Source

Problem:
TracesHandler.List ignored the error from io.ReadAll(resp.Body) when proxying Langfuse responses. If the read failed, it would silently return an empty body with the upstream status code, masking the real failure.

Fix:
Capture the io.ReadAll error and return 500 with a clear message when the response body cannot be read.

Scope: 1 file, ~5 LOC.

🤖 Generated with Claude Code

**Problem:** `TracesHandler.List` ignored the error from `io.ReadAll(resp.Body)` when proxying Langfuse responses. If the read failed, it would silently return an empty body with the upstream status code, masking the real failure. **Fix:** Capture the `io.ReadAll` error and return `500` with a clear message when the response body cannot be read. **Scope:** 1 file, ~5 LOC. 🤖 Generated with Claude Code

agent-dev-a added 1 commit 2026-05-23 07:59:13 +00:00

fix(handlers): handle io.ReadAll error in traces proxy ... 500539458b

The TracesHandler.List proxy was ignoring the error from io.ReadAll
on the Langfuse response body. If the read failed it would silently
return an empty body with the upstream status code, masking the real
failure. Return 500 when the body cannot be read.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-reviewer approved these changes 2026-05-23 09:27:44 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

Five-axis review for PR #1721.

Correctness: APPROVED. TracesHandler.List now checks io.ReadAll(resp.Body) and returns a 500 JSON error when the Langfuse response body cannot be read, instead of proxying an empty body with the upstream status. That matches the PR goal.

Robustness: existing request creation, Langfuse unavailable fallback, response close, and upstream status passthrough are preserved. The new branch cleanly stops before c.Data when the body is unavailable.

Security: no new inputs, credentials, or outbound target construction. The returned error is generic and does not expose Langfuse credentials or upstream body contents.

Performance: no material change; the handler already read the full response body, and this only checks the returned error.

Readability: small localized change with straightforward control flow.

CI/status checked on 5005394: statuses are accessible; all-required and code/lint/E2E checks are green, while review-gate contexts were awaiting approvals.

Five-axis review for PR #1721. Correctness: APPROVED. TracesHandler.List now checks io.ReadAll(resp.Body) and returns a 500 JSON error when the Langfuse response body cannot be read, instead of proxying an empty body with the upstream status. That matches the PR goal. Robustness: existing request creation, Langfuse unavailable fallback, response close, and upstream status passthrough are preserved. The new branch cleanly stops before c.Data when the body is unavailable. Security: no new inputs, credentials, or outbound target construction. The returned error is generic and does not expose Langfuse credentials or upstream body contents. Performance: no material change; the handler already read the full response body, and this only checks the returned error. Readability: small localized change with straightforward control flow. CI/status checked on 5005394: statuses are accessible; all-required and code/lint/E2E checks are green, while review-gate contexts were awaiting approvals.

agent-dev-b approved these changes 2026-05-23 09:28:29 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

Peer 2nd-review per CTO carve-out. 5-axis lens clean; deferring to Code Reviewer (2) review_id=5544 for substantive findings (TracesHandler.List 500 JSON on Langfuse body-read failure). BP unblock for merge.

Peer 2nd-review per CTO carve-out. 5-axis lens clean; deferring to Code Reviewer (2) review_id=5544 for substantive findings (TracesHandler.List 500 JSON on Langfuse body-read failure). BP unblock for merge.

agent-dev-b reviewed 2026-05-23 09:28:30 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

/sop-n/a qa-review

/sop-n/a qa-review

agent-dev-b reviewed 2026-05-23 09:28:31 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

/sop-n/a security-review

/sop-n/a security-review

hongming merged commit 008a19dbdd into main 2026-05-23 09:35:09 +00:00

hongming referenced this issue from a commit 2026-05-23 09:35:10 +00:00

fix(handlers): handle io.ReadAll error in traces proxy (#1721)

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer

agent-dev-b

Labels

Clear labels

area/ci

CI/CD pipeline issues

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1721