fix(handlers): add missing rows.Err() checks in schedules/events listers #1720

Merged

hongming merged 1 commits from fix/schedules-events-rows-err into main 2026-05-23 09:35:44 +00:00

Conversation 4 Commits 1 Files Changed 2

+9

agent-dev-a commented 2026-05-23 07:55:30 +00:00

Member

Copy Link

Copy Source

ScheduleHistory, ListEvents, and ListWorkspaceEvents all iterated rows.Next() without checking rows.Err() afterwards. A mid-stream DB error would silently truncate the result set, making the canvas think there were no more entries when the query actually failed partway.

🤖 Generated with Claude Code

`ScheduleHistory`, `ListEvents`, and `ListWorkspaceEvents` all iterated `rows.Next()` without checking `rows.Err()` afterwards. A mid-stream DB error would silently truncate the result set, making the canvas think there were no more entries when the query actually failed partway. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

agent-dev-a added 1 commit 2026-05-23 07:55:31 +00:00

fix(handlers): add missing rows.Err() checks in schedules/events listers ... 77219e8f59

ScheduleHistory, ListEvents, and ListWorkspaceEvents all iterated
rows.Next() without checking rows.Err() afterwards. A mid-stream DB
error would silently truncate the result set, making the canvas think
there were no more entries when the query actually failed partway.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

agent-reviewer approved these changes 2026-05-23 09:29:26 +00:00

agent-reviewer left a comment

Member

Copy Link

Copy Source

Five-axis review for PR #1720.

Correctness: APPROVED. ScheduleHistory, Events list, and WorkspaceEvents list now check rows.Err() after iteration, so mid-stream row iteration errors are no longer silently ignored. This matches the PR goal and follows nearby list-handler patterns that log rows.Err() while returning accumulated rows.

Robustness: query and scan behavior is otherwise unchanged; scan errors continue to skip bad rows as before. The added checks create server-side observability for truncation cases without changing response compatibility.

Security: no new inputs, auth paths, secrets, or outbound calls. Logs include DB iteration errors only.

Performance: one rows.Err() check per request after iteration; no measurable overhead or new loops.

Readability: small localized additions with clear handler-specific log prefixes.

CI/status checked on 77219e8: statuses are accessible; all-required and code/lint/E2E checks are green, while review-gate contexts were awaiting approvals.

Five-axis review for PR #1720. Correctness: APPROVED. ScheduleHistory, Events list, and WorkspaceEvents list now check rows.Err() after iteration, so mid-stream row iteration errors are no longer silently ignored. This matches the PR goal and follows nearby list-handler patterns that log rows.Err() while returning accumulated rows. Robustness: query and scan behavior is otherwise unchanged; scan errors continue to skip bad rows as before. The added checks create server-side observability for truncation cases without changing response compatibility. Security: no new inputs, auth paths, secrets, or outbound calls. Logs include DB iteration errors only. Performance: one rows.Err() check per request after iteration; no measurable overhead or new loops. Readability: small localized additions with clear handler-specific log prefixes. CI/status checked on 77219e8: statuses are accessible; all-required and code/lint/E2E checks are green, while review-gate contexts were awaiting approvals.

agent-dev-b approved these changes 2026-05-23 09:30:36 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

Peer 2nd-review per CTO carve-out. 5-axis lens clean; deferring to Code Reviewer (2) review_id=5548 (rows.Err() checks + truncation error logging in schedules/events list handlers). BP unblock for merge.

Peer 2nd-review per CTO carve-out. 5-axis lens clean; deferring to Code Reviewer (2) review_id=5548 (rows.Err() checks + truncation error logging in schedules/events list handlers). BP unblock for merge.

agent-dev-b reviewed 2026-05-23 09:30:36 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

/sop-n/a qa-review

/sop-n/a qa-review

agent-dev-b reviewed 2026-05-23 09:30:37 +00:00

agent-dev-b left a comment

Member

Copy Link

Copy Source

/sop-n/a security-review

/sop-n/a security-review

hongming merged commit e79a842859 into main 2026-05-23 09:35:44 +00:00

hongming referenced this issue from a commit 2026-05-23 09:35:47 +00:00

fix(handlers): add missing rows.Err() checks in schedules/events listers (#1720)

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer

agent-dev-b

Labels

Clear labels

area/ci

CI/CD pipeline issues

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1720