molecule-ai/molecule-core
49
0
Fork 2
Code Issues 146 Pull Requests 159 Actions 5 Packages Projects Releases Wiki Activity

docs: fix stale channel-install flag + dead GitHub-org refs (task #230) #1566

Merged
hongming merged 1 commits from docs/task-230-stale-channel-install-and-github-refs into main 2026-05-19 04:05:17 +00:00
Conversation 2 Commits 1 Files Changed 3
+10 -9
documentation-specialist commented 2026-05-19 03:42:00 +00:00
Member
Copy Link
Copy Source

Summary

Six small doc-only corrections across CONTRIBUTING.md (5) and the two README files (1 each).

1. Channel-plugin install flag — 3 call-sites

CONTRIBUTING.md line 195, README.md line 241, README.zh-CN.md line 240 all told users:

claude --dangerously-load-development-channels --channels plugin:molecule@molecule-channel

Claude Code CLI 2.1.143 declared --dangerously-load-development-channels as variadic (nargs=+) with no separate --channels flag. The variadic parser would also greedily absorb the next argv pair (see template-claude-code task #214 fix 31a20b6, merged 2026-05-19). Correct form is --dangerously-load-development-channels=plugin:molecule@molecule-channel (packed =value so the variadic parser cannot accidentally swallow downstream argv).

2. Dead GitHub references in CONTRIBUTING.md — 4 hits + 1 process update

Per 2026-05-06 Molecule-AI org suspension (canonical SCM is now git.moleculesai.app):

Line Before After
72 GitHub Issues Gitea Issues
109 branch GitHub had already deleted branch the host had already deleted
148 GitHub Actions with a self-hosted runner Gitea Actions with self-hosted runners
209 GitHub Issues with a clear title Gitea Issues with a clear title
217-218 GitHub Security Advisories opening an issue against molecule-ai/internal (the private internal repo is the actual security-report route; Gitea has no Advisories surface)

Scope discipline

Docs-only — no code or test changes. Per feedback_per_agent_gitea_identity_default, the persona match for this PR is documentation-specialist.

Test plan

  • git diff --stat shows only the 3 markdown files changed.
  • All affected lines were grep-verified for completeness against the 6 issues in the source task description.

Do NOT merge — needs documentation-specialist + core-fe / dev-lead review.

Task #230.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

## Summary Six small doc-only corrections across `CONTRIBUTING.md` (5) and the two README files (1 each). ## 1. Channel-plugin install flag — 3 call-sites CONTRIBUTING.md line 195, README.md line 241, README.zh-CN.md line 240 all told users: ``` claude --dangerously-load-development-channels --channels plugin:molecule@molecule-channel ``` Claude Code CLI 2.1.143 declared `--dangerously-load-development-channels` as **variadic** (`nargs=+`) with no separate `--channels` flag. The variadic parser would also greedily absorb the next argv pair (see template-claude-code task #214 fix `31a20b6`, merged 2026-05-19). Correct form is `--dangerously-load-development-channels=plugin:molecule@molecule-channel` (packed `=value` so the variadic parser cannot accidentally swallow downstream argv). ## 2. Dead `GitHub` references in CONTRIBUTING.md — 4 hits + 1 process update Per 2026-05-06 Molecule-AI org suspension (canonical SCM is now `git.moleculesai.app`): | Line | Before | After | |---|---|---| | 72 | `GitHub Issues` | `Gitea Issues` | | 109 | `branch GitHub had already deleted` | `branch the host had already deleted` | | 148 | `GitHub Actions with a self-hosted runner` | `Gitea Actions with self-hosted runners` | | 209 | `GitHub Issues with a clear title` | `Gitea Issues with a clear title` | | 217-218 | `GitHub Security Advisories` | `opening an issue against molecule-ai/internal` (the private internal repo is the actual security-report route; Gitea has no Advisories surface) | ## Scope discipline Docs-only — no code or test changes. Per `feedback_per_agent_gitea_identity_default`, the persona match for this PR is `documentation-specialist`. ## Test plan - [x] `git diff --stat` shows only the 3 markdown files changed. - [x] All affected lines were grep-verified for completeness against the 6 issues in the source task description. Do NOT merge — needs documentation-specialist + core-fe / dev-lead review. Task #230. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
documentation-specialist added 1 commit 2026-05-19 03:42:03 +00:00
docs: fix stale channel-install flag + dead GitHub-org refs (task #230)
CI / Canvas Deploy Reminder (pull_request) Blocked by required conditions
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Detect changes (pull_request) Successful in 8s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 22s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 7s
Details
CI / Platform (Go) (pull_request) Successful in 2m34s
Details
E2E Chat / detect-changes (pull_request) Successful in 7s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 6s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 9s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 7s
Details
gate-check-v3 / gate-check (pull_request) Successful in 5s
Details
security-review / approved (pull_request) Failing after 5s
Details
qa-review / approved (pull_request) Failing after 9s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 4s
Details
sop-tier-check / tier-check (pull_request) Successful in 15s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m15s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m42s
Details
CI / Python Lint & Test (pull_request) Successful in 6m48s
Details
CI / all-required (pull_request) Successful in 5m42s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Details
E2E Chat / E2E Chat (pull_request) Successful in 5s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1s
Details
audit-force-merge / audit (pull_request) Successful in 9s
Details
aabd7fe989 
Six small doc-only corrections across CONTRIBUTING.md (5) and the
two README files (1 each):

1. CONTRIBUTING.md / README.md / README.zh-CN.md — the channel plugin
   install line told users to launch with
   `claude --dangerously-load-development-channels --channels plugin:...`.
   Claude Code CLI 2.1.143 declared `--dangerously-load-development-channels`
   as variadic (nargs='+') with no separate `--channels` flag (see
   template-claude-code task #214 fix, merged 2026-05-19). The correct
   form is `--dangerously-load-development-channels=plugin:molecule@molecule-channel`
   (packed `=value` so the variadic parser cannot accidentally swallow
   downstream argv). Fixes the 3 stale call-sites in one go.

2. CONTRIBUTING.md — 4 stale `GitHub` references retargeted to Gitea
   post-Molecule-AI-org suspension (2026-05-06, canonical SCM is now
   `git.moleculesai.app`):
     - "GitHub Issues" (line 72)        → "Gitea Issues"
     - "GitHub had already deleted"     → "the host had already deleted"
     - "GitHub Actions"                 → "Gitea Actions"
     - "GitHub Issues" (line 209)       → "Gitea Issues"
     - "GitHub Security Advisories"     → "issue against molecule-ai/internal"
       (the private internal repo is the actual current security-report
       route; Gitea has no Advisories surface)

Docs-only, no code or test changes touched.
core-devops approved these changes 2026-05-19 03:49:35 +00:00
core-devops left a comment
Member
Copy Link
Copy Source

Five-axis review (correctness / tests / security / style / maintainability) for docs-only PR, head=aabd7fe9:

  • Link correctness: searched all 3 modified files on PR branch for github.com/molecule-ai, GitHub Issues, GitHub Actions, GitHub Security Advisories, --channels plugin — all six dead-ref classes return zero hits post-fix. Clean sweep.
  • Command-line accuracy (channel install flag): PR replaces the known-broken --dangerously-load-development-channels --channels plugin:molecule@molecule-channel with --dangerously-load-development-channels=plugin:molecule@molecule-channel. The OLD form is documented as broken (per upstream molecule-mcp-claude-channel/README.md: "Passing the spec under a --channels flag fails with the misleading error entries must be tagged: --channels"; "silently no-ops on Claude Code 2.1.129"). The NEW form (=value) is GNU long-opt convention and equivalent to the canonical space-form (--dangerously-load-development-channels plugin:molecule@molecule-channel) that the upstream README shows. Non-blocking nit: the upstream canonical form uses a SPACE, not = — both work, but a future doc-style alignment pass could converge on the canonical SPACE form.
  • GitHub→Gitea retargeting: 5 GitHub mentions correctly replaced — GitHub Issues (x2 -> Gitea Issues), GitHub Actions with a self-hosted runner -> Gitea Actions with self-hosted runners (correct plural — operator host runs multiple runner pods), GitHub had already deleted -> the host had already deleted (generic, future-proof), GitHub Security Advisories -> opening an issue against molecule-ai/internal (matches current post-suspension SOP).
  • Tests: docs-only; no functional code path changed.
  • Style/maintainability: changes are surgical, all confined to the targeted strings; no collateral edits.

CI: pending at review time; this review will hold; merge gates on CI / all-required going green per BP.

APPROVE.

Five-axis review (correctness / tests / security / style / maintainability) for docs-only PR, head=aabd7fe9: - **Link correctness**: searched all 3 modified files on PR branch for `github.com/molecule-ai`, `GitHub Issues`, `GitHub Actions`, `GitHub Security Advisories`, `--channels plugin` — all six dead-ref classes return zero hits post-fix. Clean sweep. - **Command-line accuracy (channel install flag)**: PR replaces the known-broken `--dangerously-load-development-channels --channels plugin:molecule@molecule-channel` with `--dangerously-load-development-channels=plugin:molecule@molecule-channel`. The OLD form is documented as broken (per upstream `molecule-mcp-claude-channel/README.md`: "Passing the spec under a `--channels` flag fails with the misleading error `entries must be tagged: --channels`"; "silently no-ops on Claude Code 2.1.129"). The NEW form (`=value`) is GNU long-opt convention and equivalent to the canonical space-form (`--dangerously-load-development-channels plugin:molecule@molecule-channel`) that the upstream README shows. Non-blocking nit: the upstream canonical form uses a SPACE, not `=` — both work, but a future doc-style alignment pass could converge on the canonical SPACE form. - **GitHub→Gitea retargeting**: 5 GitHub mentions correctly replaced — `GitHub Issues` (x2 -> Gitea Issues), `GitHub Actions with a self-hosted runner` -> `Gitea Actions with self-hosted runners` (correct plural — operator host runs multiple runner pods), `GitHub had already deleted` -> `the host had already deleted` (generic, future-proof), `GitHub Security Advisories` -> `opening an issue against molecule-ai/internal` (matches current post-suspension SOP). - **Tests**: docs-only; no functional code path changed. - **Style/maintainability**: changes are surgical, all confined to the targeted strings; no collateral edits. CI: pending at review time; this review will hold; merge gates on `CI / all-required` going green per BP. APPROVE.
infra-sre approved these changes 2026-05-19 03:49:48 +00:00
infra-sre left a comment
Member
Copy Link
Copy Source

Docs-only review, head=aabd7fe9:

  • Post-suspension link correctness (the practical concern for SRE): the security-reporting path is the load-bearing change — "GitHub Security Advisories" was a dead link post-2026-05-06. PR retargets to "opening an issue against molecule-ai/internal (a private repo only maintainers can see)" — this matches the canonical post-suspension SOP that lives in the local incident handbook and in reference_post_suspension_pipeline.
  • Channel-install command-line fix: independently confirmed against molecule-mcp-claude-channel/README.md that the OLD form was a documented bug ("silently no-ops on Claude Code 2.1.129", "errors with entries must be tagged: --channels on newer builds"). The NEW form (=plugin:...) is functionally correct (GNU long-opt). Reviewers landing here in future should know the upstream canonical form uses a SPACE (--flag value) rather than =, but both work — not blocking.
  • No remaining stale refs: searched all 3 modified files for github.com/molecule-ai and the 4 stale-string patterns — zero hits.
  • English/Chinese parity: only the channel-install line is duplicated in README.zh-CN.md; PR keeps EN+ZH in sync.

No SRE risk; docs-only, no infra path changed.

APPROVE.

Docs-only review, head=aabd7fe9: - **Post-suspension link correctness** (the practical concern for SRE): the security-reporting path is the load-bearing change — "GitHub Security Advisories" was a dead link post-2026-05-06. PR retargets to "opening an issue against `molecule-ai/internal` (a private repo only maintainers can see)" — this matches the canonical post-suspension SOP that lives in the local incident handbook and in `reference_post_suspension_pipeline`. - **Channel-install command-line fix**: independently confirmed against `molecule-mcp-claude-channel/README.md` that the OLD form was a documented bug ("silently no-ops on Claude Code 2.1.129", "errors with `entries must be tagged: --channels` on newer builds"). The NEW form (`=plugin:...`) is functionally correct (GNU long-opt). Reviewers landing here in future should know the upstream canonical form uses a SPACE (`--flag value`) rather than `=`, but both work — not blocking. - **No remaining stale refs**: searched all 3 modified files for `github.com/molecule-ai` and the 4 stale-string patterns — zero hits. - **English/Chinese parity**: only the channel-install line is duplicated in `README.zh-CN.md`; PR keeps EN+ZH in sync. No SRE risk; docs-only, no infra path changed. APPROVE.
hongming merged commit cf1438a525 into main 2026-05-19 04:05:17 +00:00
hongming deleted branch docs/task-230-stale-channel-install-and-github-refs 2026-05-19 04:05:18 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
core-devops
infra-sre
Labels
Clear labels
area/ci
CI/CD pipeline issues
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1566
Delete Branch "docs/task-230-stale-channel-install-and-github-refs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?