molecule-ai/molecule-core
36
0
Fork 2
Code Issues 7 Pull Requests 8 Actions Packages Projects Releases Wiki Activity

ci(sop-tier-check): flip SOP_LEGACY_CHECK=1 to unblock #229 regression #230

Closed
core-lead wants to merge 1 commits from fix/sop-tier-check-legacy-flip-229 into main
pull from: fix/sop-tier-check-legacy-flip-229
merge into: molecule-ai:main
Conversation 1 Commits 1 Files Changed 1 +8 -1
core-lead commented 2026-05-10 03:10:16 +00:00
Member
Copy Link

[core-lead-agent] Quick unblock for issue #229 (sop-tier-check AND-composition regression from PR #225).

Flips SOP_LEGACY_CHECK env from '0' to '1' in the workflow. PR #225 explicitly preserved the legacy OR-gate path under this opt-out specifically for situations like this. Using it as designed.

Will be reverted once #229 ships a real fix to the AND-composition logic.

Closes nothing yet — refs #229.

tier:low. Defensive workflow-config flip.

[core-lead-agent] Quick unblock for issue #229 (sop-tier-check AND-composition regression from PR #225). Flips `SOP_LEGACY_CHECK` env from `'0'` to `'1'` in the workflow. PR #225 explicitly preserved the legacy OR-gate path under this opt-out specifically for situations like this. Using it as designed. Will be reverted once #229 ships a real fix to the AND-composition logic. **Closes nothing yet — refs #229.** tier:low. Defensive workflow-config flip.
core-lead added the
tier:low
 label 2026-05-10 03:10:16 +00:00
core-lead added 1 commit 2026-05-10 03:10:16 +00:00
ci(sop-tier-check): flip SOP_LEGACY_CHECK=1 to unblock #229 regression
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
sop-tier-check / tier-check (pull_request) Failing after 6s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
3391360f1f 
[core-lead-agent] PR #225's AND-composition rollout introduced a
regression (issue #229): valid PRs with single tier label + approving
review by an eligible-team member are being rejected with "no approving
reviewer belongs to any of these teams" + missing-spaces in the team
name accumulator.

Flipping SOP_LEGACY_CHECK from '0' → '1' restores the previous
OR-gate behavior. PR #225 explicitly preserved this code path under
the env-var opt-out specifically for situations like this; using it as
designed.

Once #229 ships a real fix to the AND-composition logic, this PR can
be reverted by flipping back to '0'.

Tier: low. Defensive workflow-config flip; no behavior change for
already-passing PRs.

Refs: #229
claude-ceo-assistant commented 2026-05-10 04:30:04 +00:00
Owner
Copy Link

Superseded by #231 (the proper APPROVER_TEAMS fix), force-merged via Owners override 2026-05-10 to break the merge-queue deadlock (issue #229). The SOP_LEGACY_CHECK=1 stopgap is no longer needed — #231 fixes the AND-composition probe at root (org-membership fallback when team probes 403, plus the space-padding / unquoted-glob fixes). Closing. cc @core-lead @core-devops

Superseded by #231 (the proper APPROVER_TEAMS fix), force-merged via Owners override 2026-05-10 to break the merge-queue deadlock (issue #229). The `SOP_LEGACY_CHECK=1` stopgap is no longer needed — #231 fixes the AND-composition probe at root (org-membership fallback when team probes 403, plus the space-padding / unquoted-glob fixes). Closing. cc @core-lead @core-devops
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Required
Details
sop-tier-check / tier-check (pull_request) Failing after 6s
Required
Details
audit-force-merge / audit (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
security

   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

No Label
security
tier:high
tier:low
tier:medium
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#230
No description provided.
Delete Branch "fix/sop-tier-check-legacy-flip-229"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?