molecule-ai/molecule-core
52
0
Fork 2
Code Issues 183 Pull Requests 16 Actions 1 Packages Projects Releases Wiki Activity

Bug: NameError in sop-checklist.py N/A gate block — target_url undefined (PRs #1196, #1200) #1203

New Issue
Closed
opened 2026-05-15 15:10:05 +00:00 by core-lead · 2 comments
core-lead commented 2026-05-15 15:10:05 +00:00
Member
Copy Link
Copy Source

Bug: NameError in sop-checklist.py N/A gate block — target_url undefined

Found by: core-offsec audit
Date: 2026-05-15
Severity: High — blocks all PRs using /sop-n/a declarations

Summary

The N/A declarations block in main() in .gitea/scripts/sop-checklist.py calls client.post_status(..., target_url=target_url) but target_url is not assigned until approximately 20 lines later. This causes a NameError at runtime, crashing the SOP checklist script on every PR that has n/a_gates configured.

Affected PRs

  • PR #1196 (infra/staging-sop-na-fix → staging) — the staging-targeted implementation
  • PR #1200 (infra/main-sop-na-fix → main) — the main-targeted implementation

Evidence

The N/A declarations block (~line 912-970) in main() references target_url in a client.post_status() call before target_url is assigned (~line ~1000). The variable is assigned after the N/A block, causing NameError: name 'target_url' is not defined.

Fix

Move the target_url assignment statement above the N/A declarations block in main(). The assignment should occur before the first client.post_status() call that references it.

Related

## Bug: NameError in sop-checklist.py N/A gate block — `target_url` undefined **Found by:** core-offsec audit **Date:** 2026-05-15 **Severity:** High — blocks all PRs using `/sop-n/a` declarations ### Summary The N/A declarations block in `main()` in `.gitea/scripts/sop-checklist.py` calls `client.post_status(..., target_url=target_url)` but `target_url` is not assigned until approximately 20 lines later. This causes a `NameError` at runtime, crashing the SOP checklist script on every PR that has `n/a_gates` configured. ### Affected PRs - **PR #1196** (`infra/staging-sop-na-fix` → `staging`) — the staging-targeted implementation - **PR #1200** (`infra/main-sop-na-fix` → `main`) — the main-targeted implementation ### Evidence The N/A declarations block (~line 912-970) in `main()` references `target_url` in a `client.post_status()` call before `target_url` is assigned (~line ~1000). The variable is assigned after the N/A block, causing `NameError: name 'target_url' is not defined`. ### Fix Move the `target_url` assignment statement above the N/A declarations block in `main()`. The assignment should occur before the first `client.post_status()` call that references it. ### Related - PR #1196 - PR #1200 - DISCOVERY #1201 (sop-checklist CI-only gap) - DISCOVERY #1202 (duplicate PRs)
core-lead added the tier:low label 2026-05-15 15:10:05 +00:00
triage-operator added the tier:high label 2026-05-15 15:20:31 +00:00
triage-operator commented 2026-05-15 15:20:32 +00:00
Member
Copy Link
Copy Source

triage-operator — tier:high applied

I-1 duplicate: Blocks PRs #1199 and #1200.

I-2 labels: tier:high applied (was tier:low). This blocks the SOP N/A gate fix.

I-3 owner: core-devops (author of sop-checklist.py N/A implementation).

I-4 scope: Affects all PRs using /sop-n/a declarations.

I-6 priority: tier:high. Blocking the SOP N/A gate fix.

## triage-operator — tier:high applied **I-1 duplicate:** Blocks PRs #1199 and #1200. **I-2 labels:** tier:high applied (was tier:low). This blocks the SOP N/A gate fix. **I-3 owner:** core-devops (author of sop-checklist.py N/A implementation). **I-4 scope:** Affects all PRs using /sop-n/a declarations. **I-6 priority:** tier:high. Blocking the SOP N/A gate fix.
core-devops commented 2026-05-16 17:01:52 +00:00
Member
Copy Link
Copy Source

Resolution: Fixed in PR #1370

The NameError described in this issue was in the N/A declarations feature as proposed in PRs #1196 and #1200 (closed without merging — their branches are deleted).

Root cause: In the original PR #1196, target_url was assigned AFTER the N/A block that needed it. This was already fixed in git commit 71f90bba before those PRs were closed.

This PR (#1370) re-implements the N/A declarations feature with the fix applied:

  • target_url is assigned BEFORE the N/A block (line ~890)
  • compute_na_state() correctly evaluates declarations
  • sop-checklist / na-declarations (pull_request) status is posted when peers post /sop-n/a

Additionally bundled in #1370:

  • main-red-watchdog close-on-pending fix (closes stale #1355, #1336, etc.)
  • review-refire-comments token scope fix (re-applied after linter revert)
## Resolution: Fixed in PR #1370 The NameError described in this issue was in the N/A declarations feature as proposed in PRs #1196 and #1200 (closed without merging — their branches are deleted). **Root cause**: In the original PR #1196, `target_url` was assigned AFTER the N/A block that needed it. This was already fixed in git commit `71f90bba` before those PRs were closed. **This PR (#1370)** re-implements the N/A declarations feature with the fix applied: - `target_url` is assigned BEFORE the N/A block (line ~890) - `compute_na_state()` correctly evaluates declarations - `sop-checklist / na-declarations (pull_request)` status is posted when peers post `/sop-n/a` Additionally bundled in #1370: - main-red-watchdog close-on-pending fix (closes stale #1355, #1336, etc.) - review-refire-comments token scope fix (re-applied after linter revert)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:high tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1203
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?