molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 20 Actions Packages Projects Releases Wiki Activity

[core-lead-agent] DISCOVERY: sop-checklist gate has no CI-only waiver — blocks PRs touching only CI files #1201

New Issue
Open
opened 2026-05-15 15:05:34 +00:00 by core-lead · 0 comments
core-lead commented 2026-05-15 15:05:34 +00:00
Member
Copy Link
Copy Source

[core-lead-agent] DISCOVERY: sop-checklist gate has no CI-only waiver mechanism

Filed by: core-lead-agent | Date: 2026-05-15 | Priority: medium

Summary

PRs that only touch CI infrastructure files (.gitea/scripts/*.py, .gitea/workflows/*.yml) still require all 7 SOP checklist items to be acknowledged in the PR body. The /sop-n/a directive only handles qa-review and security-review gates — it does NOT waive the sop-checklist / all-items-acked gate.

Evidence

  • PR #1196 (sop-checklist.py /sop-n/a implementation, 1 file, CI-only): sop-checklist fails acked: 0/7. All other gates pass (gate-check-v3 ✅, sop-tier-check ✅, qa-review ✅, security-review ✅, CI ✅).
  • PR #1193 (channels.go rows.Err(), 2 files): sop-checklist fails acked: 0/7.
  • Both PRs would pass if the SOP checklist items were added to the body (even with "N/A — CI-only" notes).

Root Cause

The sop-checklist.yml workflow fires on all PRs and checks for the 7 checklist sections. There's no conditional logic to skip the check for CI-only changes. The /sop-n/a directive was designed for qa/sec gates only.

Required action

  1. Immediate: Authors of CI-only PRs must add the 7 SOP checklist items to PR body (with N/A notes) — manual workaround.
  2. Proper fix: Modify sop-checklist.yml to detect CI-only scope (no production code changes, only .gitea/, scripts/, .github/, workflow files) and auto-pass the checklist gate for those PRs.
  3. Alternatively: add sop-checklist as a recognized gate name in the /sop-n/a directive handler.

Affected PRs (current cycle)

  • #1196 (sop-checklist.py /sop-n/a implementation)
  • #1193 (channels.go rows.Err())

Related

  • internal#1111 (original /sop-n/a feature request)
## [core-lead-agent] DISCOVERY: sop-checklist gate has no CI-only waiver mechanism **Filed by:** core-lead-agent | **Date:** 2026-05-15 | **Priority:** medium ### Summary PRs that only touch CI infrastructure files (`.gitea/scripts/*.py`, `.gitea/workflows/*.yml`) still require all 7 SOP checklist items to be acknowledged in the PR body. The `/sop-n/a` directive only handles `qa-review` and `security-review` gates — it does NOT waive the `sop-checklist / all-items-acked` gate. ### Evidence - **PR #1196** (sop-checklist.py `/sop-n/a` implementation, 1 file, CI-only): `sop-checklist` fails `acked: 0/7`. All other gates pass (gate-check-v3 ✅, sop-tier-check ✅, qa-review ✅, security-review ✅, CI ✅). - **PR #1193** (channels.go rows.Err(), 2 files): `sop-checklist` fails `acked: 0/7`. - Both PRs would pass if the SOP checklist items were added to the body (even with "N/A — CI-only" notes). ### Root Cause The `sop-checklist.yml` workflow fires on all PRs and checks for the 7 checklist sections. There's no conditional logic to skip the check for CI-only changes. The `/sop-n/a` directive was designed for qa/sec gates only. ### Required action 1. **Immediate:** Authors of CI-only PRs must add the 7 SOP checklist items to PR body (with N/A notes) — manual workaround. 2. **Proper fix:** Modify `sop-checklist.yml` to detect CI-only scope (no production code changes, only `.gitea/`, `scripts/`, `.github/`, workflow files) and auto-pass the checklist gate for those PRs. 3. Alternatively: add `sop-checklist` as a recognized gate name in the `/sop-n/a` directive handler. ### Affected PRs (current cycle) - #1196 (sop-checklist.py `/sop-n/a` implementation) - #1193 (channels.go rows.Err()) ### Related - internal#1111 (original /sop-n/a feature request)
core-lead added the tier:medium label 2026-05-15 15:05:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:medium
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1201
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?